Skip to content

[WIP] Address APIView feedback for azure-ai-projects#40541

Closed
Copilot wants to merge 1 commit intomainfrom
copilot/apply-apis-feedback-customizations
Closed

[WIP] Address APIView feedback for azure-ai-projects#40541
Copilot wants to merge 1 commit intomainfrom
copilot/apply-apis-feedback-customizations

Conversation

Copy link
Contributor

Copilot AI commented Feb 19, 2026

Thanks for assigning this issue to me. I'm starting to work on it and will keep this PR's description up to date as I form a plan and make progress.

Original prompt

This section details on the original issue you should resolve

<issue_title>Address APIView feedback for azure-ai-projects (Python)</issue_title>
<issue_description># Current Task

Apply TypeSpec client customizations to address APIView feedback comments.

Package Name: azure-ai-projects
Language: Python
APIView URL: https://spa.apiview.dev/review/a8bd55fd470240e29e7648d13a7882eb?activeApiRevisionId=4d0eae84b6bf476bbebf0aba84d6cb68

Feedback to Address

APIView Comments (65 unresolved)

LineNo Element LineText CommentText
229 azure.ai.projects.aio.operations.AgentsOperations.delete:async.returntype ) -> DeleteAgentResponse Return None for delete operations despite the Python emitter not currently supporting this, pending future support as per issue #3542.
1722 azure.ai.projects.models.AsyncUpdateMemoriesLROPoller.superseded_by property superseded_by: Optional[str] # Read-only LRO metadata properties should be exposed via a unified 'details' property rather than as separate read‐only attributes.
1723 azure.ai.projects.models.AsyncUpdateMemoriesLROPoller.update_id property update_id: str # Read-only LRO metadata properties should be accessed through the 'details' mapping instead of being defined individually.
1869 azure.ai.projects.models.AzureAISearchIndex.__init___4 def init(self, mapping: Mapping[str, Any]) -> None Duplicate mapping overload; remove this overload to avoid redundancy.
2196 azure.ai.projects.models.BlobReferenceSasCredential.init def init( GA classes should define explicit, typed parameters rather than accepting untyped *args and **kwargs. Suggestion : def __init__(self, *, sas_uri: str) -> None
2225 azure.ai.projects.models.BrowserAutomationPreviewTool.__init___4 def init(self, mapping: Mapping[str, Any]) -> None Duplicate mapping overload; remove this overload to avoid redundancy.
2409 azure.ai.projects.models.CodeBasedEvaluatorDefinition.data_schema(dict[str, any]) ivar data_schema: dict[str, any] Use 'Any' instead of 'any' in type annotations for consistency and correctness. Suggestion : ivar data_schema: dict[str, Any] Guidelines https://azure.github.io/azure-sdk/python_implementation.html#python-codestyle-type-naming
2410 azure.ai.projects.models.CodeBasedEvaluatorDefinition.init_parameters(dict[str, any]) ivar init_parameters: dict[str, any] Replace the lowercase 'any' with 'Any' in the type annotation to follow proper type naming conventions. Suggestion : ivar init_parameters: dict[str, Any] Guidelines https://azure.github.io/azure-sdk/python_implementation.html#python-codestyle-type-naming
3830 azure.ai.projects.models.FileDatasetVersion.tags(dict[str, str]) ivar tags: dict[str, str] The 'tags' field should be optional to match the init parameter signature. Suggestion : ivar tags: Optional[dict[str, str]]
3943 azure.ai.projects.models.FolderDatasetVersion.connection_name(str) ivar connection_name: str The 'connection_name' field should be optional to align with the init parameters. Suggestion : ivar connection_name: Optional[str]
3945 azure.ai.projects.models.FolderDatasetVersion.description(str) ivar description: str The 'description' field should be optional to align with the init parameters. Suggestion : ivar description: Optional[str]
3949 azure.ai.projects.models.FolderDatasetVersion.tags(dict[str, str]) ivar tags: dict[str, str] The 'tags' field should be optional to match the init parameter signature. Suggestion : ivar tags: Optional[dict[str, str]]
5589 azure.ai.projects.models.KeyPressAction.keys_property(list[str]) ivar keys_property: list[str] Choose an alternative name to 'keys_property' to avoid conflict with the 'keys()' method and improve intuitiveness.
5606 azure.ai.projects.models.KeyPressAction.__init___3.param(type) type: str The init parameter 'type' type should be updated to a literal that matches the documented ivar for consistency. Suggestion : type: Literal[ComputerActionType.KEYPRESS]
5649 azure.ai.projects.models.LocalShellToolParam.__init___3.param(type) type: str The init parameter 'type' should be specified as a literal to align with its ivar declaration. Suggestion : type: Literal[ToolType.LOCAL_SHELL]
5732 azure.ai.projects.models.MCPTool.__init___3.param(type) type: str The init parameter 'type' doesn’t match the ivar literal type; update it to ensure consistency. Suggestion : type: Literal[ToolType.MCP]
5914 azure.ai.projects.models.MemorySearchPreviewTool.__init___3.param(type) type: str The init parameter 'type' should be updated to a literal type reflecting the ivar for improved type safety. Suggestion : `type: Literal[ToolTyp...

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@github-actions
Copy link

github-actions bot commented Feb 19, 2026

Next Steps to Merge

⌛ Please wait. Next steps to merge this PR are being evaluated by automation. ⌛

Comment generated by summarize-checks workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Address APIView feedback for azure-ai-projects (Python)

2 participants

Comments