[WIP] Address APIView feedback for azure-ai-projects#40541
Closed
[WIP] Address APIView feedback for azure-ai-projects#40541
Conversation
Next Steps to Merge⌛ Please wait. Next steps to merge this PR are being evaluated by automation. ⌛Comment generated by summarize-checks workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for assigning this issue to me. I'm starting to work on it and will keep this PR's description up to date as I form a plan and make progress.
Original prompt
This section details on the original issue you should resolve
<issue_title>Address APIView feedback for azure-ai-projects (Python)</issue_title>
<issue_description># Current Task
Apply TypeSpec client customizations to address APIView feedback comments.
Package Name: azure-ai-projects
Language: Python
APIView URL: https://spa.apiview.dev/review/a8bd55fd470240e29e7648d13a7882eb?activeApiRevisionId=4d0eae84b6bf476bbebf0aba84d6cb68
Feedback to Address
APIView Comments (65 unresolved)
def __init__(self, *, sas_uri: str) -> Noneivar data_schema: dict[str, Any]Guidelines https://azure.github.io/azure-sdk/python_implementation.html#python-codestyle-type-namingivar init_parameters: dict[str, Any]Guidelines https://azure.github.io/azure-sdk/python_implementation.html#python-codestyle-type-namingivar tags: Optional[dict[str, str]]ivar connection_name: Optional[str]ivar description: Optional[str]ivar tags: Optional[dict[str, str]]type: Literal[ComputerActionType.KEYPRESS]type: Literal[ToolType.LOCAL_SHELL]type: Literal[ToolType.MCP]💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.