Skip to content

quota, java, backward-compatible change #37493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 17, 2025
Merged

quota, java, backward-compatible change #37493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f75c97
java, quota, backward compatibility
weidongxu-microsoft Sep 17, 2025
e7b3805
mitigation
weidongxu-microsoft Sep 17, 2025
020a1fd
another place
weidongxu-microsoft Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 12 additions & 14 deletions specification/quota/Quota.Management/CurrentQuotaLimitBase.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,14 @@ model CurrentQuotaLimitBase
>;
}

alias CurrentQuotaLimitBasesResponseHeaders = {
/**
* Current entity state version. Should be treated as opaque and used to make conditional HTTP requests.
*/
@header("ETag")
eTag: string;
};

#suppress "@azure-tools/typespec-azure-resource-manager/no-resource-delete-operation" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
@armResourceOperations
interface CurrentQuotaLimitBases {
Expand All @@ -32,13 +40,8 @@ interface CurrentQuotaLimitBases {
get is Extension.Read<
Extension.ScopeParameter,
CurrentQuotaLimitBase,
Response = ArmResponse<CurrentQuotaLimitBase> & {
/**
* Current entity state version. Should be treated as opaque and used to make conditional HTTP requests.
*/
@header("ETag")
eTag: string;
},
Response = ArmResponse<CurrentQuotaLimitBase> &
CurrentQuotaLimitBasesResponseHeaders,
Error = ExceptionResponse
>;

Expand Down Expand Up @@ -78,13 +81,8 @@ interface CurrentQuotaLimitBases {
list is Extension.ListByTarget<
Extension.ScopeParameter,
CurrentQuotaLimitBase,
Response = ArmResponse<QuotaLimits> & {
/**
* Current entity state version. Should be treated as opaque and used to make conditional HTTP requests.
*/
@header("ETag")
eTag: string;
},
Response = ArmResponse<QuotaLimits> &
CurrentQuotaLimitBasesResponseHeaders,
Error = ExceptionResponse
>;
}
Expand Down
3 changes: 3 additions & 0 deletions specification/quota/Quota.Management/client.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,3 +62,6 @@ using Microsoft.Quota;
@@usage(SubmittedResourceRequestStatus, Usage.input, "csharp");

@@clientName(Microsoft.Quota, "QuotaMgmtClient", "python");

// Java-specific fixes for breaking changes
@@clientName(CurrentQuotaLimitBasesResponseHeaders.eTag, "etag", "java");