From e8d6993f224419c197b55ec5ca064ec151bf6af5 Mon Sep 17 00:00:00 2001 From: Neehar Duvvuri Date: Mon, 17 Mar 2025 12:26:28 -0400 Subject: [PATCH 1/3] address index feedback --- .../ai/Azure.AI.Projects/indexes/models.tsp | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/specification/ai/Azure.AI.Projects/indexes/models.tsp b/specification/ai/Azure.AI.Projects/indexes/models.tsp index 7e192328b51f..7b9f4599784f 100644 --- a/specification/ai/Azure.AI.Projects/indexes/models.tsp +++ b/specification/ai/Azure.AI.Projects/indexes/models.tsp @@ -41,8 +41,8 @@ model AzureAISearchIndex extends Index { @doc("Type of index") indexType: IndexType.azureSearch; - @doc("Connection id to Azure AI Search") - connectionId: string; + @doc("Name of connection to Azure AI Search") + connectionName: string; @doc("Name of index in Azure AI Search resource to attach") indexName: string; @@ -62,8 +62,8 @@ model CosmosDBIndex extends Index { @doc("Type of index") indexType: IndexType.cosmosDB; - @doc("Connection id to CosmosDB") - connectionId: string; + @doc("Name of connection to CosmosDB") + connectionName: string; @doc("Name of the CosmosDB Database") databaseName: string; @@ -77,11 +77,8 @@ model CosmosDBIndex extends Index { @doc("Embedding configuration class") model EmbeddingConfiguration { - @doc("Connection id to embedding model") - connectionId?: string; - - @doc("Deployment name of embedding model") - deploymentName: string; + @doc("Deployment name of embedding model. It can point to a model deployment either in the parent AIServices or a connection.") + modelDeploymentName: string; @doc("Embedding field") embeddingField: string; From ff4a4877ad5db83beb3d732d8584e9426b456ac0 Mon Sep 17 00:00:00 2001 From: Neehar Duvvuri Date: Mon, 17 Mar 2025 14:37:02 -0400 Subject: [PATCH 2/3] update swagger file --- .../azure-ai-projects-1dp.json | 22 ++++++++----------- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/specification/ai/data-plane/Azure.AI.Projects/preview/2025-05-01-preview/azure-ai-projects-1dp.json b/specification/ai/data-plane/Azure.AI.Projects/preview/2025-05-01-preview/azure-ai-projects-1dp.json index 67a5d1fcee02..9910e4b68087 100644 --- a/specification/ai/data-plane/Azure.AI.Projects/preview/2025-05-01-preview/azure-ai-projects-1dp.json +++ b/specification/ai/data-plane/Azure.AI.Projects/preview/2025-05-01-preview/azure-ai-projects-1dp.json @@ -9249,9 +9249,9 @@ "type": "object", "description": "Azure AI Search Index Definition", "properties": { - "connectionId": { + "connectionName": { "type": "string", - "description": "Connection id to Azure AI Search" + "description": "Name of connection to Azure AI Search" }, "indexName": { "type": "string", @@ -9259,7 +9259,7 @@ } }, "required": [ - "connectionId", + "connectionName", "indexName" ], "allOf": [ @@ -9399,9 +9399,9 @@ "type": "object", "description": "CosmosDB Vector Store Index Definition", "properties": { - "connectionId": { + "connectionName": { "type": "string", - "description": "Connection id to CosmosDB" + "description": "Name of connection to CosmosDB" }, "databaseName": { "type": "string", @@ -9417,7 +9417,7 @@ } }, "required": [ - "connectionId", + "connectionName", "databaseName", "containerName", "embeddingConfiguration" @@ -9614,13 +9614,9 @@ "type": "object", "description": "Embedding configuration class", "properties": { - "connectionId": { - "type": "string", - "description": "Connection id to embedding model" - }, - "deploymentName": { + "modelDeploymentName": { "type": "string", - "description": "Deployment name of embedding model" + "description": "Deployment name of embedding model. It can point to a model deployment either in the parent AIServices or a connection." }, "embeddingField": { "type": "string", @@ -9628,7 +9624,7 @@ } }, "required": [ - "deploymentName", + "modelDeploymentName", "embeddingField" ] }, From d2085df90344b0d7d4bc9ca159115f62056a708d Mon Sep 17 00:00:00 2001 From: Neehar Duvvuri Date: Mon, 17 Mar 2025 15:30:38 -0400 Subject: [PATCH 3/3] Change indexType -> index --- specification/ai/Azure.AI.Projects/indexes/models.tsp | 10 +++++----- .../2025-05-01-preview/azure-ai-projects-1dp.json | 6 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/specification/ai/Azure.AI.Projects/indexes/models.tsp b/specification/ai/Azure.AI.Projects/indexes/models.tsp index 7b9f4599784f..c3f2573dee11 100644 --- a/specification/ai/Azure.AI.Projects/indexes/models.tsp +++ b/specification/ai/Azure.AI.Projects/indexes/models.tsp @@ -15,10 +15,10 @@ using Azure.Core.Traits; namespace Azure.AI.Projects; @doc("Index resource Definition") -@discriminator("indexType") +@discriminator("type") model Index { @doc("Type of index") - indexType: IndexType; + type: IndexType; ...AssetBase; } @@ -39,7 +39,7 @@ model PagedIndex { @doc("Azure AI Search Index Definition") model AzureAISearchIndex extends Index { @doc("Type of index") - indexType: IndexType.azureSearch; + type: IndexType.azureSearch; @doc("Name of connection to Azure AI Search") connectionName: string; @@ -51,7 +51,7 @@ model AzureAISearchIndex extends Index { @doc("Managed Azure AI Search Index Definition") model ManagedAzureAISearchIndex extends Index { @doc("Type of index") - indexType: IndexType.managedAzureSearch; + type: IndexType.managedAzureSearch; @doc("Vector store id of managed index") vectorStoreId: string; @@ -60,7 +60,7 @@ model ManagedAzureAISearchIndex extends Index { @doc("CosmosDB Vector Store Index Definition") model CosmosDBIndex extends Index { @doc("Type of index") - indexType: IndexType.cosmosDB; + type: IndexType.cosmosDB; @doc("Name of connection to CosmosDB") connectionName: string; diff --git a/specification/ai/data-plane/Azure.AI.Projects/preview/2025-05-01-preview/azure-ai-projects-1dp.json b/specification/ai/data-plane/Azure.AI.Projects/preview/2025-05-01-preview/azure-ai-projects-1dp.json index 9910e4b68087..19e8ae232615 100644 --- a/specification/ai/data-plane/Azure.AI.Projects/preview/2025-05-01-preview/azure-ai-projects-1dp.json +++ b/specification/ai/data-plane/Azure.AI.Projects/preview/2025-05-01-preview/azure-ai-projects-1dp.json @@ -9767,7 +9767,7 @@ "type": "object", "description": "Index resource Definition", "properties": { - "indexType": { + "type": { "$ref": "#/definitions/IndexType", "description": "Type of index" }, @@ -9812,9 +9812,9 @@ "readOnly": true } }, - "discriminator": "indexType", + "discriminator": "type", "required": [ - "indexType" + "type" ] }, "IndexType": {