Skip to content

Use identifiers decorator#32919

Merged
AlitzelMendez merged 9 commits into
Azure:typespec-nextfrom
AlitzelMendez:use-identifiers-decorator
Feb 28, 2025
Merged

Use identifiers decorator#32919
AlitzelMendez merged 9 commits into
Azure:typespec-nextfrom
AlitzelMendez:use-identifiers-decorator

Conversation

@AlitzelMendez

Copy link
Copy Markdown
Member

Replace usage of @extensions decorator to @Identifiers decorators

This had some implications

  • Removed completely the decorator for string[] and union[], this caused that some .json files were regenerated
  • For some of the union[] scenarios, removing it was causing .net sdk generation issues so I undo those changes
  • Some cases were not updated, I will investigate these scenarios

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

@openapi-pipeline-app

openapi-pipeline-app Bot commented Feb 28, 2025

Copy link
Copy Markdown

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ Your PR has breaking changes in the generated SDK for Go (label: BreakingChange-Go-Sdk). Refer to step 3 in the PR workflow diagram.
  • ❌ Your PR has breaking changes in the generated SDK for Python (label: BreakingChange-Python-Sdk). Refer to step 3 in the PR workflow diagram.

@openapi-pipeline-app

openapi-pipeline-app Bot commented Feb 28, 2025

Copy link
Copy Markdown

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

This was referenced Feb 28, 2025
This was referenced Feb 28, 2025
Comment thread specification/workloads/Workloads.SAPVirtualInstance.Management/models.tsp Outdated
@AlitzelMendez AlitzelMendez merged commit 29a704e into Azure:typespec-next Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants