Skip to content

Conversation

@cthrash
Copy link
Contributor

@cthrash cthrash commented Jun 12, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Jun 12, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2614

@AutorestCI
Copy link

AutorestCI commented Jun 12, 2018

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

@AutorestCI
Copy link

AutorestCI commented Jun 12, 2018

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1349

@AutorestCI
Copy link

AutorestCI commented Jun 12, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2033

@AutorestCI
Copy link

AutorestCI commented Jun 12, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2901

@marstr
Copy link
Member

marstr commented Jun 12, 2018

Ready for me to merge?

@cthrash
Copy link
Contributor Author

cthrash commented Jun 12, 2018

Yes please

@marstr marstr merged commit 6a41b51 into Azure:master Jun 12, 2018
@cthrash cthrash deleted the cthrash/computervision-add-es branch June 13, 2018 01:17
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
[Communication] Remove async response from RegenerateKey
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants