From d030d186dbfe96d7fc0c19d4161546f542430ac1 Mon Sep 17 00:00:00 2001 From: Francisco Gamino Date: Wed, 31 Jul 2024 02:15:02 -0700 Subject: [PATCH 1/2] Microsft.Web 2023-12-01: Add int32 format to all number types in the scaleAndConcurrency section of the functionAppConfig (#29907) * Set format to int32 for all number types in the functionAppConfig * Update types to integer. --------- Co-authored-by: Naveed Aziz --- .../stable/2023-12-01/CommonDefinitions.json | 12 ++++++++---- .../web/resource-manager/sdk-suppressions.yaml | 4 ++++ 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/specification/web/resource-manager/Microsoft.Web/stable/2023-12-01/CommonDefinitions.json b/specification/web/resource-manager/Microsoft.Web/stable/2023-12-01/CommonDefinitions.json index 9d879719bd8f..2a8279ef091c 100644 --- a/specification/web/resource-manager/Microsoft.Web/stable/2023-12-01/CommonDefinitions.json +++ b/specification/web/resource-manager/Microsoft.Web/stable/2023-12-01/CommonDefinitions.json @@ -3677,7 +3677,8 @@ "description": "Either a function group or a function name is required. For additional information see https://aka.ms/flexconsumption/alwaysready." }, "instanceCount": { - "type": "number", + "type": "integer", + "format": "int32", "description": "Sets the number of 'Always Ready' instances for a given function group or a specific function. For additional information see https://aka.ms/flexconsumption/alwaysready." } } @@ -3695,11 +3696,13 @@ }, "maximumInstanceCount": { "description": "The maximum number of instances for the function app.", - "type": "number" + "type": "integer", + "format": "int32" }, "instanceMemoryMB": { "description": "Set the amount of memory allocated to each instance of the function app in MB. CPU and network bandwidth are allocated proportionally.", - "type": "number" + "type": "integer", + "format": "int32" }, "triggers": { "type": "object", @@ -3710,7 +3713,8 @@ "description": "Scale and concurrency settings for the HTTP trigger.", "properties": { "perInstanceConcurrency": { - "type": "number", + "type": "integer", + "format": "int32", "description": "The maximum number of concurrent HTTP trigger invocations per instance." } } diff --git a/specification/web/resource-manager/sdk-suppressions.yaml b/specification/web/resource-manager/sdk-suppressions.yaml index 5c4893ca65ce..bb74db7a0a12 100644 --- a/specification/web/resource-manager/sdk-suppressions.yaml +++ b/specification/web/resource-manager/sdk-suppressions.yaml @@ -17,3 +17,7 @@ suppressions: - Function `*StaticSitesClient.BeginApproveOrRejectPrivateEndpointConnection` parameter(s) have been changed from `(context.Context, string, string, string, PrivateLinkConnectionApprovalRequestResource, *StaticSitesClientBeginApproveOrRejectPrivateEndpointConnectionOptions)` to `(context.Context, string, string, string, RemotePrivateEndpointConnectionARMResource, *StaticSitesClientBeginApproveOrRejectPrivateEndpointConnectionOptions)` - Function `*WebAppsClient.BeginApproveOrRejectPrivateEndpointConnectionSlot` parameter(s) have been changed from `(context.Context, string, string, string, string, PrivateLinkConnectionApprovalRequestResource, *WebAppsClientBeginApproveOrRejectPrivateEndpointConnectionSlotOptions)` to `(context.Context, string, string, string, string, RemotePrivateEndpointConnectionARMResource, *WebAppsClientBeginApproveOrRejectPrivateEndpointConnectionSlotOptions)` - Function `*WebAppsClient.BeginApproveOrRejectPrivateEndpointConnection` parameter(s) have been changed from `(context.Context, string, string, string, PrivateLinkConnectionApprovalRequestResource, *WebAppsClientBeginApproveOrRejectPrivateEndpointConnectionOptions)` to `(context.Context, string, string, string, RemotePrivateEndpointConnectionARMResource, *WebAppsClientBeginApproveOrRejectPrivateEndpointConnectionOptions)` + - Type of `FunctionsAlwaysReadyConfig.InstanceCount` has been changed from `*float32` to `*int32` + - Type of `FunctionsScaleAndConcurrency.InstanceMemoryMB` has been changed from `*float32` to `*int32` + - Type of `FunctionsScaleAndConcurrency.MaximumInstanceCount` has been changed from `*float32` to `*int32` + - Type of `FunctionsScaleAndConcurrencyTriggersHTTP.PerInstanceConcurrency` has been changed from `*float32` to `*int32` \ No newline at end of file From 0c7574af922073394d25e18aaa3a94e5557222ef Mon Sep 17 00:00:00 2001 From: Francisco-Gamino Date: Thu, 1 Aug 2024 16:50:24 -0700 Subject: [PATCH 2/2] Update types to integer and set format to int32 for all number types in the functionAppConfig --- .../stable/2024-04-01/CommonDefinitions.json | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/specification/web/resource-manager/Microsoft.Web/stable/2024-04-01/CommonDefinitions.json b/specification/web/resource-manager/Microsoft.Web/stable/2024-04-01/CommonDefinitions.json index 2467571fe8e3..32fde219d9a9 100644 --- a/specification/web/resource-manager/Microsoft.Web/stable/2024-04-01/CommonDefinitions.json +++ b/specification/web/resource-manager/Microsoft.Web/stable/2024-04-01/CommonDefinitions.json @@ -3697,7 +3697,8 @@ "description": "Either a function group or a function name is required. For additional information see https://aka.ms/flexconsumption/alwaysready." }, "instanceCount": { - "type": "number", + "type": "integer", + "format": "int32", "description": "Sets the number of 'Always Ready' instances for a given function group or a specific function. For additional information see https://aka.ms/flexconsumption/alwaysready." } } @@ -3715,11 +3716,13 @@ }, "maximumInstanceCount": { "description": "The maximum number of instances for the function app.", - "type": "number" + "type": "integer", + "format": "int32" }, "instanceMemoryMB": { "description": "Set the amount of memory allocated to each instance of the function app in MB. CPU and network bandwidth are allocated proportionally.", - "type": "number" + "type": "integer", + "format": "int32" }, "triggers": { "type": "object", @@ -3730,7 +3733,8 @@ "description": "Scale and concurrency settings for the HTTP trigger.", "properties": { "perInstanceConcurrency": { - "type": "number", + "type": "integer", + "format": "int32", "description": "The maximum number of concurrent HTTP trigger invocations per instance." } }