Skip to content

Fix casing of timestamp properties #29675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lmazuel merged 7 commits into from
Jul 10, 2024
Merged

Fix casing of timestamp properties #29675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
39d4db1
Fix casing of timestamp properties
JoshLove-msft Jul 2, 2024
f626c22
Fix examples
JoshLove-msft Jul 2, 2024
0524b94
more examples
JoshLove-msft Jul 2, 2024
145efbc
Merge branch 'main' into acs-naming-fix
JoshLove-msft Jul 9, 2024
23f3d2b
property overrides
JoshLove-msft Jul 9, 2024
e53bab1
regen swagger
JoshLove-msft Jul 9, 2024
e991be7
Merge branch 'acs-naming-fix' of https://github.com/JoshLove-msft/azu…
JoshLove-msft Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...e.Messaging.EventGrid.SystemEvents/Microsoft.Communication/AzureCommunicationServices.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ model AcsEmailDeliveryReportReceivedEventData {
deliveryStatusDetails: AcsEmailDeliveryReportStatusDetails;

/** The time at which the email delivery report received timestamp */
deliveryAttemptTimeStamp: utcDateTime;
deliveryAttemptTimestamp: utcDateTime;
}

/** Schema of the Data property of an EventGridEvent for a Microsoft.Communication.EmailEngagementTrackingReportReceived event. */
Expand All @@ -267,7 +267,7 @@ model AcsEmailEngagementTrackingReportReceivedEventData {
messageId?: string;

/** The time at which the user interacted with the email */
userActionTimeStamp: utcDateTime;
userActionTimestamp: utcDateTime;

/** The context of the type of engagement user had with email */
engagementContext?: string;
Expand Down
2 changes: 1 addition & 1 deletion ....Messaging.EventGrid.SystemEvents/examples/2024-01-01/email_delivery_report_received.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"recipient": "[email protected]",
"messageId": "950850f5-bcdf-4315-b77a-6447cf56fac9",
"status": "delivered",
"deliveryAttemptTimeStamp": "2023-02-09T19:46:12.2480265+00:00"
"deliveryAttemptTimestamp": "2023-02-09T19:46:12.2480265+00:00"
},
"type": "Microsoft.Communication.EmailDeliveryReportReceived",
"time": "2023-02-09T19:46:12.2478002Z",
Expand Down
2 changes: 1 addition & 1 deletion ...EventGrid.SystemEvents/examples/2024-01-01/email_engagement_tracking_report_received.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"data": {
"sender": "[email protected]",
"messageId": "fe26a737-6941-410c-b126-7eacbe4035d1",
"userActionTimeStamp": "2023-02-09T20:07:22.745555+00:00",
"userActionTimestamp": "2023-02-09T20:07:22.745555+00:00",
"engagementContext": "www.example.com",
"userAgent": "Desktop",
"engagementType": "click"
Expand Down
8 changes: 0 additions & 8 deletions specification/eventgrid/Azure.Messaging.EventGrid.SystemEvents/propertyNameOverride.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,6 @@ using Azure.ClientGenerator.Core;
);
@@clientName(AcsRouterWorkerSelector.value, "labelValue", "autorest");

@@clientName(AcsEmailDeliveryReportReceivedEventData.deliveryAttemptTimeStamp,
"deliveryAttemptTimestamp",
"autorest"
);
@@clientName(AcsEmailEngagementTrackingReportReceivedEventData.userActionTimeStamp,
"userActionTimestamp",
"autorest"
);
@@clientName(AcsEmailEngagementTrackingReportReceivedEventData.engagementType,
"engagement",
"autorest"
Expand Down
8 changes: 0 additions & 8 deletions ...ification/eventgrid/Azure.Messaging.EventGrid.SystemEvents/propertyNameOverrideCsharp.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,6 @@ using Microsoft.EventGrid.SystemEvents;
"csharp"
);

@@clientName(AcsEmailDeliveryReportReceivedEventData.deliveryAttemptTimeStamp,
"deliveryAttemptTimestamp",
"csharp"
);
@@clientName(AcsEmailEngagementTrackingReportReceivedEventData.userActionTimeStamp,
"userActionTimestamp",
"csharp"
);
@@clientName(AcsEmailEngagementTrackingReportReceivedEventData.engagementType,
"engagement",
"csharp"
Expand Down
8 changes: 0 additions & 8 deletions specification/eventgrid/Azure.Messaging.EventGrid.SystemEvents/propertyNameOverrideGo.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,10 +333,6 @@ using Microsoft.EventGrid.SystemEvents;
"ACSEmailDeliveryReportReceivedEventData",
"go"
);
@@clientName(AcsEmailDeliveryReportReceivedEventData.deliveryAttemptTimeStamp,
"DeliveryAttemptTimestamp",
"go"
);

@@clientName(AcsEmailDeliveryReportStatus,
"ACSEmailDeliveryReportStatus",
Expand All @@ -355,10 +351,6 @@ using Microsoft.EventGrid.SystemEvents;
"Engagement",
"go"
);
@@clientName(AcsEmailEngagementTrackingReportReceivedEventData.userActionTimeStamp,
"UserActionTimestamp",
"go"
);

@@clientName(AcsIncomingCallCustomContext,
"ACSIncomingCallCustomContext",
Expand Down
10 changes: 2 additions & 8 deletions specification/eventgrid/Azure.Messaging.EventGrid.SystemEvents/propertyNameOverrideJs.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,7 @@ using Microsoft.EventGrid.SystemEvents;
"toCommunicationIdentifier",
"javascript"
);
@@clientName(AcsEmailEngagementTrackingReportReceivedEventData.userActionTimeStamp,
"userActionTimestamp",
"javascript"
);

@@clientName(AcsEmailEngagementTrackingReportReceivedEventData.engagementType,
"engagement",
"javascript"
Expand All @@ -65,10 +62,7 @@ using Microsoft.EventGrid.SystemEvents;
"summaryReportBlobUri",
"javascript"
);
@@clientName(AcsEmailDeliveryReportReceivedEventData.deliveryAttemptTimeStamp,
"deliveryAttemptTimestamp",
"javascript"
);

@@clientName(ResourceNotificationsResourceUpdatedEventData.resourceInfo,
"resourceDetails",
"javascript"
Expand Down
10 changes: 4 additions & 6 deletions ...grid/data-plane/Microsoft.Communication/stable/2018-01-01/AzureCommunicationServices.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1480,11 +1480,10 @@
"description": "Detailed information about the status if any",
"$ref": "#/definitions/AcsEmailDeliveryReportStatusDetails"
},
"deliveryAttemptTimeStamp": {
"deliveryAttemptTimestamp": {
"description": "The time at which the email delivery report received timestamp",
"format": "date-time",
"type": "string",
"x-ms-client-name": "deliveryAttemptTimestamp"
"type": "string"
}
}
},
Expand All @@ -1504,11 +1503,10 @@
"description": "The Id of the email that has been sent",
"type": "string"
},
"userActionTimeStamp": {
"userActionTimestamp": {
"description": "The time at which the user interacted with the email",
"format": "date-time",
"type": "string",
"x-ms-client-name": "userActionTimestamp"
"type": "string"
},
"engagementContext": {
"description": "The context of the type of engagement user had with email",
Expand Down
2 changes: 1 addition & 1 deletion ...cation/stable/2018-01-01/examples/cloud-events-schema/email_delivery_report_received.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"recipient": "[email protected]",
"messageId": "950850f5-bcdf-4315-b77a-6447cf56fac9",
"status": "delivered",
"deliveryAttemptTimeStamp": "2023-02-09T19:46:12.2480265+00:00"
"deliveryAttemptTimestamp": "2023-02-09T19:46:12.2480265+00:00"
},
"type": "Microsoft.Communication.EmailDeliveryReportReceived",
"time": "2023-02-09T19:46:12.2478002Z",
Expand Down
2 changes: 1 addition & 1 deletion ...le/2018-01-01/examples/cloud-events-schema/email_engagement_tracking_report_received.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"data": {
"sender": "[email protected]",
"messageId": "fe26a737-6941-410c-b126-7eacbe4035d1",
"userActionTimeStamp": "2023-02-09T20:07:22.745555+00:00",
"userActionTimestamp": "2023-02-09T20:07:22.745555+00:00",
"engagementContext": "www.example.com",
"userAgent": "Desktop",
"engagementType": "click"
Expand Down
2 changes: 1 addition & 1 deletion ...nication/stable/2018-01-01/examples/event-grid-schema/email_delivery_report_received.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"recipient": "[email protected]",
"messageId": "950850f5-bcdf-4315-b77a-6447cf56fac9",
"status": "delivered",
"deliveryAttemptTimeStamp": "2023-02-09T19:46:12.2480265+00:00",
"deliveryAttemptTimestamp": "2023-02-09T19:46:12.2480265+00:00",
"deliveryStatusDetails": {
"statusMessage": "DestinationMailboxFull"
}
Expand Down
2 changes: 1 addition & 1 deletion ...able/2018-01-01/examples/event-grid-schema/email_engagement_tracking_report_received.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"data": {
"sender": "[email protected]",
"messageId": "fe26a737-6941-410c-b126-7eacbe4035d1",
"userActionTimeStamp": "2023-02-09T20:07:22.745555+00:00",
"userActionTimestamp": "2023-02-09T20:07:22.745555+00:00",
"engagementContext": "www.example.com",
"userAgent": "Desktop",
"engagementType": "click"
Expand Down
14 changes: 6 additions & 8 deletions specification/eventgrid/data-plane/Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -718,17 +718,16 @@
"$ref": "#/definitions/AcsEmailDeliveryReportStatusDetails",
"description": "Detailed information about the status if any"
},
"deliveryAttemptTimeStamp": {
"deliveryAttemptTimestamp": {
"type": "string",
"format": "date-time",
"description": "The time at which the email delivery report received timestamp",
"x-ms-client-name": "deliveryAttemptTimestamp"
"description": "The time at which the email delivery report received timestamp"
}
},
"required": [
"status",
"deliveryStatusDetails",
"deliveryAttemptTimeStamp"
"deliveryAttemptTimestamp"
]
},
"AcsEmailDeliveryReportStatus": {
Expand Down Expand Up @@ -805,11 +804,10 @@
"type": "string",
"description": "The Id of the email that has been sent"
},
"userActionTimeStamp": {
"userActionTimestamp": {
"type": "string",
"format": "date-time",
"description": "The time at which the user interacted with the email",
"x-ms-client-name": "userActionTimestamp"
"description": "The time at which the user interacted with the email"
},
"engagementContext": {
"type": "string",
Expand All @@ -826,7 +824,7 @@
}
},
"required": [
"userActionTimeStamp",
"userActionTimestamp",
"engagementType"
]
},
Expand Down