Skip to content

Adding identity for scale rules #28283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ms-henglu merged 4 commits into from
Mar 26, 2024
Merged

Adding identity for scale rules #28283

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
57468e8
Adding identity for scale rules
vturecek Mar 15, 2024
86cc552
Merge branch 'release-app-Microsoft.App-2024-02-02-preview' into kedamsi
vturecek Mar 15, 2024
2d8e56e
fix scale example
vturecek Mar 21, 2024
a716688
Merge branch 'kedamsi' of https://github.com/vturecek/azure-rest-api-…
vturecek Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions ...tion/app/resource-manager/Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,10 @@
"x-ms-identifiers": [
"triggerParameter"
]
},
"identity": {
"description": "The resource ID of a user-assigned managed identity that is assigned to the Container App, or 'system' for system-assigned identity.",
"type": "string"
}
}
},
Expand Down Expand Up @@ -429,6 +433,10 @@
"x-ms-identifiers": [
"triggerParameter"
]
},
"identity": {
Copy link
Member

@jijohn14 jijohn14 Mar 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not blocking your change - Could this be moved to base definition and referenced for all scale rules

"description": "The resource ID of a user-assigned managed identity that is assigned to the Container App, or 'system' for system-assigned identity.",
"type": "string"
}
}
},
Expand All @@ -452,6 +460,10 @@
"x-ms-identifiers": [
"triggerParameter"
]
},
"identity": {
"description": "The resource ID of a user-assigned managed identity that is assigned to the Container App, or 'system' for system-assigned identity.",
"type": "string"
}
}
},
Expand All @@ -477,6 +489,10 @@
"x-ms-identifiers": [
"triggerParameter"
]
},
"identity": {
"description": "The resource ID of a user-assigned managed identity that is assigned to the Container App, or 'system' for system-assigned identity.",
"type": "string"
}
}
},
Expand Down
4 changes: 4 additions & 0 deletions specification/app/resource-manager/Microsoft.App/preview/2024-02-02-preview/Jobs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -979,6 +979,10 @@
"items": {
"$ref": "./CommonDefinitions.json#/definitions/ScaleRuleAuth"
}
},
"identity": {
"description": "The resource ID of a user-assigned managed identity that is assigned to the job, or 'system' for system-assigned identity.",
"type": "string"
}
}
},
Expand Down
24 changes: 24 additions & 0 deletions ...nager/Microsoft.App/preview/2024-02-02-preview/examples/ContainerApps_CreateOrUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,18 @@
"concurrentRequests": "50"
}
}
},
{
"name": "servicebus",
"custom": {
"type": "azure-servicebus",
"metadata": {
"queueName": "myqueue",
"namespace": "mynamespace",
"messageCount": "5"
},
"identity": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourcegroups/rg/providers/Microsoft.ManagedIdentity/userAssignedIdentities/myidentity"
}
}
]
},
Expand Down Expand Up @@ -343,6 +355,18 @@
"concurrentRequests": "50"
}
}
},
{
"name": "servicebus",
"custom": {
"type": "azure-servicebus",
"metadata": {
"queueName": "myqueue",
"namespace": "mynamespace",
"messageCount": "5"
},
"identity": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourcegroups/rg/providers/Microsoft.ManagedIdentity/userAssignedIdentities/myidentity"
}
}
]
},
Expand Down
12 changes: 12 additions & 0 deletions ...resource-manager/Microsoft.App/preview/2024-02-02-preview/examples/ContainerApps_Get.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,18 @@
"concurrentRequests": "50"
}
}
},
{
"name": "servicebus",
"custom": {
"type": "azure-servicebus",
"metadata": {
"queueName": "myqueue",
"namespace": "mynamespace",
"messageCount": "5"
},
"identity": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourcegroups/rg/providers/Microsoft.ManagedIdentity/userAssignedIdentities/myidentity"
}
}
]
},
Expand Down
34 changes: 33 additions & 1 deletion ...esource-manager/Microsoft.App/preview/2024-02-02-preview/examples/Job_CreateorUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,23 @@
"while true; do echo hello; sleep 10;done"
]
}
]
],
"scale": {
"minExecutions": 1,
"maxExecutions": 5,
"rules": [
{
"name": "servicebus",
"type": "azure-servicebus",
"metadata": {
"queueName": "myqueue",
"namespace": "mynamespace",
"messageCount": "5"
},
"identity": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourcegroups/rg/providers/Microsoft.ManagedIdentity/userAssignedIdentities/myidentity"
}
]
}
}
}
}
Expand Down Expand Up @@ -151,6 +167,22 @@
]
}
],
"scale": {
"minExecutions": 1,
"maxExecutions": 5,
"rules": [
{
"name": "servicebus",
"type": "azure-servicebus",
"metadata": {
"queueName": "myqueue",
"namespace": "mynamespace",
"messageCount": "5"
},
"identity": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourcegroups/rg/providers/Microsoft.ManagedIdentity/userAssignedIdentities/myidentity"
}
]
},
"volumes": [
{
"name": "azurefile",
Expand Down
16 changes: 16 additions & 0 deletions ...ation/app/resource-manager/Microsoft.App/preview/2024-02-02-preview/examples/Job_Get.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,22 @@
}
}
],
"scale": {
"minExecutions": 1,
"maxExecutions": 5,
"rules": [
{
"name": "servicebus",
"type": "azure-servicebus",
"metadata": {
"queueName": "myqueue",
"namespace": "mynamespace",
"messageCount": "5"
},
"identity": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourcegroups/rg/providers/Microsoft.ManagedIdentity/userAssignedIdentities/myidentity"
}
]
},
"volumes": [
{
"name": "azurefile",
Expand Down