From 1fc34636fb7599c7cfdcd9d26b30365ebba0173b Mon Sep 17 00:00:00 2001 From: JoshuaLai <9044372+JoshuaLai@users.noreply.github.com> Date: Fri, 24 Nov 2023 18:40:42 +0000 Subject: [PATCH 1/3] Updating examples and documents --- .../communicationserviceschat.json | 2 +- ...Messages_ListChatMessagesWithPageSize.json | 32 +++++++++++++------ 2 files changed, 24 insertions(+), 10 deletions(-) diff --git a/specification/communication/data-plane/Chat/preview/2023-11-15-preview/communicationserviceschat.json b/specification/communication/data-plane/Chat/preview/2023-11-15-preview/communicationserviceschat.json index 5c0d3e90cf35..095c2649aa68 100644 --- a/specification/communication/data-plane/Chat/preview/2023-11-15-preview/communicationserviceschat.json +++ b/specification/communication/data-plane/Chat/preview/2023-11-15-preview/communicationserviceschat.json @@ -1378,7 +1378,7 @@ } }, "ChatAttachment": { - "description": "An attachment in a chat message.", + "description": "An attachment in a chat message. Currently only supported in Teams Interop scenarios.", "required": [ "id", "attachmentType" diff --git a/specification/communication/data-plane/Chat/preview/2023-11-15-preview/examples/Messages_ListChatMessagesWithPageSize.json b/specification/communication/data-plane/Chat/preview/2023-11-15-preview/examples/Messages_ListChatMessagesWithPageSize.json index 9e1fcc0cfc4d..39a23368fcd7 100644 --- a/specification/communication/data-plane/Chat/preview/2023-11-15-preview/examples/Messages_ListChatMessagesWithPageSize.json +++ b/specification/communication/data-plane/Chat/preview/2023-11-15-preview/examples/Messages_ListChatMessagesWithPageSize.json @@ -2,7 +2,7 @@ "parameters": { "endpoint": "https://contoso.westus.communications.azure.com", "api-version": "2023-11-15-preview", - "chatThreadId": "19:453dafb77b26481ea2e73bcada0324af@thread.v2", + "chatThreadId": "19:meeting_453dafb77b26481ea2e73bcada0324af@thread.v2", "maxPageSize": 5 }, "responses": { @@ -11,19 +11,33 @@ "value": [ { "id": "1593107077690", - "type": "text", + "type": "html", "version": "1593107077683", "sequenceId": "5", "content": { - "message": "So where should we get lunch from today?" + "message": "

This place for lunch? 

\r\n

\"image\"

", + "attachments": [ + { + "id": "0-canaryeus-d1-907ca0083e8f3bef6793e5a46c0ded73", + "attachmentType": "teamsInlineImage", + "contentType": "png", + "name": "image", + "url": "https://contoso.westus.communications.azure.com/chat/threads/19:meeting_453dafb77b26481ea2e73bcada0324af@thread.v2/messages/1700844519132/teamsInterop/images/0-canaryeus-d1-907ca0083e8f3bef6793e5a46c0ded73/views/original?api-version=2023-07-01-preview", + "previewUrl": "https://contoso.westus.communications.azure.com/chat/threads/19:meeting_453dafb77b26481ea2e73bcada0324af@thread.v2/messages/1700844519132/teamsInterop/images/0-canaryeus-d1-907ca0083e8f3bef6793e5a46c0ded73/views/small?api-version=2023-07-01-preview" + } + ] }, "senderDisplayName": "Jane", "createdOn": "2020-06-25T17:44:37.6830000Z", - "senderCommunicationIdentifier": { - "rawId": "8:acs:8540c0de-899f-5cce-acb5-3ec493af3800_0e59221d-0c1d-46ae-9544-c963ce56c10b", - "communicationUser": { - "id": "8:acs:8540c0de-899f-5cce-acb5-3ec493af3800_0e59221d-0c1d-46ae-9544-c963ce56c10b" - } + "metadata": { + "amsreferences": "[\"0-canaryeus-d1-907ca0083e8f3bef6793e5a46c0ded73\"]" + }, + "sender": { + "kind": "microsoftTeamsUser", + "microsoftTeamsUserId": "8540c0de-899f-5cce-acb5-3ec493af3800_0e59221d-0c1d-46ae-9544-c963ce56c10b", + "isAnonymous": false, + "cloud": "public", + "rawId": "8:orgid:8540c0de-899f-5cce-acb5-3ec493af3800_0e59221d-0c1d-46ae-9544-c963ce56c10b" } }, { @@ -118,7 +132,7 @@ "createdOn": "2020-06-25T17:42:56.7530000Z" } ], - "nextLink": "https://contoso.westus.communications.azure.com/chat/threads/19:453dafb77b26481ea2e73bcada0324af@thread.v2/messages?syncState=3e4700000031393a756e6930315f7a626e68336e74326466756666657a6333736f7837646f67377766686b36793571653272776c6e66686c68647a69726968647071407468726561642e763201451fe6e77201000004357fea72010000&startTime=0&maxPageSize=5&api-version=2023-11-15-preview" + "nextLink": "https://contoso.westus.communications.azure.com/chat/threads/19:meeting_453dafb77b26481ea2e73bcada0324af@thread.v2/messages?syncState=3e4700000031393a756e6930315f7a626e68336e74326466756666657a6333736f7837646f67377766686b36793571653272776c6e66686c68647a69726968647071407468726561642e763201451fe6e77201000004357fea72010000&startTime=0&maxPageSize=5&api-version=2023-11-15-preview" } }, "401": { From ffb37d32ef7693c61563efbe35520299dc976386 Mon Sep 17 00:00:00 2001 From: JoshuaLai <9044372+JoshuaLai@users.noreply.github.com> Date: Mon, 27 Nov 2023 17:17:32 +0000 Subject: [PATCH 2/3] Updating the examples as per comments --- .../Messages_ListChatMessagesWithPageSize.json | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/specification/communication/data-plane/Chat/preview/2023-11-15-preview/examples/Messages_ListChatMessagesWithPageSize.json b/specification/communication/data-plane/Chat/preview/2023-11-15-preview/examples/Messages_ListChatMessagesWithPageSize.json index 39a23368fcd7..3c7fe21fa1c3 100644 --- a/specification/communication/data-plane/Chat/preview/2023-11-15-preview/examples/Messages_ListChatMessagesWithPageSize.json +++ b/specification/communication/data-plane/Chat/preview/2023-11-15-preview/examples/Messages_ListChatMessagesWithPageSize.json @@ -19,10 +19,9 @@ "attachments": [ { "id": "0-canaryeus-d1-907ca0083e8f3bef6793e5a46c0ded73", - "attachmentType": "teamsInlineImage", - "contentType": "png", + "attachmentType": "image", "name": "image", - "url": "https://contoso.westus.communications.azure.com/chat/threads/19:meeting_453dafb77b26481ea2e73bcada0324af@thread.v2/messages/1700844519132/teamsInterop/images/0-canaryeus-d1-907ca0083e8f3bef6793e5a46c0ded73/views/original?api-version=2023-07-01-preview", + "url": "https://contoso.westus.communications.azure.com/chat/threads/19:meeting_453dafb77b26481ea2e73bcada0324af@thread.v2/images/0-canaryeus-d1-907ca0083e8f3bef6793e5a46c0ded73/views/original?api-version=2023-07-01-preview", "previewUrl": "https://contoso.westus.communications.azure.com/chat/threads/19:meeting_453dafb77b26481ea2e73bcada0324af@thread.v2/messages/1700844519132/teamsInterop/images/0-canaryeus-d1-907ca0083e8f3bef6793e5a46c0ded73/views/small?api-version=2023-07-01-preview" } ] @@ -32,12 +31,11 @@ "metadata": { "amsreferences": "[\"0-canaryeus-d1-907ca0083e8f3bef6793e5a46c0ded73\"]" }, - "sender": { - "kind": "microsoftTeamsUser", - "microsoftTeamsUserId": "8540c0de-899f-5cce-acb5-3ec493af3800_0e59221d-0c1d-46ae-9544-c963ce56c10b", - "isAnonymous": false, - "cloud": "public", - "rawId": "8:orgid:8540c0de-899f-5cce-acb5-3ec493af3800_0e59221d-0c1d-46ae-9544-c963ce56c10b" +"senderCommunicationIdentifier": { + "rawId": "8540c0de-899f-5cce-acb5-3ec493af3800_0e59221d-0c1d-46ae-9544-c963ce56c10b", + "communicationUser": { + "id": "8540c0de-899f-5cce-acb5-3ec493af3800_0e59221d-0c1d-46ae-9544-c963ce56c10b" + } } }, { From c2afccf8042d360fbb9b51be7c04068f679a4305 Mon Sep 17 00:00:00 2001 From: JoshuaLai <9044372+JoshuaLai@users.noreply.github.com> Date: Mon, 27 Nov 2023 20:48:43 +0000 Subject: [PATCH 3/3] Updating prettier errors --- .../examples/Messages_ListChatMessagesWithPageSize.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/communication/data-plane/Chat/preview/2023-11-15-preview/examples/Messages_ListChatMessagesWithPageSize.json b/specification/communication/data-plane/Chat/preview/2023-11-15-preview/examples/Messages_ListChatMessagesWithPageSize.json index 3c7fe21fa1c3..012d42ecc588 100644 --- a/specification/communication/data-plane/Chat/preview/2023-11-15-preview/examples/Messages_ListChatMessagesWithPageSize.json +++ b/specification/communication/data-plane/Chat/preview/2023-11-15-preview/examples/Messages_ListChatMessagesWithPageSize.json @@ -31,7 +31,7 @@ "metadata": { "amsreferences": "[\"0-canaryeus-d1-907ca0083e8f3bef6793e5a46c0ded73\"]" }, -"senderCommunicationIdentifier": { + "senderCommunicationIdentifier": { "rawId": "8540c0de-899f-5cce-acb5-3ec493af3800_0e59221d-0c1d-46ae-9544-c963ce56c10b", "communicationUser": { "id": "8540c0de-899f-5cce-acb5-3ec493af3800_0e59221d-0c1d-46ae-9544-c963ce56c10b"