diff --git a/.github/PULL_REQUEST_TEMPLATE/ARM_spec_pr_review_workflow_diagram.png b/.github/PULL_REQUEST_TEMPLATE/ARM_spec_pr_review_workflow_diagram.png index 2c2487a213a3..6705514d73d8 100644 Binary files a/.github/PULL_REQUEST_TEMPLATE/ARM_spec_pr_review_workflow_diagram.png and b/.github/PULL_REQUEST_TEMPLATE/ARM_spec_pr_review_workflow_diagram.png differ diff --git a/.github/PULL_REQUEST_TEMPLATE/control_plane_template.md b/.github/PULL_REQUEST_TEMPLATE/control_plane_template.md index 4c332b3cbd65..3b7c9bd9d93a 100644 --- a/.github/PULL_REQUEST_TEMPLATE/control_plane_template.md +++ b/.github/PULL_REQUEST_TEMPLATE/control_plane_template.md @@ -4,7 +4,7 @@ Please understand this diagram before proceeding. It explains how to get your PR approved & merged. -![diagram](https://github.com/Azure/azure-rest-api-specs/assets/4429827/029a11fd-eaf9-4865-9d77-a16b5ea5eb26) +![diagram](https://github.com/Azure/azure-rest-api-specs/assets/20296335/35140fb9-639e-4e44-ac4b-38b1a20dddf9)
Click here to see the details of Step 1 @@ -36,13 +36,11 @@ If the automation determines you have breaking changes, i.e. Step 1 from the dia ### Diagram footnotes -[1] [ARM review queue] (for **merge** queues, see [4]) +[1] [ARM review queue] (for **merge** queues, see [2]) The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page. If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label `ARMChangesRequested` -is removed from your PR. This should cause the label `WaitForARMFeedback` to be added. -[2] https://aka.ms/azsdk/support/specreview-channel -[3] [List of SDK breaking changes approvers] in pinned Teams announcement -[4] [public repo merge queue], [private repo merge queue] (for **ARM review** queue, [1]) +is removed from your PR. This should cause the label `WaitForARMFeedback` to be added. +[2] [public repo merge queue], [private repo merge queue] (for **ARM review** queue, [1]) If you need further help with anything, see `Getting help` section below. @@ -97,7 +95,6 @@ This should result in a new comment denoting a `PR validation pipeline` has star - If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR. [ARM review queue]: https://github.com/search?q=org%3AAzure+is%3Apr+is%3Aopen+label%3AWaitForARMFeedback+-label%3AIDCDevDiv++draft%3Afalse+sort%3Acreated-asc+&type=pullrequests -[List of SDK breaking changes approvers]: https://teams.microsoft.com/l/message/19:0351f5f9404446e4b4fd4eaf2c27448d@thread.skype/1689115217750?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=3e17dcb0-4257-4a30-b843-77f47f1d4121&parentMessageId=1689115217750&teamName=Azure%20SDK&channelName=API%20Spec%20Review&createdTime=1689115217750 [public repo merge queue]: https://github.com/Azure/azure-rest-api-specs/pulls?q=is%3Aopen+is%3Apr+label%3AMergeRequested+draft%3Afalse+sort%3Acreated-asc [private repo merge queue]: https://github.com/Azure/azure-rest-api-specs-pr/pulls?q=is%3Aopen+is%3Apr+label%3AMergeRequested+-label%3AApproved-OkToMerge+draft%3Afalse+sort%3Acreated-asc [breaking changes process]: https://eng.ms/docs/cloud-ai-platform/azure-core/azure-core-pm-and-design/trusted-platform-pm-karimb/service-lifecycle-and-actions-team/service-lifecycle-actions-team/apex/media/launchingproductbreakingchanges#breaking-change-process-1