From 5261eca6b9882261fda7418afd853f8487e83364 Mon Sep 17 00:00:00 2001 From: Mike Harder Date: Fri, 13 Oct 2023 06:20:32 +0000 Subject: [PATCH] [TypeSpec Validation] Quote argument to "tsp format" - Prevents shell expansion which may miss files --- eng/tools/TypeSpecValidation/src/rules/format.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/tools/TypeSpecValidation/src/rules/format.ts b/eng/tools/TypeSpecValidation/src/rules/format.ts index 8d901731c921..1d8835e73b58 100644 --- a/eng/tools/TypeSpecValidation/src/rules/format.ts +++ b/eng/tools/TypeSpecValidation/src/rules/format.ts @@ -9,7 +9,7 @@ export class FormatRule implements Rule { async execute(folder: string): Promise { // Format parent folder to include shared files - let [err, stdOutput, errorOutput] = await runCmd(`npx tsp format ../**/*.tsp`, folder); + let [err, stdOutput, errorOutput] = await runCmd(`npx tsp format "../**/*.tsp"`, folder); // Failing on both err and errorOutput because of known bug in tsp format where it returns 0 on failed formatting // https://github.com/microsoft/typespec/issues/2323 let success = !err && !errorOutput;