From ce7637dd2b51305422acec303d3355393b33ce73 Mon Sep 17 00:00:00 2001 From: Devesh Dama Date: Thu, 27 Jul 2023 05:17:26 +0000 Subject: [PATCH 1/8] address ARM review comments --- .../preview/2023-06-02-preview/managedClusters.json | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json b/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json index 4fd7f3598c27..ff5e902bf52b 100644 --- a/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json +++ b/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json @@ -8183,13 +8183,15 @@ "description": "Holds information on upgrades and compatibility for given major.minor mesh release.", "properties": { "revision": { - "type": "string" + "type": "string", + "description": "The mesh release version." }, "upgrades": { "type": "array", "description": "List of revisions available for upgrade of a specific mesh revision", "items": { - "type": "string" + "type": "string", + "description": "The revisions." } }, "compatibleWith": { @@ -8204,12 +8206,15 @@ }, "CompatibleVersions": { "type": "object", + "description": "List of compatible versions.", "properties": { "name": { - "type": "string" + "type": "string", + "description": "The product name." }, "versions": { "type": "array", + "description": "The product versions.", "items": { "type": "string" } From ff5e9fa9654d80bd060a856545eae61c4fc377c1 Mon Sep 17 00:00:00 2001 From: Devesh Dama Date: Thu, 27 Jul 2023 05:27:07 +0000 Subject: [PATCH 2/8] added a missing description. --- .../aks/preview/2023-06-02-preview/managedClusters.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json b/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json index ff5e902bf52b..72b3bec5548e 100644 --- a/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json +++ b/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json @@ -8216,7 +8216,8 @@ "type": "array", "description": "The product versions.", "items": { - "type": "string" + "type": "string", + "description": "The product version." } } } From 1c898fd0f87cade2a886a0725a3bd8ecaf9f2167 Mon Sep 17 00:00:00 2001 From: deveshdama <87668846+deveshdama@users.noreply.github.com> Date: Thu, 27 Jul 2023 10:45:31 -0700 Subject: [PATCH 3/8] Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com> --- .../aks/preview/2023-06-02-preview/managedClusters.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json b/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json index 72b3bec5548e..bd8bc8f99656 100644 --- a/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json +++ b/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json @@ -8184,7 +8184,7 @@ "properties": { "revision": { "type": "string", - "description": "The mesh release version." + "description": "The revision of the mesh release." }, "upgrades": { "type": "array", From 1ff83326879e28ed9d97ffe43728947c2d94127b Mon Sep 17 00:00:00 2001 From: deveshdama <87668846+deveshdama@users.noreply.github.com> Date: Thu, 27 Jul 2023 10:45:47 -0700 Subject: [PATCH 4/8] Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com> --- .../aks/preview/2023-06-02-preview/managedClusters.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json b/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json index bd8bc8f99656..0f4ed9a8ac43 100644 --- a/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json +++ b/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json @@ -8210,7 +8210,7 @@ "properties": { "name": { "type": "string", - "description": "The product name." + "description": "The product/service name." }, "versions": { "type": "array", From c79a6650609112870add44a2c8d7de10290a26c5 Mon Sep 17 00:00:00 2001 From: deveshdama <87668846+deveshdama@users.noreply.github.com> Date: Thu, 27 Jul 2023 10:45:55 -0700 Subject: [PATCH 5/8] Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com> --- .../aks/preview/2023-06-02-preview/managedClusters.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json b/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json index 0f4ed9a8ac43..7285373bafdd 100644 --- a/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json +++ b/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json @@ -8206,7 +8206,7 @@ }, "CompatibleVersions": { "type": "object", - "description": "List of compatible versions.", + "description": "Version information about a product/service that is compatible with a service mesh revision.", "properties": { "name": { "type": "string", From 74b0160eeeff42cdc806c9d3a7d26227d30ee247 Mon Sep 17 00:00:00 2001 From: deveshdama <87668846+deveshdama@users.noreply.github.com> Date: Thu, 27 Jul 2023 10:46:00 -0700 Subject: [PATCH 6/8] Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com> --- .../aks/preview/2023-06-02-preview/managedClusters.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json b/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json index 7285373bafdd..bf7a79f982b9 100644 --- a/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json +++ b/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json @@ -8214,7 +8214,7 @@ }, "versions": { "type": "array", - "description": "The product versions.", + "description": "Product/service versions compatible with a service mesh add-on revision.", "items": { "type": "string", "description": "The product version." From e32db99028529f222e3341668d2f0918565f3c40 Mon Sep 17 00:00:00 2001 From: deveshdama <87668846+deveshdama@users.noreply.github.com> Date: Thu, 27 Jul 2023 10:46:05 -0700 Subject: [PATCH 7/8] Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com> --- .../aks/preview/2023-06-02-preview/managedClusters.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json b/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json index bf7a79f982b9..cc6f52678304 100644 --- a/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json +++ b/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json @@ -8191,7 +8191,7 @@ "description": "List of revisions available for upgrade of a specific mesh revision", "items": { "type": "string", - "description": "The revisions." + "description": "An upgradeable mesh revision" } }, "compatibleWith": { From 819aeddaa186ea374cd1363a5f5542e062c2e571 Mon Sep 17 00:00:00 2001 From: deveshdama <87668846+deveshdama@users.noreply.github.com> Date: Thu, 27 Jul 2023 10:46:16 -0700 Subject: [PATCH 8/8] Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com> --- .../aks/preview/2023-06-02-preview/managedClusters.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json b/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json index cc6f52678304..a39e026a356e 100644 --- a/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json +++ b/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json @@ -8217,7 +8217,7 @@ "description": "Product/service versions compatible with a service mesh add-on revision.", "items": { "type": "string", - "description": "The product version." + "description": "A compatible product/service version." } } }