From 8b4f5e07b251c0a54c8fa685830b2b6667cca52b Mon Sep 17 00:00:00 2001 From: maulikjoshi Date: Thu, 22 Sep 2022 23:45:21 -0700 Subject: [PATCH 1/5] Fixed LintDiff checks --- .../preview/2022-10-01-preview/mfe.json | 80 +++++++++++++++---- 1 file changed, 64 insertions(+), 16 deletions(-) diff --git a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2022-10-01-preview/mfe.json b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2022-10-01-preview/mfe.json index af86c091f3f3..ebc58eeec2ae 100644 --- a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2022-10-01-preview/mfe.json +++ b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2022-10-01-preview/mfe.json @@ -139,7 +139,10 @@ "$ref": "./examples/Registry/CodeContainer/delete.json" } }, - "x-ms-long-running-operation": true + "x-ms-long-running-operation": true, + "x-ms-long-running-operation-options" : { + "final-state-via" : "location" + } }, "get": { "tags": [ @@ -278,7 +281,10 @@ "$ref": "./examples/Registry/CodeContainer/createOrUpdate.json" } }, - "x-ms-long-running-operation": true + "x-ms-long-running-operation": true, + "x-ms-long-running-operation-options" : { + "final-state-via" : "original-uri" + } } }, "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/registries/{registryName}/codes/{codeName}/versions": { @@ -438,7 +444,10 @@ "$ref": "./examples/Registry/CodeVersion/delete.json" } }, - "x-ms-long-running-operation": true + "x-ms-long-running-operation": true, + "x-ms-long-running-operation-options" : { + "final-state-via" : "location" + } }, "get": { "tags": [ @@ -591,7 +600,10 @@ "$ref": "./examples/Registry/CodeVersion/createOrUpdate.json" } }, - "x-ms-long-running-operation": true + "x-ms-long-running-operation": true, + "x-ms-long-running-operation-options" : { + "final-state-via" : "original-uri" + } } }, "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/registries/{registryName}/components": { @@ -724,7 +736,10 @@ "$ref": "./examples/Registry/ComponentContainer/delete.json" } }, - "x-ms-long-running-operation": true + "x-ms-long-running-operation": true, + "x-ms-long-running-operation-options" : { + "final-state-via" : "location" + } }, "get": { "tags": [ @@ -863,7 +878,10 @@ "$ref": "./examples/Registry/ComponentContainer/createOrUpdate.json" } }, - "x-ms-long-running-operation": true + "x-ms-long-running-operation": true, + "x-ms-long-running-operation-options" : { + "final-state-via" : "original-uri" + } } }, "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/registries/{registryName}/components/{componentName}/versions": { @@ -1023,7 +1041,10 @@ "$ref": "./examples/Registry/ComponentVersion/delete.json" } }, - "x-ms-long-running-operation": true + "x-ms-long-running-operation": true, + "x-ms-long-running-operation-options" : { + "final-state-via" : "location" + } }, "get": { "tags": [ @@ -1176,7 +1197,10 @@ "$ref": "./examples/Registry/ComponentVersion/createOrUpdate.json" } }, - "x-ms-long-running-operation": true + "x-ms-long-running-operation": true, + "x-ms-long-running-operation-options" : { + "final-state-via" : "original-uri" + } } }, "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/registries/{registryName}/environments": { @@ -1336,7 +1360,10 @@ "$ref": "./examples/Registry/EnvironmentContainer/delete.json" } }, - "x-ms-long-running-operation": true + "x-ms-long-running-operation": true, + "x-ms-long-running-operation-options" : { + "final-state-via" : "location" + } }, "get": { "tags": [ @@ -1475,7 +1502,10 @@ "$ref": "./examples/Registry/EnvironmentContainer/createOrUpdate.json" } }, - "x-ms-long-running-operation": true + "x-ms-long-running-operation": true, + "x-ms-long-running-operation-options" : { + "final-state-via" : "original-uri" + } } }, "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/registries/{registryName}/environments/{environmentName}/versions": { @@ -1662,7 +1692,10 @@ "$ref": "./examples/Registry/EnvironmentVersion/delete.json" } }, - "x-ms-long-running-operation": true + "x-ms-long-running-operation": true, + "x-ms-long-running-operation-options" : { + "final-state-via" : "location" + } }, "get": { "tags": [ @@ -1815,7 +1848,10 @@ "$ref": "./examples/Registry/EnvironmentVersion/createOrUpdate.json" } }, - "x-ms-long-running-operation": true + "x-ms-long-running-operation": true, + "x-ms-long-running-operation-options" : { + "final-state-via" : "original-uri" + } } }, "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/registries/{registryName}/models": { @@ -1975,7 +2011,10 @@ "$ref": "./examples/Registry/ModelContainer/delete.json" } }, - "x-ms-long-running-operation": true + "x-ms-long-running-operation": true, + "x-ms-long-running-operation-options" : { + "final-state-via" : "location" + } }, "get": { "tags": [ @@ -2114,7 +2153,10 @@ "$ref": "./examples/Registry/ModelContainer/createOrUpdate.json" } }, - "x-ms-long-running-operation": true + "x-ms-long-running-operation": true, + "x-ms-long-running-operation-options" : { + "final-state-via" : "original-uri" + } } }, "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/registries/{registryName}/models/{modelName}/versions": { @@ -2325,7 +2367,10 @@ "$ref": "./examples/Registry/ModelVersion/delete.json" } }, - "x-ms-long-running-operation": true + "x-ms-long-running-operation": true, + "x-ms-long-running-operation-options" : { + "final-state-via" : "location" + } }, "get": { "tags": [ @@ -2478,7 +2523,10 @@ "$ref": "./examples/Registry/ModelVersion/createOrUpdate.json" } }, - "x-ms-long-running-operation": true + "x-ms-long-running-operation": true, + "x-ms-long-running-operation-options" : { + "final-state-via" : "original-uri" + } } }, "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/batchEndpoints": { From 89f3fc77341904b498e49f6e90ed3dd26eb5695e Mon Sep 17 00:00:00 2001 From: maulikjoshi Date: Fri, 23 Sep 2022 00:02:13 -0700 Subject: [PATCH 2/5] Fixed LintDiff checks --- .../preview/2022-10-01-preview/mfe.json | 76 +++++++++---------- 1 file changed, 38 insertions(+), 38 deletions(-) diff --git a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2022-10-01-preview/mfe.json b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2022-10-01-preview/mfe.json index ebc58eeec2ae..e6bd556dfcac 100644 --- a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2022-10-01-preview/mfe.json +++ b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2022-10-01-preview/mfe.json @@ -140,8 +140,8 @@ } }, "x-ms-long-running-operation": true, - "x-ms-long-running-operation-options" : { - "final-state-via" : "location" + "x-ms-long-running-operation-options": { + "final-state-via": "location" } }, "get": { @@ -282,8 +282,8 @@ } }, "x-ms-long-running-operation": true, - "x-ms-long-running-operation-options" : { - "final-state-via" : "original-uri" + "x-ms-long-running-operation-options": { + "final-state-via": "original-uri" } } }, @@ -445,8 +445,8 @@ } }, "x-ms-long-running-operation": true, - "x-ms-long-running-operation-options" : { - "final-state-via" : "location" + "x-ms-long-running-operation-options": { + "final-state-via": "location" } }, "get": { @@ -601,8 +601,8 @@ } }, "x-ms-long-running-operation": true, - "x-ms-long-running-operation-options" : { - "final-state-via" : "original-uri" + "x-ms-long-running-operation-options": { + "final-state-via": "original-uri" } } }, @@ -737,8 +737,8 @@ } }, "x-ms-long-running-operation": true, - "x-ms-long-running-operation-options" : { - "final-state-via" : "location" + "x-ms-long-running-operation-options": { + "final-state-via": "location" } }, "get": { @@ -879,8 +879,8 @@ } }, "x-ms-long-running-operation": true, - "x-ms-long-running-operation-options" : { - "final-state-via" : "original-uri" + "x-ms-long-running-operation-options": { + "final-state-via": "original-uri" } } }, @@ -1042,8 +1042,8 @@ } }, "x-ms-long-running-operation": true, - "x-ms-long-running-operation-options" : { - "final-state-via" : "location" + "x-ms-long-running-operation-options": { + "final-state-via": "location" } }, "get": { @@ -1198,8 +1198,8 @@ } }, "x-ms-long-running-operation": true, - "x-ms-long-running-operation-options" : { - "final-state-via" : "original-uri" + "x-ms-long-running-operation-options": { + "final-state-via": "original-uri" } } }, @@ -1361,8 +1361,8 @@ } }, "x-ms-long-running-operation": true, - "x-ms-long-running-operation-options" : { - "final-state-via" : "location" + "x-ms-long-running-operation-options": { + "final-state-via": "location" } }, "get": { @@ -1503,8 +1503,8 @@ } }, "x-ms-long-running-operation": true, - "x-ms-long-running-operation-options" : { - "final-state-via" : "original-uri" + "x-ms-long-running-operation-options": { + "final-state-via": "original-uri" } } }, @@ -1693,9 +1693,9 @@ } }, "x-ms-long-running-operation": true, - "x-ms-long-running-operation-options" : { - "final-state-via" : "location" - } + "x-ms-long-running-operation-options": { + "final-state-via": "location" + } }, "get": { "tags": [ @@ -1849,9 +1849,9 @@ } }, "x-ms-long-running-operation": true, - "x-ms-long-running-operation-options" : { - "final-state-via" : "original-uri" - } + "x-ms-long-running-operation-options": { + "final-state-via": "original-uri" + } } }, "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/registries/{registryName}/models": { @@ -2012,9 +2012,9 @@ } }, "x-ms-long-running-operation": true, - "x-ms-long-running-operation-options" : { - "final-state-via" : "location" - } + "x-ms-long-running-operation-options": { + "final-state-via": "location" + } }, "get": { "tags": [ @@ -2154,9 +2154,9 @@ } }, "x-ms-long-running-operation": true, - "x-ms-long-running-operation-options" : { - "final-state-via" : "original-uri" - } + "x-ms-long-running-operation-options": { + "final-state-via": "original-uri" + } } }, "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/registries/{registryName}/models/{modelName}/versions": { @@ -2368,9 +2368,9 @@ } }, "x-ms-long-running-operation": true, - "x-ms-long-running-operation-options" : { - "final-state-via" : "location" - } + "x-ms-long-running-operation-options": { + "final-state-via": "location" + } }, "get": { "tags": [ @@ -2524,9 +2524,9 @@ } }, "x-ms-long-running-operation": true, - "x-ms-long-running-operation-options" : { - "final-state-via" : "original-uri" - } + "x-ms-long-running-operation-options": { + "final-state-via": "original-uri" + } } }, "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/batchEndpoints": { From 4a584ab936b29a4dfae3c8f194165e25a21a8139 Mon Sep 17 00:00:00 2001 From: maulikjoshi Date: Fri, 23 Sep 2022 00:06:04 -0700 Subject: [PATCH 3/5] Fixed LintDiff checks --- .../preview/2022-10-01-preview/registries.json | 9 --------- 1 file changed, 9 deletions(-) diff --git a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2022-10-01-preview/registries.json b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2022-10-01-preview/registries.json index d1f75b6ce252..db47582b4a90 100644 --- a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2022-10-01-preview/registries.json +++ b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2022-10-01-preview/registries.json @@ -386,10 +386,6 @@ "description": "Metadata used by portal/tooling/etc to render different UX experiences for resources of the same type.", "type": "string" }, - "location": { - "description": "The geo-location where the resource lives.", - "type": "string" - }, "properties": { "description": "Additional attributes of the entity.", "$ref": "#/definitions/PartialRegistry" @@ -519,11 +515,6 @@ "x-ms-identifiers": [], "x-nullable": true }, - "location": { - "description": "The location where the registry exists", - "type": "string", - "x-nullable": true - }, "storageAccountDetails": { "description": "List of storage accounts", "type": "array", From 5d347a1bf3846d511a8dd4fe1dae47c72b584c20 Mon Sep 17 00:00:00 2001 From: maulikjoshi Date: Fri, 23 Sep 2022 00:14:02 -0700 Subject: [PATCH 4/5] Fixed LintDiff checks --- .../preview/2022-10-01-preview/registries.json | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2022-10-01-preview/registries.json b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2022-10-01-preview/registries.json index db47582b4a90..433c72dcb385 100644 --- a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2022-10-01-preview/registries.json +++ b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2022-10-01-preview/registries.json @@ -515,6 +515,11 @@ "x-ms-identifiers": [], "x-nullable": true }, + "location": { + "description": "The location where the registry exists", + "type": "string", + "x-nullable": true + }, "storageAccountDetails": { "description": "List of storage accounts", "type": "array", From 5f74a1fcdd40537d3f7780033711e12d4138fb48 Mon Sep 17 00:00:00 2001 From: maulikjoshi Date: Fri, 23 Sep 2022 00:18:45 -0700 Subject: [PATCH 5/5] Updated examples --- .../examples/Registries/update-SystemCreated.json | 1 - .../examples/Registries/update-UserCreated.json | 1 - 2 files changed, 2 deletions(-) diff --git a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2022-10-01-preview/examples/Registries/update-SystemCreated.json b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2022-10-01-preview/examples/Registries/update-SystemCreated.json index 8d8cc03de92f..c40c6d39342f 100644 --- a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2022-10-01-preview/examples/Registries/update-SystemCreated.json +++ b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2022-10-01-preview/examples/Registries/update-SystemCreated.json @@ -7,7 +7,6 @@ "body": { "properties": {}, "tags": {}, - "location": "string", "kind": "string", "identity": { "type": "UserAssigned", diff --git a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2022-10-01-preview/examples/Registries/update-UserCreated.json b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2022-10-01-preview/examples/Registries/update-UserCreated.json index 7f633b02cf29..a4542a98836d 100644 --- a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2022-10-01-preview/examples/Registries/update-UserCreated.json +++ b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2022-10-01-preview/examples/Registries/update-UserCreated.json @@ -7,7 +7,6 @@ "body": { "properties": {}, "tags": {}, - "location": "string", "kind": "string", "identity": { "type": "UserAssigned",