[Network-2017-11-01] Pull latest from current #2039

murilogr · 2017-11-21T23:25:37Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

…alid special characters (Azure#2015) * Add Video Search API Swagger * Video Swagger API: update example response json to remove special invalid special characters

…ant level rp (Azure#1984)

* Add list LTR vaults & policies * Added pageable

* update output folders in readmes * rename with bing in name

* App model for tumbling window trigger * Addressed CR comments * Renamed retry to count in RetryPolicy

…ates (Azure#2008) * Enum fixes * Improve DataDisks documentation * Update NATPool port range documentation

* Initial commit of 2017-12-01 compute.json * Changes for new API version 2017-12-01 compute.json * Add Compute SKU APIs

* Add swagger spec for spell check API * Add Examples to spec * Remove redundant forward slash in path. Specify array from body parameters. * Fix oav errors * Remove x-Bing_Apis-SDK * Change spec to reflect what objects we want to expose in the response. * Fix operationId name to avoid conflict with "SpellCheck" schema. * Add X-BingApis-SDK back. * Remove Unintentional change Packages.json change here was unintentionally added to this review

azuresdkciprbot · 2017-11-21T23:33:14Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

💡 Please review potentially introduced Error(s)/Warning(s): Analysis Report 💡

File: specification/automation/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 77

File: specification/batch/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 1
After the PR: Warning(s): 0 Error(s): 1

File: specification/cognitiveservices/data-plane/EntitySearch/readme.md
Before the PR: Warning(s): 0 Error(s): 2
After the PR: Warning(s): 0 Error(s): 2

File: specification/cognitiveservices/data-plane/SpellCheck/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/cognitiveservices/data-plane/VideoSearch/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 1

File: specification/cognitiveservices/data-plane/WebSearch/readme.md
Before the PR: Warning(s): 0 Error(s): 2
After the PR: Warning(s): 0 Error(s): 2

File: specification/compute/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 36
After the PR: Warning(s): 0 Error(s): 37

File: specification/datafactory/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/operationalinsights/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/resources/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 71
After the PR: Warning(s): 0 Error(s): 71

File: specification/sql/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

sergey-shandar

Since this's just a pull from current.

AutorestCI · 2017-11-22T00:15:10Z

No modification for AutorestCI/azure-sdk-for-node

AutorestCI · 2017-11-22T00:19:20Z

Azure/azure-sdk-for-python#1642

AutorestCI · 2017-11-22T00:24:55Z

Azure/azure-sdk-for-ruby#1143

This reverts commit a0257f9.

* [Network-2017-11-01] Pull latest from current (#2039) * Video Swagger API: update example response json to remove special invalid special characters (#2015) * Add Video Search API Swagger * Video Swagger API: update example response json to remove special invalid special characters * take changes from azure-rest-spec-pr, make Microsoft.Subscription tenant level rp (#1984) * Fix bad merge. (#2022) * Add list apis for sql backup LTR policies & vaults (#2006) * Add list LTR vaults & policies * Added pageable * Change output folder for Search SDKs (#2023) * update output folders in readmes * rename with bing in name * App Model for Tumbling window trigger (#2028) * App model for tumbling window trigger * Addressed CR comments * Renamed retry to count in RetryPolicy * swagger definition for 26 RFI connectors (#2016) * Updated OMS data plane C# namespace & output-folder (#2021) * Update Azure Batch enum to use "values" - also some documentation updates (#2008) * Enum fixes * Improve DataDisks documentation * Update NATPool port range documentation * [Compute] Update Sku APIs (#2034) * Initial commit of 2017-12-01 compute.json * Changes for new API version 2017-12-01 compute.json * Add Compute SKU APIs * Add swagger spec for spell check API (#1997) * Add swagger spec for spell check API * Add Examples to spec * Remove redundant forward slash in path. Specify array from body parameters. * Fix oav errors * Remove x-Bing_Apis-SDK * Change spec to reflect what objects we want to expose in the response. * Fix operationId name to avoid conflict with "SpellCheck" schema. * Add X-BingApis-SDK back. * Remove Unintentional change Packages.json change here was unintentionally added to this review * Add 2017-11-01 folder in microsoft.network (#2019) * Video Swagger API: update example response json to remove special invalid special characters (#2015) * Add Video Search API Swagger * Video Swagger API: update example response json to remove special invalid special characters * take changes from azure-rest-spec-pr, make Microsoft.Subscription tenant level rp (#1984) * Fix bad merge. (#2022) * Add 2017-11-01 folder in microsoft.network * Add Ip Tags into Swagger (#2145) * add iptags for publicip in 2017-11-01 * read me changes for 2017-11-01 * Add Python conf for Network 2017-11-01 * Complete Python conf for 2017-11-01 * Updated LB InboundNatPool API (#2150) * Revert "[Network-2017-11-01] Pull latest from current (#2039)" This reverts commit a0257f9. * Moving to stable folder to account for refactoring changes in dec 2017

baon-ms and others added 11 commits November 16, 2017 11:04

Video Swagger API: update example response json to remove special inv…

61ac6a8

…alid special characters (Azure#2015) * Add Video Search API Swagger * Video Swagger API: update example response json to remove special invalid special characters

take changes from azure-rest-spec-pr, make Microsoft.Subscription ten…

1468e76

…ant level rp (Azure#1984)

Fix bad merge. (Azure#2022)

d2a21a3

Add list apis for sql backup LTR policies & vaults (Azure#2006)

eb48e1d

* Add list LTR vaults & policies * Added pageable

Change output folder for Search SDKs (Azure#2023)

03d2eea

* update output folders in readmes * rename with bing in name

App Model for Tumbling window trigger (Azure#2028)

69fc809

* App model for tumbling window trigger * Addressed CR comments * Renamed retry to count in RetryPolicy

swagger definition for 26 RFI connectors (Azure#2016)

253b363

Updated OMS data plane C# namespace & output-folder (Azure#2021)

76e9d48

Update Azure Batch enum to use "values" - also some documentation upd…

75ff961

…ates (Azure#2008) * Enum fixes * Improve DataDisks documentation * Update NATPool port range documentation

[Compute] Update Sku APIs (Azure#2034)

c1bd31d

* Initial commit of 2017-12-01 compute.json * Changes for new API version 2017-12-01 compute.json * Add Compute SKU APIs

murilogr changed the title ~~Pull latest from current~~ [Network-2017-11-01] Pull latest from current Nov 21, 2017

sergey-shandar approved these changes Nov 21, 2017

View reviewed changes

sergey-shandar merged commit a0257f9 into Azure:Network-2017-11-01 Nov 22, 2017

AutorestCI mentioned this pull request Nov 22, 2017

Automatic PR from RestAPI-PR2039 Azure/azure-sdk-for-python#1642

Closed

AutorestCI mentioned this pull request Nov 22, 2017

Automatic PR from RestAPI-PR2039 Azure/azure-sdk-for-ruby#1143

Closed

chandrasekarsrinivasan added a commit to chandrasekarsrinivasan/azure-rest-api-specs that referenced this pull request Dec 29, 2017

Revert "[Network-2017-11-01] Pull latest from current (Azure#2039)"

3099885

This reverts commit a0257f9.

chandrasekarsrinivasan added a commit to chandrasekarsrinivasan/azure-rest-api-specs that referenced this pull request Dec 29, 2017

Revert "[Network-2017-11-01] Pull latest from current (Azure#2039)"

b9ad0bf

This reverts commit a0257f9.

chandrasekarsrinivasan added a commit to chandrasekarsrinivasan/azure-rest-api-specs that referenced this pull request Jan 2, 2018

Revert "[Network-2017-11-01] Pull latest from current (Azure#2039)"

8dbd301

This reverts commit a0257f9.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Network-2017-11-01] Pull latest from current #2039

[Network-2017-11-01] Pull latest from current #2039

Uh oh!

murilogr commented Nov 21, 2017

Uh oh!

azuresdkciprbot commented Nov 21, 2017

Uh oh!

sergey-shandar left a comment

Uh oh!

AutorestCI commented Nov 22, 2017

Uh oh!

AutorestCI commented Nov 22, 2017

Uh oh!

AutorestCI commented Nov 22, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

[Network-2017-11-01] Pull latest from current #2039

[Network-2017-11-01] Pull latest from current #2039

Uh oh!

Conversation

murilogr commented Nov 21, 2017

PR information

Quality of Swagger

Uh oh!

azuresdkciprbot commented Nov 21, 2017

Uh oh!

sergey-shandar left a comment

Choose a reason for hiding this comment

Uh oh!

AutorestCI commented Nov 22, 2017

Uh oh!

AutorestCI commented Nov 22, 2017

Uh oh!

AutorestCI commented Nov 22, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants