From 65545fa8b2bf9d2a9493000321fd2ead79d5d301 Mon Sep 17 00:00:00 2001 From: Adriana Galer Rotaru Date: Wed, 2 Feb 2022 15:56:38 -0500 Subject: [PATCH 1/4] Adding xms-ids for AppPlatform --- .../stable/2020-07-01/appplatform.json | 143 +++++++++++------- 1 file changed, 86 insertions(+), 57 deletions(-) diff --git a/specification/appplatform/resource-manager/Microsoft.AppPlatform/stable/2020-07-01/appplatform.json b/specification/appplatform/resource-manager/Microsoft.AppPlatform/stable/2020-07-01/appplatform.json index 8033193e6a56..8bdc281c236f 100644 --- a/specification/appplatform/resource-manager/Microsoft.AppPlatform/stable/2020-07-01/appplatform.json +++ b/specification/appplatform/resource-manager/Microsoft.AppPlatform/stable/2020-07-01/appplatform.json @@ -87,14 +87,14 @@ } ], "responses": { - "201": { - "description": "Created. The response describes the new Service and contains a Location header to query the\r\noperation result.", + "200": { + "description": "Success. The response describes the updated Service.", "schema": { "$ref": "#/definitions/ServiceResource" } }, - "200": { - "description": "Success. The response describes the updated Service.", + "201": { + "description": "Created. The response describes the new Service and contains a Location header to query the\r\noperation result.", "schema": { "$ref": "#/definitions/ServiceResource" } @@ -927,15 +927,15 @@ } ], "responses": { - "204": { - "description": "Success. The response indicates the resource doesn't exist." - }, "200": { "description": "Success. The response indicates the resource is deleted." }, "202": { "description": "Accepted. The response indicates the delete operation is performed in the background." }, + "204": { + "description": "Success. The response indicates the resource doesn't exist." + }, "default": { "description": "Error response describing why the operation failed.", "schema": { @@ -1251,14 +1251,14 @@ } ], "responses": { - "204": { - "description": "Success. The response indicates the resource doesn't exist." + "200": { + "description": "Success. The response indicates the resource is deleted." }, "202": { "description": "Accepted. The response indicates the delete operation is performed in the background." }, - "200": { - "description": "Success. The response indicates the resource is deleted." + "204": { + "description": "Success. The response indicates the resource doesn't exist." }, "default": { "description": "Error response describing why the operation failed.", @@ -2073,14 +2073,14 @@ } ], "responses": { - "201": { - "description": "Created. The response describes the new Deployment and contains a Location header to query the\r\noperation result.", + "200": { + "description": "Success. The response describes the updated Deployment.", "schema": { "$ref": "#/definitions/DeploymentResource" } }, - "200": { - "description": "Success. The response describes the updated Deployment.", + "201": { + "description": "Created. The response describes the new Deployment and contains a Location header to query the\r\noperation result.", "schema": { "$ref": "#/definitions/DeploymentResource" } @@ -2138,12 +2138,12 @@ "200": { "description": "Success. The response indicates the resource is deleted." }, - "204": { - "description": "Success. The response indicates the resource doesn't exist." - }, "202": { "description": "Accepted. The response indicates the delete operation is performed in the background." }, + "204": { + "description": "Success. The response indicates the resource doesn't exist." + }, "default": { "description": "Error response describing why the operation failed.", "schema": { @@ -2197,14 +2197,14 @@ } ], "responses": { - "202": { - "description": "Accepted. The response indicates the exiting Deployment is now updating and contains a Location\r\nheader to query the operation result.", + "200": { + "description": "Success. The response describes the updated Deployment.", "schema": { "$ref": "#/definitions/DeploymentResource" } }, - "200": { - "description": "Success. The response describes the updated Deployment.", + "202": { + "description": "Accepted. The response indicates the exiting Deployment is now updating and contains a Location\r\nheader to query the operation result.", "schema": { "$ref": "#/definitions/DeploymentResource" } @@ -2907,7 +2907,10 @@ "type": "array", "items": { "$ref": "#/definitions/ConfigServerSettingsErrorRecord" - } + }, + "x-ms-identifiers": [ + "name" + ] } } }, @@ -3092,7 +3095,10 @@ "readOnly": true, "items": { "$ref": "#/definitions/RequiredTraffic" - } + }, + "x-ms-identifiers": [ + "port" + ] } } }, @@ -3179,7 +3185,10 @@ "type": "array", "items": { "$ref": "#/definitions/GitPatternRepository" - } + }, + "x-ms-identifiers": [ + "name" + ] }, "uri": { "description": "URI of the repository", @@ -3434,8 +3443,8 @@ "sizeInGB": { "format": "int32", "description": "Size of the temporary disk in GB", - "maximum": 5.0, - "minimum": 0.0, + "maximum": 5, + "minimum": 0, "type": "integer" }, "mountPath": { @@ -3452,15 +3461,15 @@ "sizeInGB": { "format": "int32", "description": "Size of the persistent disk in GB", - "maximum": 50.0, - "minimum": 0.0, + "maximum": 50, + "minimum": 0, "type": "integer" }, "usedInGB": { "format": "int32", "description": "Size of the used persistent disk in GB", - "maximum": 50.0, - "minimum": 0.0, + "maximum": 50, + "minimum": 0, "type": "integer", "readOnly": true }, @@ -3882,6 +3891,9 @@ "items": { "$ref": "#/definitions/DeploymentInstance" }, + "x-ms-identifiers": [ + "name" + ], "readOnly": true } } @@ -4054,7 +4066,10 @@ "type": "array", "items": { "$ref": "#/definitions/OperationDetail" - } + }, + "x-ms-identifiers": [ + "name" + ] }, "nextLink": { "description": "URL client should use to fetch the next page (per server side paging).\r\nIt's null for now, added for future use.", @@ -4078,18 +4093,6 @@ "$ref": "#/definitions/OperationDisplay", "description": "Display of the operation" }, - "actionType": { - "description": "Enum. Indicates the action type. \"Internal\" refers to actions that are for internal only APIs.", - "type": "string", - "readOnly": true, - "enum": [ - "Internal" - ], - "x-ms-enum": { - "name": "ActionType", - "modelAsString": true - } - }, "origin": { "description": "Origin of the operation", "type": "string" @@ -4142,7 +4145,10 @@ "type": "array", "items": { "$ref": "#/definitions/LogSpecification" - } + }, + "x-ms-identifiers": [ + "name" + ] }, "metricSpecifications": { "description": "Specifications of the Metrics for Azure Monitoring", @@ -4150,7 +4156,10 @@ "type": "array", "items": { "$ref": "#/definitions/MetricSpecification" - } + }, + "x-ms-identifiers": [ + "name" + ] } } }, @@ -4226,11 +4235,10 @@ "type": "array", "items": { "$ref": "#/definitions/MetricDimension" - } - }, - "sourceMdmNamespace": { - "description": "Name of the MDM namespace. Optional.", - "type": "string" + }, + "x-ms-identifiers": [ + "name" + ] } } }, @@ -4262,7 +4270,11 @@ "type": "array", "items": { "$ref": "#/definitions/ResourceSku" - } + }, + "x-ms-identifiers": [ + "name", + "resourceType" + ] }, "nextLink": { "description": "URL client should use to fetch the next page (per server side paging).\r\nIt's null for now, added for future use.", @@ -4304,7 +4316,10 @@ "type": "array", "items": { "$ref": "#/definitions/ResourceSkuLocationInfo" - } + }, + "x-ms-identifiers": [ + "location" + ] }, "restrictions": { "description": "Gets the restrictions because of which SKU cannot be used. This is\r\nempty if there are no restrictions.", @@ -4312,7 +4327,8 @@ "type": "array", "items": { "$ref": "#/definitions/ResourceSkuRestrictions" - } + }, + "x-ms-identifiers": [] } } }, @@ -4375,7 +4391,10 @@ "type": "array", "items": { "$ref": "#/definitions/ResourceSkuZoneDetails" - } + }, + "x-ms-identifiers": [ + "name" + ] } } }, @@ -4439,7 +4458,10 @@ "type": "array", "items": { "$ref": "#/definitions/ResourceSkuCapabilities" - } + }, + "x-ms-identifiers": [ + "name" + ] } } }, @@ -4508,7 +4530,11 @@ "type": "array", "items": { "$ref": "#/definitions/CloudErrorBody" - } + }, + "x-ms-identifiers": [ + "message", + "target" + ] } }, "x-ms-external": true @@ -4523,6 +4549,9 @@ "items": { "$ref": "#/definitions/SupportedRuntimeVersion" }, + "x-ms-identifiers": [ + "version" + ], "readOnly": true } }, From a36e8b65dd34c0621d7afa7b6b5211396d620d99 Mon Sep 17 00:00:00 2001 From: Adriana Galer Rotaru Date: Wed, 2 Feb 2022 16:00:33 -0500 Subject: [PATCH 2/4] remove stale changes --- .../stable/2020-07-01/appplatform.json | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/specification/appplatform/resource-manager/Microsoft.AppPlatform/stable/2020-07-01/appplatform.json b/specification/appplatform/resource-manager/Microsoft.AppPlatform/stable/2020-07-01/appplatform.json index 8bdc281c236f..7623892b4150 100644 --- a/specification/appplatform/resource-manager/Microsoft.AppPlatform/stable/2020-07-01/appplatform.json +++ b/specification/appplatform/resource-manager/Microsoft.AppPlatform/stable/2020-07-01/appplatform.json @@ -4093,6 +4093,18 @@ "$ref": "#/definitions/OperationDisplay", "description": "Display of the operation" }, + "actionType": { + "description": "Enum. Indicates the action type. \"Internal\" refers to actions that are for internal only APIs.", + "type": "string", + "readOnly": true, + "enum": [ + "Internal" + ], + "x-ms-enum": { + "name": "ActionType", + "modelAsString": true + } + }, "origin": { "description": "Origin of the operation", "type": "string" @@ -4239,6 +4251,10 @@ "x-ms-identifiers": [ "name" ] + }, + "sourceMdmNamespace": { + "description": "Name of the MDM namespace. Optional.", + "type": "string" } } }, From da397708ee63d1c48e4f587a5e3752706f666b97 Mon Sep 17 00:00:00 2001 From: Adriana Galer Rotaru Date: Wed, 9 Feb 2022 17:59:00 +0100 Subject: [PATCH 3/4] remove prettier over fix --- .../stable/2020-07-01/appplatform.json | 68 +++++++++---------- 1 file changed, 34 insertions(+), 34 deletions(-) diff --git a/specification/appplatform/resource-manager/Microsoft.AppPlatform/stable/2020-07-01/appplatform.json b/specification/appplatform/resource-manager/Microsoft.AppPlatform/stable/2020-07-01/appplatform.json index 7623892b4150..a5bd79fd50f1 100644 --- a/specification/appplatform/resource-manager/Microsoft.AppPlatform/stable/2020-07-01/appplatform.json +++ b/specification/appplatform/resource-manager/Microsoft.AppPlatform/stable/2020-07-01/appplatform.json @@ -87,14 +87,14 @@ } ], "responses": { - "200": { - "description": "Success. The response describes the updated Service.", + "201": { + "description": "Created. The response describes the new Service and contains a Location header to query the\r\noperation result.", "schema": { "$ref": "#/definitions/ServiceResource" } }, - "201": { - "description": "Created. The response describes the new Service and contains a Location header to query the\r\noperation result.", + "200": { + "description": "Success. The response describes the updated Service.", "schema": { "$ref": "#/definitions/ServiceResource" } @@ -927,15 +927,15 @@ } ], "responses": { + "204": { + "description": "Success. The response indicates the resource doesn't exist." + }, "200": { "description": "Success. The response indicates the resource is deleted." }, "202": { "description": "Accepted. The response indicates the delete operation is performed in the background." }, - "204": { - "description": "Success. The response indicates the resource doesn't exist." - }, "default": { "description": "Error response describing why the operation failed.", "schema": { @@ -1251,14 +1251,14 @@ } ], "responses": { - "200": { - "description": "Success. The response indicates the resource is deleted." + "204": { + "description": "Success. The response indicates the resource doesn't exist." }, "202": { "description": "Accepted. The response indicates the delete operation is performed in the background." }, - "204": { - "description": "Success. The response indicates the resource doesn't exist." + "200": { + "description": "Success. The response indicates the resource is deleted." }, "default": { "description": "Error response describing why the operation failed.", @@ -2073,14 +2073,14 @@ } ], "responses": { - "200": { - "description": "Success. The response describes the updated Deployment.", + "201": { + "description": "Created. The response describes the new Deployment and contains a Location header to query the\r\noperation result.", "schema": { "$ref": "#/definitions/DeploymentResource" } }, - "201": { - "description": "Created. The response describes the new Deployment and contains a Location header to query the\r\noperation result.", + "200": { + "description": "Success. The response describes the updated Deployment.", "schema": { "$ref": "#/definitions/DeploymentResource" } @@ -2138,12 +2138,12 @@ "200": { "description": "Success. The response indicates the resource is deleted." }, - "202": { - "description": "Accepted. The response indicates the delete operation is performed in the background." - }, "204": { "description": "Success. The response indicates the resource doesn't exist." }, + "202": { + "description": "Accepted. The response indicates the delete operation is performed in the background." + }, "default": { "description": "Error response describing why the operation failed.", "schema": { @@ -2197,14 +2197,14 @@ } ], "responses": { - "200": { - "description": "Success. The response describes the updated Deployment.", + "202": { + "description": "Accepted. The response indicates the exiting Deployment is now updating and contains a Location\r\nheader to query the operation result.", "schema": { "$ref": "#/definitions/DeploymentResource" } }, - "202": { - "description": "Accepted. The response indicates the exiting Deployment is now updating and contains a Location\r\nheader to query the operation result.", + "200": { + "description": "Success. The response describes the updated Deployment.", "schema": { "$ref": "#/definitions/DeploymentResource" } @@ -3443,8 +3443,8 @@ "sizeInGB": { "format": "int32", "description": "Size of the temporary disk in GB", - "maximum": 5, - "minimum": 0, + "maximum": 5.0, + "minimum": 0.0, "type": "integer" }, "mountPath": { @@ -3461,15 +3461,15 @@ "sizeInGB": { "format": "int32", "description": "Size of the persistent disk in GB", - "maximum": 50, - "minimum": 0, + "maximum": 50.0, + "minimum": 0.0, "type": "integer" }, "usedInGB": { "format": "int32", "description": "Size of the used persistent disk in GB", - "maximum": 50, - "minimum": 0, + "maximum": 50.0, + "minimum": 0.0, "type": "integer", "readOnly": true }, @@ -4522,7 +4522,11 @@ "error": { "description": "An error response from the service.", "$ref": "#/definitions/CloudErrorBody" - } + }, + "x-ms-identifiers": [ + "message", + "target" + ] }, "x-ms-external": true }, @@ -4546,11 +4550,7 @@ "type": "array", "items": { "$ref": "#/definitions/CloudErrorBody" - }, - "x-ms-identifiers": [ - "message", - "target" - ] + } } }, "x-ms-external": true From e1363d43931f7ecaf1b33ba094e00811cd83740d Mon Sep 17 00:00:00 2001 From: Adriana Galer Rotaru Date: Wed, 9 Feb 2022 18:18:13 +0100 Subject: [PATCH 4/4] fixing semantic val errors --- .../stable/2020-07-01/appplatform.json | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/specification/appplatform/resource-manager/Microsoft.AppPlatform/stable/2020-07-01/appplatform.json b/specification/appplatform/resource-manager/Microsoft.AppPlatform/stable/2020-07-01/appplatform.json index a5bd79fd50f1..d2a6ef35dcd7 100644 --- a/specification/appplatform/resource-manager/Microsoft.AppPlatform/stable/2020-07-01/appplatform.json +++ b/specification/appplatform/resource-manager/Microsoft.AppPlatform/stable/2020-07-01/appplatform.json @@ -4522,11 +4522,7 @@ "error": { "description": "An error response from the service.", "$ref": "#/definitions/CloudErrorBody" - }, - "x-ms-identifiers": [ - "message", - "target" - ] + } }, "x-ms-external": true }, @@ -4550,7 +4546,11 @@ "type": "array", "items": { "$ref": "#/definitions/CloudErrorBody" - } + }, + "x-ms-identifiers": [ + "message", + "target" + ] } }, "x-ms-external": true