-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Bulk doc update of Speech to text API v3.0 #15172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi, @bexxx Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
1011 - AddingResponseCode |
The new version adds a response code '503'. New: SpeechToText/stable/v3.0/speechtotext.json#L6158:11 |
️⚠️LintDiff: 0 Warnings warning [Detail]
- Linted configuring files (Based on source branch, openapi-validator v1.10.0 , classic-openapi-validator v1.1.8 )
- Linted configuring files (Based on target branch, openapi-validator v1.10.0 , classic-openapi-validator v1.1.8 )
| Rule | Message |
|---|---|
| Consider using x-ms-client-flatten to provide a better end user experience Location: SpeechToText/stable/v3.0/speechtotext.json#L6227 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: SpeechToText/stable/v3.0/speechtotext.json#L6392 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: SpeechToText/stable/v3.0/speechtotext.json#L6534 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: SpeechToText/stable/v3.0/speechtotext.json#L6665 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: SpeechToText/stable/v3.0/speechtotext.json#L6890 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: SpeechToText/stable/v3.0/speechtotext.json#L7061 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: SpeechToText/stable/v3.0/speechtotext.json#L7211 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: SpeechToText/stable/v3.0/speechtotext.json#L7424 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: SpeechToText/stable/v3.0/speechtotext.json#L7591 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: SpeechToText/stable/v3.0/speechtotext.json#L7779 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: SpeechToText/stable/v3.0/speechtotext.json#L7956 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
|:speech_balloon: AutorestCore/Exception|"readme":"cognitiveservices/data-plane/Speech/SpeechToText/readme.md",
"tag":"release_3_0",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"cognitiveservices/data-plane/Speech/SpeechToText/readme.md",
"tag":"release_3_0",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
The following errors/warnings exist before current PR submission:
|:speech_balloon: AutorestCore/Exception|"readme":"cognitiveservices/data-plane/Speech/SpeechToText/readme.md",
"tag":"release_3_0",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
|
Hi @bexxx, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
@jhendrixMSFT the "new" response code was always returned and missed to be documented when the initial v3.0 swagger version was published. So currently we could break customers by sending unexpected response codes and we try fixing this by documenting the one. |
specification/cognitiveservices/data-plane/Speech/SpeechToText/stable/v3.0/speechtotext.json
Show resolved
Hide resolved
|
Hi, @bexxx. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
mkistler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really believe the 503 response is incorrect and should be changed, but I'm willing to listen to a good explanation of why that's not the case.
specification/cognitiveservices/data-plane/Speech/SpeechToText/stable/v3.0/speechtotext.json
Show resolved
Hide resolved
mikekistler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. 👍
|
I just noticed these changes are in a stable swagger. @johanste is this acceptable? Has the service been deployed yet? |
The service is already deployed with this behavior. We just missed to document it in Swagger. |
|
@jhendrixMSFT how can we close on this? |
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Code is already deployed, this is just a doc update.
ASAP
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.