From db587de35159c046dd2d2423bd34abb1a062ecb0 Mon Sep 17 00:00:00 2001 From: David Watrous Date: Tue, 27 Apr 2021 11:40:51 -0400 Subject: [PATCH 1/2] [Batch] Update RemoveNodes description to include max nodes/request --- .../Microsoft.Batch/stable/2020-09-01.12.0/BatchService.json | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/specification/batch/data-plane/Microsoft.Batch/stable/2020-09-01.12.0/BatchService.json b/specification/batch/data-plane/Microsoft.Batch/stable/2020-09-01.12.0/BatchService.json index 2e43550bd55e..4319673b393b 100644 --- a/specification/batch/data-plane/Microsoft.Batch/stable/2020-09-01.12.0/BatchService.json +++ b/specification/batch/data-plane/Microsoft.Batch/stable/2020-09-01.12.0/BatchService.json @@ -7679,7 +7679,7 @@ } }, "summary": "Removes Compute Nodes from the specified Pool.", - "description": "This operation can only run when the allocation state of the Pool is steady. When this operation runs, the allocation state changes from steady to resizing.", + "description": "This operation can only run when the allocation state of the Pool is steady. When this operation runs, the allocation state changes from steady to resizing. Each request may remove up to 100 nodes.", "x-ms-request-id": "request-id", "parameters": [ { @@ -15862,7 +15862,8 @@ "items": { "type": "string" }, - "title": "A list containing the IDs of the Compute Nodes to be removed from the specified Pool." + "title": "A list containing the IDs of the Compute Nodes to be removed from the specified Pool.", + "description": "A maximum of 100 nodes may be removed per request." }, "resizeTimeout": { "type": "string", From 8b748ae05e84ef0467fcab4d6295bf314c60a60e Mon Sep 17 00:00:00 2001 From: David Watrous Date: Wed, 28 Apr 2021 08:55:49 -0400 Subject: [PATCH 2/2] Added suppressions to readme --- specification/batch/data-plane/readme.md | 35 +++++++++++++++++------- 1 file changed, 25 insertions(+), 10 deletions(-) diff --git a/specification/batch/data-plane/readme.md b/specification/batch/data-plane/readme.md index d3d4c786623f..e5301ce18278 100644 --- a/specification/batch/data-plane/readme.md +++ b/specification/batch/data-plane/readme.md @@ -4,10 +4,10 @@ This is the AutoRest configuration file for Batch. - - --- + ## Getting Started + To build the SDK for Batch, simply [Install AutoRest](https://aka.ms/autorest/install) and in this folder, run: > `autorest` @@ -15,13 +15,13 @@ To build the SDK for Batch, simply [Install AutoRest](https://aka.ms/autorest/in To see additional help and options, run: > `autorest --help` + --- ## Configuration - - ### Basic Information + These are the global settings for the Batch API. ``` yaml @@ -113,6 +113,7 @@ input-file: ## Suppression Note that this setting should be removed once [this GitHub bug](https://github.com/Azure/azure-openapi-validator/issues/68) is fixed. + ``` yaml directive: - suppress: R2063 @@ -121,6 +122,7 @@ directive: ``` Note that this setting should be removed once [this GitHub bug](https://github.com/Azure/azure-openapi-validator/issues/69) is fixed. + ``` yaml directive: - suppress: R2064 @@ -216,6 +218,20 @@ directive: reason: The suggested casing of this property is worse than the casing that we're using ``` +``` yaml + - suppress: DefinitionsPropertiesNamesCamelCase + where: $.definitions.ImageInformation.properties.nodeAgentSKUId + from: BatchService.json + reason: Changing the casing of this property would be a breaking change +``` + +``` yaml + - suppress: AvoidNestedProperties + where: $.definitions.NodeFile.properties.properties + from: BatchService.json + reason: Switching to x-ms-client-flatten would be a breaking change to the SDKs +``` + ### Tag: package-2017-05.5.0 These settings apply only when `--tag=package-2017-05.5.0` is specified on the command line. @@ -225,7 +241,6 @@ input-file: - Microsoft.Batch/stable/2017-05-01.5.0/BatchService.json ``` - ### Tag: package-2017-01.4.0 These settings apply only when `--tag=package-2017-01.4.0` is specified on the command line. @@ -262,10 +277,9 @@ input-file: - Microsoft.Batch/stable/2015-12-01.2.2/BatchService.json ``` - --- -# Code Generation +# Code Generation ## Swagger to SDK @@ -311,11 +325,13 @@ python: package-name: azure-batch clear-output-folder: true ``` + ``` yaml $(python) && $(python-mode) == 'update' python: no-namespace-folders: true output-folder: $(python-sdks-folder)/azure-batch/azure/batch ``` + ``` yaml $(python) && $(python-mode) == 'create' python: basic-setup-py: true @@ -357,7 +373,7 @@ java: output-folder: $(azure-libraries-for-java-folder)/azure-batch ``` -## Multi-API/Profile support for AutoRest v3 generators +## Multi-API/Profile support for AutoRest v3 generators AutoRest V3 generators require the use of `--tag=all-api-versions` to select api files. @@ -386,11 +402,10 @@ input-file: ``` -If there are files that should not be in the `all-api-versions` set, +If there are files that should not be in the `all-api-versions` set, uncomment the `exclude-file` section below and add the file paths. ``` yaml $(tag) == 'all-api-versions' #exclude-file: # - $(this-folder)/Microsoft.Example/stable/2010-01-01/somefile.json ``` -