From 1711411c2f2b80fccedc801ab3564350117fda3f Mon Sep 17 00:00:00 2001 From: Jeff Hackshaw Date: Mon, 22 Mar 2021 12:41:13 -0700 Subject: [PATCH 1/2] parameter name correction --- .../2020-08-01-preview/authorization-RoleAssignmentsCalls.json | 3 ++- .../examples/RoleAssignments_ValidateByIdInvalid.json | 2 +- .../examples/RoleAssignments_ValidateInvalid.json | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/authorization-RoleAssignmentsCalls.json b/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/authorization-RoleAssignmentsCalls.json index 7d9930ea99db..1fc556440e34 100644 --- a/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/authorization-RoleAssignmentsCalls.json +++ b/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/authorization-RoleAssignmentsCalls.json @@ -617,7 +617,7 @@ "type": "boolean", "description": "Whether or not validation succeeded" }, - "validationErrorInfo": { + "errorInfo": { "description": "Failed validation result details", "$ref": "#/definitions/ValidationResponseErrorInfo" } @@ -652,6 +652,7 @@ "RoleAssignmentProperties": { "properties": { "scope": { + "readOnly": true, "type": "string", "description": "The role assignment scope." }, diff --git a/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/examples/RoleAssignments_ValidateByIdInvalid.json b/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/examples/RoleAssignments_ValidateByIdInvalid.json index cd0596c2b1fc..386cd69e9c6f 100644 --- a/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/examples/RoleAssignments_ValidateByIdInvalid.json +++ b/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/examples/RoleAssignments_ValidateByIdInvalid.json @@ -14,7 +14,7 @@ "200": { "body": { "isValid": false, - "validationErrorInfo": { + "errorInfo": { "code": "InvalidRoleDefinitionId", "message": "The specified role definition with ID '0b5fe924-9a61-425c-96af-cfe6e287ca2d' does not exist." } diff --git a/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/examples/RoleAssignments_ValidateInvalid.json b/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/examples/RoleAssignments_ValidateInvalid.json index e068332f2dcf..9c1e8c62a95b 100644 --- a/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/examples/RoleAssignments_ValidateInvalid.json +++ b/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/examples/RoleAssignments_ValidateInvalid.json @@ -15,7 +15,7 @@ "200": { "body": { "isValid": false, - "validationErrorInfo": { + "errorInfo": { "code": "InvalidRoleDefinitionId", "message": "The specified role definition with ID '0b5fe924-9a61-425c-96af-cfe6e287ca2d' does not exist." } From 5635062043a120b86bfefd1d5e93b75015f1e033 Mon Sep 17 00:00:00 2001 From: Jeff Hackshaw Date: Thu, 25 Mar 2021 17:08:12 -0700 Subject: [PATCH 2/2] remove custom error --- .../authorization-RoleAssignmentsCalls.json | 37 ------------------- .../examples/RoleAssignments_CreateById.json | 5 --- .../RoleAssignments_CreateForResource.json | 5 --- ...oleAssignments_CreateForResourceGroup.json | 5 --- ...RoleAssignments_CreateForSubscription.json | 5 --- .../RoleAssignments_ValidateByIdInvalid.json | 5 --- .../RoleAssignments_ValidateByIdValid.json | 5 --- .../RoleAssignments_ValidateInvalid.json | 5 --- .../RoleAssignments_ValidateValid.json | 5 --- 9 files changed, 77 deletions(-) diff --git a/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/authorization-RoleAssignmentsCalls.json b/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/authorization-RoleAssignmentsCalls.json index 1fc556440e34..b3782ecaf2e1 100644 --- a/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/authorization-RoleAssignmentsCalls.json +++ b/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/authorization-RoleAssignmentsCalls.json @@ -249,13 +249,6 @@ "$ref": "#/definitions/RoleAssignment" } }, - "500": { - "x-ms-error-response": true, - "description": "Error.", - "schema": { - "$ref": "#/definitions/CustomErrorResponse" - } - }, "default": { "description": "Error response describing why the operation failed.", "schema": { @@ -344,13 +337,6 @@ "$ref": "#/definitions/ValidationResponse" } }, - "500": { - "x-ms-error-response": true, - "description": "Error.", - "schema": { - "$ref": "#/definitions/CustomErrorResponse" - } - }, "default": { "description": "Error response describing why the operation failed.", "schema": { @@ -476,13 +462,6 @@ "$ref": "#/definitions/RoleAssignment" } }, - "500": { - "x-ms-error-response": true, - "description": "Error.", - "schema": { - "$ref": "#/definitions/CustomErrorResponse" - } - }, "default": { "description": "Error response describing why the operation failed.", "schema": { @@ -559,13 +538,6 @@ "$ref": "#/definitions/ValidationResponse" } }, - "500": { - "x-ms-error-response": true, - "description": "Error.", - "schema": { - "$ref": "#/definitions/CustomErrorResponse" - } - }, "default": { "description": "Error response describing why the operation failed.", "schema": { @@ -585,15 +557,6 @@ } }, "definitions": { - "CustomErrorResponse": { - "properties": { - "message": { - "type": "string", - "description": "Description of the error." - } - }, - "description": "Descriptive error response." - }, "ValidationResponseErrorInfo": { "description": "Failed validation result details", "properties": { diff --git a/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/examples/RoleAssignments_CreateById.json b/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/examples/RoleAssignments_CreateById.json index 14c86b512f5d..db70d29fde30 100644 --- a/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/examples/RoleAssignments_CreateById.json +++ b/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/examples/RoleAssignments_CreateById.json @@ -36,11 +36,6 @@ "type": "Microsoft.Authorization/roleAssignments", "name": "b0f43c54-e787-4862-89b1-a653fa9cf747" } - }, - "500": { - "body": { - "message": "Something went wrong." - } } } } diff --git a/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/examples/RoleAssignments_CreateForResource.json b/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/examples/RoleAssignments_CreateForResource.json index 3b3da95c7a67..c14a6a74ad1a 100644 --- a/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/examples/RoleAssignments_CreateForResource.json +++ b/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/examples/RoleAssignments_CreateForResource.json @@ -37,11 +37,6 @@ "type": "Microsoft.Authorization/roleAssignments", "name": "05c5a614-a7d6-4502-b150-c2fb455033ff" } - }, - "500": { - "body": { - "message": "Something went wrong." - } } } } diff --git a/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/examples/RoleAssignments_CreateForResourceGroup.json b/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/examples/RoleAssignments_CreateForResourceGroup.json index 098d4bf9c675..1c73b97300de 100644 --- a/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/examples/RoleAssignments_CreateForResourceGroup.json +++ b/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/examples/RoleAssignments_CreateForResourceGroup.json @@ -37,11 +37,6 @@ "type": "Microsoft.Authorization/roleAssignments", "name": "05c5a614-a7d6-4502-b150-c2fb455033ff" } - }, - "500": { - "body": { - "message": "Something went wrong." - } } } } diff --git a/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/examples/RoleAssignments_CreateForSubscription.json b/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/examples/RoleAssignments_CreateForSubscription.json index 45948d92d258..92e2f9ea5c3d 100644 --- a/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/examples/RoleAssignments_CreateForSubscription.json +++ b/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/examples/RoleAssignments_CreateForSubscription.json @@ -37,11 +37,6 @@ "type": "Microsoft.Authorization/roleAssignments", "name": "05c5a614-a7d6-4502-b150-c2fb455033ff" } - }, - "500": { - "body": { - "message": "Something went wrong." - } } } } diff --git a/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/examples/RoleAssignments_ValidateByIdInvalid.json b/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/examples/RoleAssignments_ValidateByIdInvalid.json index 386cd69e9c6f..ad6912ac1313 100644 --- a/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/examples/RoleAssignments_ValidateByIdInvalid.json +++ b/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/examples/RoleAssignments_ValidateByIdInvalid.json @@ -19,11 +19,6 @@ "message": "The specified role definition with ID '0b5fe924-9a61-425c-96af-cfe6e287ca2d' does not exist." } } - }, - "500": { - "body": { - "message": "Something went wrong." - } } } } diff --git a/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/examples/RoleAssignments_ValidateByIdValid.json b/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/examples/RoleAssignments_ValidateByIdValid.json index 3c873017560a..b76e5990c2c3 100644 --- a/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/examples/RoleAssignments_ValidateByIdValid.json +++ b/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/examples/RoleAssignments_ValidateByIdValid.json @@ -15,11 +15,6 @@ "body": { "isValid": true } - }, - "500": { - "body": { - "message": "Something went wrong." - } } } } diff --git a/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/examples/RoleAssignments_ValidateInvalid.json b/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/examples/RoleAssignments_ValidateInvalid.json index 9c1e8c62a95b..3479106a8dae 100644 --- a/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/examples/RoleAssignments_ValidateInvalid.json +++ b/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/examples/RoleAssignments_ValidateInvalid.json @@ -20,11 +20,6 @@ "message": "The specified role definition with ID '0b5fe924-9a61-425c-96af-cfe6e287ca2d' does not exist." } } - }, - "500": { - "body": { - "message": "Something went wrong." - } } } } diff --git a/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/examples/RoleAssignments_ValidateValid.json b/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/examples/RoleAssignments_ValidateValid.json index f2e66e0b9774..5893676e1f15 100644 --- a/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/examples/RoleAssignments_ValidateValid.json +++ b/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-08-01-preview/examples/RoleAssignments_ValidateValid.json @@ -16,11 +16,6 @@ "body": { "isValid": true } - }, - "500": { - "body": { - "message": "Something went wrong." - } } } }