storageInsights added to version 2020-10-01#13307
Closed
dhaiman wants to merge 2 commits into
Closed
Conversation
|
Hi, @dhaiman Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/operationalinsights/resource-manager/readme.md tag: specification/operationalinsights/resource-manager/readme.md#tag-package-2020-10 |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️[Staging] Cross Version BreakingChange (Base on preview version): 5 Warnings warning [Detail]
- Compared Swaggers (Based on Oad v0.8.6)
️⚠️[Staging] Cross Version BreakingChange (Base on stable version): 5 Warnings warning [Detail]
- Compared Swaggers (Based on Oad v0.8.6)
- original: stable/2020-08-01/StorageInsightConfigs.json <---> new: stable/2020-10-01/StorageInsightConfigs.json
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️[Staging] SDK Track2 Validation: 73 Warnings warning [Detail]
Only 10 items are listed, please refer to log for more details.
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
| "readme":"operationalinsights/resource-manager/readme.md", "tag":"package-2020-10", "details":"The schema 'DataExport' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"operationalinsights/resource-manager/readme.md", "tag":"package-2020-10", "details":"The schema 'DataExportListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"operationalinsights/resource-manager/readme.md", "tag":"package-2020-10", "details":"The schema 'DataExportProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"operationalinsights/resource-manager/readme.md", "tag":"package-2020-10", "details":"The schema 'Destination' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"operationalinsights/resource-manager/readme.md", "tag":"package-2020-10", "details":"The schema 'DestinationMetaData' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"operationalinsights/resource-manager/readme.md", "tag":"package-2020-10", "details":"The schema 'DataSource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"operationalinsights/resource-manager/readme.md", "tag":"package-2020-10", "details":"The schema 'DataSourceFilter' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"operationalinsights/resource-manager/readme.md", "tag":"package-2020-10", "details":"The schema 'DataSourceListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"operationalinsights/resource-manager/readme.md", "tag":"package-2020-10", "details":"The schema 'IntelligencePack' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"operationalinsights/resource-manager/readme.md", "tag":"package-2020-10", "details":"The schema 'LinkedServiceProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
ghost
added
the
customer-reported
|
Thank you for your contribution dhaiman! We will review the pull request and get back to you soon. |
|
Hi, @dhaiman your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @kairu-ms |
openapi-workflow-bot
Bot
added
the
WaitForARMFeedback
openapi-pipeline-app
Bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
|
Hi @dhaiman, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Mar 7, 2021
Contributor
|
While adding new version the recommendation is to copy the existing version into new directory structure for first commit and then push new changes for easy review. Please create new branch with this recommendation for faster review. |
filizt
reviewed
Mar 11, 2021
| } | ||
| }, | ||
| "definitions": { | ||
| "StorageAccount": { |
Contributor
There was a problem hiding this comment.
"StorageAccount": { [](start = 3, length = 20)
It looks like the difference between the last version of StorageInsightConfigs(2020-08-01) and this one is the model of the StorageAccount - is that right?
filizt
reviewed
Mar 11, 2021
| - Microsoft.OperationalInsights/stable/2020-08-01/Schema.json | ||
| - Microsoft.OperationalInsights/stable/2020-08-01/SharedKeys.json | ||
| - Microsoft.OperationalInsights/stable/2020-08-01/WorkspacePurge.json | ||
| - Microsoft.OperationalInsights/stable/2020-10-01/StorageInsightConfigs.json |
Contributor
There was a problem hiding this comment.
Microsoft.OperationalInsights/stable/2020-10-01/StorageInsightConfigs.json [](start = 1, length = 75)
This replacement is possibly will break the customers using 2020-10 SDK version since the StorageAccount model is changed in the new StorageInsightConfigs definition.
|
Hi @dhaiman, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
Contributor
|
Added a breaking change label since this a new feature addition to an existing API version. |
Contributor
Author
|
StorageAccount Config was not in use in version 2020-10-01, it is ok to apply this change in 2020-10-01 SDK |
|
Hi, @dhaiman. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
ghost
closed this
|
Hi, @dhaiman. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.