Azure Data Share: Remove UserAssigned MSI #12900

ahermas · 2021-02-08T18:12:00Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-02-08T18:12:04Z

Hi, @ahermas Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2021-02-08T18:12:05Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

Compared Swaggers (Based on Oad v0.8.6)
- original: stable/2020-09-01/DataShare.json <---> new: stable/2020-09-01/DataShare.json

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

Linted configuring files (Based on source branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- datashare/resource-manager/readme.md tag:package-2020-09-01
Linted configuring files (Based on target branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- datashare/resource-manager/readme.md tag:package-2020-09-01

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️[Staging] SDK Track2 Validation: 3 Warnings warning [Detail]

The following tags are being changed in this PR

datashare/resource-manager/readme.md#package-2020-09-01

Rule	Message
⚠️ PreCheck/SchemaMissingType	"readme":"datashare/resource-manager/readme.md", "tag":"package-2020-09-01", "details":"The schema 'DefaultDto-systemData' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"datashare/resource-manager/readme.md", "tag":"package-2020-09-01", "details":"The schema 'ProxyDto-systemData' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/CheckDuplicateSchemas	"readme":"datashare/resource-manager/readme.md", "tag":"package-2020-09-01", "details":"Checking for duplicate schemas, this could take a (long) while. Run with --verbose for more detail."

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-02-08T18:12:05Z

Swagger Generation Artifacts

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from 0701d53. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-datashare [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Operation DataSetMappingsOperations.list_by_share_subscription has a new signature
info	[Changelog]   - Operation DataSetMappingsOperations.list_by_share_subscription has a new signature
info	[Changelog]   - Operation DataSetsOperations.list_by_share has a new signature
info	[Changelog]   - Operation DataSetsOperations.list_by_share has a new signature
info	[Changelog]   - Operation InvitationsOperations.list_by_share has a new signature
info	[Changelog]   - Operation InvitationsOperations.list_by_share has a new signature
info	[Changelog]   - Operation ShareSubscriptionsOperations.list_synchronization_details has a new signature
info	[Changelog]   - Operation ShareSubscriptionsOperations.list_synchronization_details has a new signature
info	[Changelog]   - Operation ShareSubscriptionsOperations.list_synchronizations has a new signature
info	[Changelog]   - Operation ShareSubscriptionsOperations.list_synchronizations has a new signature
info	[Changelog]   - Operation SharesOperations.list_synchronization_details has a new signature
info	[Changelog]   - Operation SharesOperations.list_synchronization_details has a new signature
info	[Changelog]   - Operation SharesOperations.list_synchronizations has a new signature
info	[Changelog]   - Operation SharesOperations.list_synchronizations has a new signature
info	[Changelog]   - Operation SharesOperations.list_by_account has a new signature
info	[Changelog]   - Operation ShareSubscriptionsOperations.list_by_account has a new signature

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 0701d53. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️datashare/mgmt/2019-11-01/datashare [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/datashare/mgmt/2018-11-01-preview/datashare [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️❌ azure-cli-extensions failed [Detail]

❌Failed [Logs]Release - Generate from 0701d53. Azure CLI Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --az --use=@autorest/az@latest --version=3.0.6271 --clear-output-folder=true --azure-cli-extension-folder=/home/vsts/work/1/s/azure-cli-extensions ../azure-rest-api-specs/specification/datashare/resource-manager/readme.md
cmderr	[Autorest] Failed to install or start extension '@autorest/python' (5.4.0)
cmderr	[Autorest]   Error: Package '@autorest/python' - '5.4.0' failed to install:
cmderr	[Autorest]   Failed to install package 'https://registry.npmjs.org/@autorest/python/-/python-5.4.0.tgz' -- Error: Process Failed.Error: Failed to install package 'https://registry.npmjs.org/@autorest/python/-/python-5.4.0.tgz' -- Error: Process Failed.
cmderr	[Autorest]     at install (/node_modules/@azure-tools/extension/dist/main.js:367:15)
cmderr	[Autorest]     at processTicksAndRejections (internal/process/task_queues.js:97:5)
cmderr	[Autorest]     at async ExtensionManager.installPackage (/node_modules/@azure-tools/extension/dist/main.js:571:13)
cmderr	[Autorest]     at async resolveExtensions (/home/vsts/.autorest/@[email protected]/node_modules/@autorest/core/dist/lib/configuration.js:926:55)
cmderr	[Autorest]     at async Configuration.CreateView (/home/vsts/.autorest/@[email protected]/node_modules/@autorest/core/dist/lib/configuration.js:967:9)
cmderr	[Autorest]     at async AutoRest.RegenerateView (/home/vsts/.autorest/@[email protected]/node_modules/@autorest/core/dist/lib/autorest-core.js:66:29)
cmderr	[Autorest]     at async currentMain (/home/vsts/.autorest/@[email protected]/node_modules/@autorest/core/dist/app.js:311:21)
cmderr	[Autorest]     at async mainImpl (/home/vsts/.autorest/@[email protected]/node_modules/@autorest/core/dist/app.js:510:20)
cmderr	[Autorest]     at async main (/home/vsts/.autorest/@[email protected]/node_modules/@autorest/core/dist/app.js:537:20)
error	Script return with result [failed] code [1] signal [null] cwd [azure-cli-extensions]: autorest
warn	Skip package processing as generation is failed

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 0701d53. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/datashare/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.DataShare [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.DataShare.1.0.1.nupkg
- Microsoft.Azure.Management.DataShare.1.0.1.snupkg

️🔄[Staging] ApiDocPreview inProgress [Detail]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-02-08T18:12:17Z

In the Window Period to fix mismatches between swagger and service, when PR is labelled with “FixS360”, breaking change can be approved by PR assignee; the Azure Breaking Change Board is no longer required to approve the PR. Please ensure to clarify what s360 action items to be solved, and @ mention PR assignee for awareness. Please check this wiki [Window to Fix Broken]( Window to Fix Broken - Overview (azure.com)) for more details.

ahermas · 2021-02-08T18:15:22Z

This PR removes the "UserAssigned" item under "Identity" that was added last week for 2020-09-01.
The addition of "UserAssigned" was done by mistake.

ahermas · 2021-02-09T19:15:27Z

@markcowl Hi Mark, I'm wondering if you or someone else from the reviewers is taking a look at this PR?
Thanks in advance!

Remove UserAssigned MSI

ec00869

openapi-assignment-bot bot assigned markcowl Feb 8, 2021

openapi-workflow-bot bot added the FixS360 label Feb 8, 2021

ahermas changed the title ~~Remove UserAssigned MSI~~ Azure Data Share: Remove UserAssigned MSI Feb 8, 2021

This was referenced Feb 8, 2021

[AutoPR datashare] Remove UserAssigned MSI AzureSDKAutomation/azure-cli-extensions#628

Draft

[AutoPR azure-mgmt-datashare] Remove UserAssigned MSI AzureSDKAutomation/azure-sdk-for-python#4153

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Python label Feb 8, 2021

openapi-sdkautomation bot mentioned this pull request Feb 8, 2021

[AutoPR Microsoft.Azure.Management.DataShare] Remove UserAssigned MSI AzureSDKAutomation/azure-sdk-for-net#3163

Closed

markcowl approved these changes Feb 10, 2021

View reviewed changes

markcowl added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label Feb 10, 2021

markcowl merged commit 0701d53 into Azure:master Feb 10, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Azure Data Share: Remove UserAssigned MSI #12900

Azure Data Share: Remove UserAssigned MSI #12900

Uh oh!

ahermas commented Feb 8, 2021 •

edited

Loading

Uh oh!

openapi-workflow-bot bot commented Feb 8, 2021

Uh oh!

openapi-pipeline-app bot commented Feb 8, 2021 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Feb 8, 2021 •

edited

Loading

Uh oh!

openapi-workflow-bot bot commented Feb 8, 2021

Uh oh!

ahermas commented Feb 8, 2021

Uh oh!

ahermas commented Feb 9, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Azure Data Share: Remove UserAssigned MSI #12900

Azure Data Share: Remove UserAssigned MSI #12900

Uh oh!

Conversation

ahermas commented Feb 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

Uh oh!

openapi-workflow-bot bot commented Feb 8, 2021

Uh oh!

openapi-pipeline-app bot commented Feb 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app bot commented Feb 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Uh oh!

openapi-workflow-bot bot commented Feb 8, 2021

Uh oh!

ahermas commented Feb 8, 2021

Uh oh!

ahermas commented Feb 9, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ahermas commented Feb 8, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 8, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 8, 2021 •

edited

Loading