-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Devices new api #11368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Devices new api #11368
Conversation
Merge upstream to fork
Merge upstream to fork
# Conflicts: # specification/security/resource-manager/readme.md
…vices. 2. Added new properties to the security device resource
2. added filter of Managed type to security devices
Merge main master branch into MichalHel fork
# Conflicts: # specification/security/resource-manager/Microsoft.Security/preview/2020-08-06-preview/devices.json # specification/security/resource-manager/Microsoft.Security/preview/2020-08-06-preview/examples/Devices/GetDevice.json # specification/security/resource-manager/Microsoft.Security/preview/2020-08-06-preview/examples/Devices/GetDevicesListForHub.json # specification/security/resource-manager/Microsoft.Security/preview/2020-08-06-preview/examples/Devices/GetDevicesListForSubscription.json
[Staging] Swagger Validation Report
❌ |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Please notice the changes are in a Preview version (This is a new API that was not deployed yet) |
azure-resource-manager-schemas - Release
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-sdk-for-go - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js - Release
|
azure-sdk-for-java - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net - Release
|
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
|
In this PR there are breaking changes in the SWAGGER but this is a Preview version and it is a new one, also there are no customers using it yet. |
majastrz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that there are no users using the API (checked in ARM logs), this isn't a breaking change. Signed off from ARM side.
|
I would like to merge this PR, thanks |
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
* Added new API for devices in IoT Security * Fixed validation errors * updated security readme * changed operation id in devices api * 1. Added parameter to the query section in the URI of the security devices. 2. Added new properties to the security device resource * 1. added new properties to security devices. 2. added filter of Managed type to security devices * changed naming of parameter in security devices * Changed properties in security devices
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
[V ] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
[V ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.