Skip to content

Conversation

@MichalHel
Copy link
Contributor

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • [V ] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • [V ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

MichalHel and others added 13 commits September 22, 2020 18:49
Merge upstream to fork
Merge upstream to fork
# Conflicts:
#	specification/security/resource-manager/readme.md
…vices.

2. Added new properties to the security device resource
2. added filter of Managed type to security devices
Merge main master branch into MichalHel fork
# Conflicts:
#	specification/security/resource-manager/Microsoft.Security/preview/2020-08-06-preview/devices.json
#	specification/security/resource-manager/Microsoft.Security/preview/2020-08-06-preview/examples/Devices/GetDevice.json
#	specification/security/resource-manager/Microsoft.Security/preview/2020-08-06-preview/examples/Devices/GetDevicesListForHub.json
#	specification/security/resource-manager/Microsoft.Security/preview/2020-08-06-preview/examples/Devices/GetDevicesListForSubscription.json
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 25, 2020

[Staging] Swagger Validation Report

BreakingChange: 6 Errors, 0 Warnings [Detail] [Expand]
Rule Message
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'sensorName' renamed or removed?
New: Microsoft.Security/preview/2020-08-06-preview/devices.json#L255:7
Old: Microsoft.Security/preview/2020-08-06-preview/devices.json#L255:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'siteName' renamed or removed?
New: Microsoft.Security/preview/2020-08-06-preview/devices.json#L255:7
Old: Microsoft.Security/preview/2020-08-06-preview/devices.json#L255:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'zoneName' renamed or removed?
New: Microsoft.Security/preview/2020-08-06-preview/devices.json#L255:7
Old: Microsoft.Security/preview/2020-08-06-preview/devices.json#L255:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'sensorName' renamed or removed?
New: Microsoft.Security/preview/2020-08-06-preview/devices.json#L255:7
Old: Microsoft.Security/preview/2020-08-06-preview/devices.json#L255:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'siteName' renamed or removed?
New: Microsoft.Security/preview/2020-08-06-preview/devices.json#L255:7
Old: Microsoft.Security/preview/2020-08-06-preview/devices.json#L255:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'zoneName' renamed or removed?
New: Microsoft.Security/preview/2020-08-06-preview/devices.json#L255:7
Old: Microsoft.Security/preview/2020-08-06-preview/devices.json#L255:7
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
️✔️ModelValidation [Detail]
 Validation passes for ModelValidation. 
️✔️SemanticValidation [Detail]
 Validation passes for SemanticValidation. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MichalHel
Copy link
Contributor Author

Please notice the changes are in a Preview version (This is a new API that was not deployed yet)

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 25, 2020

azure-resource-manager-schemas - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 0509037 with merge commit 7196231. Schema Automation 13.0.17.20200918.2
    [security][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
    [security][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
    [security][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
    • [after_scripts|node] PostProcessor finished successfully.
      [after_scripts|node]   5783 passing (49s)
      [after_scripts|node]   31 failing
      AzureResourceSchema has no registered package commands.
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 29 Oct 2020 06:46:55 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0481:4FB7:EF14F:2CB1AB:5F9A655F","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 25, 2020

    azure-sdk-for-python - Release

    - Breaking Change detected in SDK

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 0509037 with merge commit 7196231. SDK Automation 13.0.17.20200918.2
    • ⚠️azure-mgmt-security [View full logs]  [Release SDK Changes] Breaking Change Detected
      [build_conf] INFO:packaging_tools:Building template azure-mgmt-security
      [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
      [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
      [build_conf] INFO:packaging_tools:Template done azure-mgmt-security
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [build_package] warning: no files found matching '*.py' under directory 'tests'
      [build_package] warning: no files found matching '*.yaml' under directory 'tests'
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [build_package] warning: no files found matching '*.py' under directory 'tests'
      [build_package] warning: no files found matching '*.yaml' under directory 'tests'
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 29 Oct 2020 06:38:55 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0402:6BB7:1342940:1FA1505:5F9A637F","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
      [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
      [ChangeLog] Size of delta 6.558% size of original (original: 188787 chars, delta: 12380 chars)
      [ChangeLog] **Features**
      [ChangeLog] 
      [ChangeLog]   - Model Device has a new parameter sensors
      [ChangeLog]   - Model Device has a new parameter site
      [ChangeLog]   - Added operation group SqlVulnerabilityAssessmentBaselineRulesOperations
      [ChangeLog]   - Added operation group SqlVulnerabilityAssessmentScanResultsOperations
      [ChangeLog]   - Added operation group SqlVulnerabilityAssessmentScansOperations
      [ChangeLog] 
      [ChangeLog] **Breaking changes**
      [ChangeLog] 
      [ChangeLog]   - Model Device no longer has parameter site_name
      [ChangeLog]   - Model Device no longer has parameter sensor_name
      [ChangeLog]   - Model Device no longer has parameter zone_name

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 25, 2020

    azure-sdk-for-go - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from 0509037 with merge commit 7196231. SDK Automation 13.0.17.20200918.2
    • ️✔️preview/security/mgmt/v1.0 [View full logs]  [Release SDK Changes]
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 29 Oct 2020 06:44:33 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0404:79AC:1251DFB:1F445D6:5F9A64D0","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
    • ️✔️preview/security/mgmt/v2.0 [View full logs]  [Release SDK Changes]
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 29 Oct 2020 06:44:45 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0404:4BC1:97E193:156434B:5F9A64DD","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
    • ️✔️preview/security/mgmt/v3.0 [View full logs]  [Release SDK Changes]
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 29 Oct 2020 06:44:59 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0402:6B5C:264C1B:6DCBF0:5F9A64EB","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 25, 2020

    Trenton Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 25, 2020

    azure-sdk-for-js - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from 0509037 with merge commit 7196231. SDK Automation 13.0.17.20200918.2
    • ️✔️@azure/arm-security [View full logs]  [Release SDK Changes]
      Only show 100 items here, please refer to log for details.
      [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
      [npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
      [npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
      [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
      [npmPack] loaded rollup.config.js with warnings
      [npmPack] (!) Unused external imports
      [npmPack] default imported from external module 'rollup' but never used
      [npmPack] 
      [npmPack] ./esm/securityCenter.js → ./dist/arm-security.js...
      [npmPack] created ./dist/arm-security.js in 1.4s
      [npmPack] npm notice 
      [npmPack] npm notice package: @azure/[email protected]
      [npmPack] npm notice === Tarball Contents === 
      [npmPack] npm notice 4.7kB   esm/operations/adaptiveApplicationControls.js                          
      [npmPack] npm notice 552B    esm/models/adaptiveApplicationControlsMappers.js                       
      [npmPack] npm notice 7.9kB   esm/operations/adaptiveNetworkHardenings.js                            
      [npmPack] npm notice 3.4kB   esm/models/adaptiveNetworkHardeningsMappers.js                         
      [npmPack] npm notice 2.9kB   esm/operations/advancedThreatProtection.js                             
      [npmPack] npm notice 3.3kB   esm/models/advancedThreatProtectionMappers.js                          
      [npmPack] npm notice 15.3kB  esm/operations/alerts.js                                               
      [npmPack] npm notice 3.3kB   esm/models/alertsMappers.js                                            
      [npmPack] npm notice 5.5kB   esm/operations/alertsSuppressionRules.js                               
      [npmPack] npm notice 3.3kB   esm/models/alertsSuppressionRulesMappers.js                            
      [npmPack] npm notice 5.1kB   esm/operations/allowedConnections.js                                   
      [npmPack] npm notice 439B    esm/models/allowedConnectionsMappers.js                                
      [npmPack] npm notice 906.5kB dist/arm-security.js                                                   
      [npmPack] npm notice 358.2kB dist/arm-security.min.js                                               
      [npmPack] npm notice 5.2kB   esm/operations/assessments.js                                          
      [npmPack] npm notice 3.3kB   esm/models/assessmentsMappers.js                                       
      [npmPack] npm notice 7.8kB   esm/operations/assessmentsMetadata.js                                  
      [npmPack] npm notice 3.3kB   esm/models/assessmentsMetadataMappers.js                               
      [npmPack] npm notice 8.4kB   esm/operations/automations.js                                          
      [npmPack] npm notice 590B    esm/models/automationsMappers.js                                       
      [npmPack] npm notice 4.4kB   esm/operations/autoProvisioningSettings.js                             
      [npmPack] npm notice 3.3kB   esm/models/autoProvisioningSettingsMappers.js                          
      [npmPack] npm notice 3.3kB   esm/operations/complianceResults.js                                    
      [npmPack] npm notice 3.3kB   esm/models/complianceResultsMappers.js                                 
      [npmPack] npm notice 3.1kB   esm/operations/compliances.js                                          
      [npmPack] npm notice 3.3kB   esm/models/compliancesMappers.js                                       
      [npmPack] npm notice 5.0kB   esm/operations/connectors.js                                           
      [npmPack] npm notice 3.3kB   esm/models/connectorsMappers.js                                        
      [npmPack] npm notice 1.7kB   esm/operations/deviceOperations.js                                     
      [npmPack] npm notice 3.3kB   esm/models/deviceOperationsMappers.js                                  
      [npmPack] npm notice 5.6kB   esm/operations/deviceSecurityGroups.js                                 
      [npmPack] npm notice 3.3kB   esm/models/deviceSecurityGroupsMappers.js                              
      [npmPack] npm notice 2.5kB   esm/operations/devicesForHub.js                                        
      [npmPack] npm notice 3.3kB   esm/models/devicesForHubMappers.js                                     
      [npmPack] npm notice 2.6kB   esm/operations/devicesForSubscription.js                               
      [npmPack] npm notice 3.3kB   esm/models/devicesForSubscriptionMappers.js                            
      [npmPack] npm notice 5.3kB   esm/operations/discoveredSecuritySolutions.js                          
      [npmPack] npm notice 416B    esm/models/discoveredSecuritySolutionsMappers.js                       
      [npmPack] npm notice 5.3kB   esm/operations/externalSecuritySolutions.js                            
      [npmPack] npm notice 622B    esm/models/externalSecuritySolutionsMappers.js                         
      [npmPack] npm notice 263B    esm/models/index.js                                                    
      [npmPack] npm notice 2.4kB   esm/operations/index.js                                                
      [npmPack] npm notice 4.9kB   esm/operations/informationProtectionPolicies.js                        
      [npmPack] npm notice 3.3kB   esm/models/informationProtectionPoliciesMappers.js                     
      [npmPack] npm notice 4.0kB   esm/operations/iotAlerts.js                                            
      [npmPack] npm notice 362B    esm/models/iotAlertsMappers.js                                         
      [npmPack] npm notice 2.9kB   esm/operations/iotAlertTypes.js                                        
      [npmPack] npm notice 3.3kB   esm/models/iotAlertTypesMappers.js                                     
      [npmPack] npm notice 5.1kB   esm/operations/iotDefenderSettings.js                                  
      [npmPack] npm notice 3.6kB   esm/models/iotDefenderSettingsMappers.js                               
      [npmPack] npm notice 4.0kB   esm/operations/iotRecommendations.js                                   
      [npmPack] npm notice 3.3kB   esm/models/iotRecommendationsMappers.js                                
      [npmPack] npm notice 3.1kB   esm/operations/iotRecommendationTypes.js                               
      [npmPack] npm notice 3.3kB   esm/models/iotRecommendationTypesMappers.js                            
      [npmPack] npm notice 9.0kB   esm/operations/iotSecuritySolution.js                                  
      [npmPack] npm notice 3.0kB   esm/operations/iotSecuritySolutionAnalytics.js                         
      [npmPack] npm notice 3.3kB   esm/models/iotSecuritySolutionAnalyticsMappers.js                      
      [npmPack] npm notice 516B    esm/models/iotSecuritySolutionMappers.js                               
      [npmPack] npm notice 5.3kB   esm/operations/iotSecuritySolutionsAnalyticsAggregatedAlert.js         
      [npmPack] npm notice 489B    esm/models/iotSecuritySolutionsAnalyticsAggregatedAlertMappers.js      
      [npmPack] npm notice 4.3kB   esm/operations/iotSecuritySolutionsAnalyticsRecommendation.js          
      [npmPack] npm notice 450B    esm/models/iotSecuritySolutionsAnalyticsRecommendationMappers.js       
      [npmPack] npm notice 5.1kB   esm/operations/iotSensors.js                                           
      [npmPack] npm notice 3.3kB   esm/models/iotSensorsMappers.js                                        
      [npmPack] npm notice 12.8kB  esm/operations/jitNetworkAccessPolicies.js                             
      [npmPack] npm notice 685B    esm/models/jitNetworkAccessPoliciesMappers.js                          
      [npmPack] npm notice 3.0kB   esm/operations/locations.js                                            
      [npmPack] npm notice 3.3kB   esm/models/locationsMappers.js                                         
      [npmPack] npm notice 255.8kB esm/models/mappers.js                                                  
      [npmPack] npm notice 5.4kB   esm/operations/onPremiseIotSensors.js                                  
      [npmPack] npm notice 3.3kB   esm/models/onPremiseIotSensorsMappers.js                               
      [npmPack] npm notice 2.2kB   esm/operations/operations.js                                           
      [npmPack] npm notice 383B    esm/models/operationsMappers.js                                        
      [npmPack] npm notice 19.5kB  esm/models/parameters.js                                               
      [npmPack] npm notice 3.3kB   esm/operations/pricings.js                                             
      [npmPack] npm notice 3.3kB   esm/models/pricingsMappers.js                                          
      [npmPack] npm notice 4.5kB   esm/operations/regulatoryComplianceAssessments.js                      
      [npmPack] npm notice 3.3kB   esm/models/regulatoryComplianceAssessmentsMappers.js                   
      [npmPack] npm notice 4.0kB   esm/operations/regulatoryComplianceControls.js                         
      [npmPack] npm notice 3.3kB   esm/models/regulatoryComplianceControlsMappers.js                      
      [npmPack] npm notice 3.6kB   esm/operations/regulatoryComplianceStandards.js                        
      [npmPack] npm notice 3.3kB   esm/models/regulatoryComplianceStandardsMappers.js                     
      [npmPack] npm notice 894B    rollup.config.js                                                       
      [npmPack] npm notice 4.1kB   esm/operations/secureScoreControlDefinitions.js                        
      [npmPack] npm notice 3.3kB   esm/models/secureScoreControlDefinitionsMappers.js                     
      [npmPack] npm notice 4.2kB   esm/operations/secureScoreControls.js                                  
      [npmPack] npm notice 3.3kB   esm/models/secureScoreControlsMappers.js                               

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 25, 2020

    azure-sdk-for-java - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 25, 2020

    Azure CLI Extension Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 25, 2020

    azure-sdk-for-net - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from 0509037 with merge commit 7196231. SDK Automation 13.0.17.20200918.2
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.SecurityCenter [View full logs]  [Release SDK Changes]
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 29 Oct 2020 06:42:27 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0480:136D9:181D9C8:1B2A238:5F9A6453","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

    @zhenglaizhang
    Copy link
    Contributor

    /azp run unifiedPipeline

    @azure-pipelines
    Copy link

    No pipelines are associated with this pull request.

    @MichalHel
    Copy link
    Contributor Author

    In this PR there are breaking changes in the SWAGGER but this is a Preview version and it is a new one, also there are no customers using it yet.

    @majastrz majastrz added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Oct 28, 2020
    Copy link
    Member

    @majastrz majastrz left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Given that there are no users using the API (checked in ARM logs), this isn't a breaking change. Signed off from ARM side.

    @MichalHel
    Copy link
    Contributor Author

    I would like to merge this PR, thanks

    @PhoenixHe-NV PhoenixHe-NV added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Oct 29, 2020
    @PhoenixHe-NV PhoenixHe-NV merged commit 7196231 into Azure:master Oct 29, 2020
    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 29, 2020

    azure-sdk-for-python-track2 - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    giromm2ms pushed a commit to giromm2ms/azure-rest-api-specs that referenced this pull request Dec 20, 2020
    * Added new API for devices in IoT Security
    
    * Fixed validation errors
    
    * updated security readme
    
    * changed operation id in devices api
    
    * 1. Added parameter to the query section in the URI of the security devices.
    2. Added new properties to the security device resource
    
    * 1. added new properties to security devices.
    2. added filter of Managed type to security devices
    
    * changed naming of parameter in security devices
    
    * Changed properties in security devices
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Python

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    4 participants