PlatformFaultDomain for VmProfile #11055
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grizzlytheodore
requested review from
MS-syh2qs,
Sandido,
dkulkarni-ms,
haagha,
hyonholee and
madewithsmiles
as code owners
[Staging] Swagger Validation Report
️✔️ |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
added 'DoNotMerge' label to follow new API version PR process for Cplat |
grizzlytheodore
added
the
DoNotMerge
azure-sdk-for-net
|
azure-sdk-for-js
|
azure-sdk-for-python
- Breaking Change detected in SDK
|
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go
|
azure-sdk-for-python-track2
- Breaking Change detected in SDK
|
Trenton Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java
|
azure-resource-manager-schemas
|
grizzlytheodore
changed the title
This was referenced Oct 6, 2020
markcowl
requested changes
Oct 6, 2020
| "$ref": "#/definitions/SubResource", | ||
| "description": "Specifies information about the proximity placement group that the virtual machine should be assigned to. <br><br>Minimum api-version: 2018-04-01." | ||
| }, | ||
| "platformFaultDomain": { |
Member
There was a problem hiding this comment.
Can we add this to existing examples?
Contributor
Author
There was a problem hiding this comment.
Member
|
@grizzlytheodore You will need to fix the LintDiff error above (see https://aka.ms/ci-fix) when this is ready to merge |
markcowl
added
the
Reviewed-ChangesRequested
grizzlytheodore
changed the title
grizzlytheodore
changed the title
|
Azure Pipelines successfully started running 1 pipeline(s). |
markcowl
requested changes
Oct 7, 2020
specification/compute/resource-manager/Microsoft.Compute/stable/2020-12-01/runCommands.json
Outdated
Show resolved
Hide resolved
markcowl
added
WaitForARMFeedback
|
Azure Pipelines successfully started running 1 pipeline(s). |
pilor
added
ARMSignedOff
pilor
approved these changes
Oct 22, 2020
Contributor
|
Based on private chat; Abandoning this with new PR #11409 |
Contributor
|
Closing as per above comment. New PR 11409. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from API owner: @shpa-microsoft
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.