From a039d08f3fe0c5d873f0076f94e2a71127b52c40 Mon Sep 17 00:00:00 2001 From: vipeketi Date: Tue, 6 Oct 2020 14:58:43 +0530 Subject: [PATCH 1/7] source filter for Download API --- .../data-plane/QnAMaker/stable/v4.0/QnAMaker.json | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/specification/cognitiveservices/data-plane/QnAMaker/stable/v4.0/QnAMaker.json b/specification/cognitiveservices/data-plane/QnAMaker/stable/v4.0/QnAMaker.json index 2afdea67435e..2945d824ac03 100644 --- a/specification/cognitiveservices/data-plane/QnAMaker/stable/v4.0/QnAMaker.json +++ b/specification/cognitiveservices/data-plane/QnAMaker/stable/v4.0/QnAMaker.json @@ -564,6 +564,13 @@ }, { "$ref": "#/parameters/Environment" + }, + { + "name": "source", + "in": "query", + "description": "The source property filter to apply. Sample value: Editorial.", + "required": false, + "type": "string" } ], "consumes": [ From 2a63f17e8c13eb17231106a495310aa60971625d Mon Sep 17 00:00:00 2001 From: vipeketi Date: Tue, 6 Oct 2020 16:07:05 +0530 Subject: [PATCH 2/7] Adding as reference --- .../QnAMaker/stable/v4.0/QnAMaker.json | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/specification/cognitiveservices/data-plane/QnAMaker/stable/v4.0/QnAMaker.json b/specification/cognitiveservices/data-plane/QnAMaker/stable/v4.0/QnAMaker.json index 2945d824ac03..9db3a6607e52 100644 --- a/specification/cognitiveservices/data-plane/QnAMaker/stable/v4.0/QnAMaker.json +++ b/specification/cognitiveservices/data-plane/QnAMaker/stable/v4.0/QnAMaker.json @@ -566,11 +566,7 @@ "$ref": "#/parameters/Environment" }, { - "name": "source", - "in": "query", - "description": "The source property filter to apply. Sample value: Editorial.", - "required": false, - "type": "string" + "$ref": "#/parameters/source" } ], "consumes": [ @@ -1422,6 +1418,15 @@ "description": "Knowledgebase id.", "x-ms-parameter-location": "method" }, + "source": { + "type": "string", + "name": "source", + "in": "query", + "required": false, + "x-nullable": false, + "description": "The source property filter to apply. Sample value: Editorial.", + "x-ms-parameter-location": "method" + }, "OperationId": { "type": "string", "name": "operationId", @@ -1472,4 +1477,4 @@ "x-ms-parameter-location": "method" } } -} + } From 1fd3986ce6ec61c42a47a562d57733185665f187 Mon Sep 17 00:00:00 2001 From: vipeketi Date: Tue, 6 Oct 2020 16:14:45 +0530 Subject: [PATCH 3/7] prettier --- .../data-plane/QnAMaker/stable/v4.0/QnAMaker.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/cognitiveservices/data-plane/QnAMaker/stable/v4.0/QnAMaker.json b/specification/cognitiveservices/data-plane/QnAMaker/stable/v4.0/QnAMaker.json index 9db3a6607e52..97200377d315 100644 --- a/specification/cognitiveservices/data-plane/QnAMaker/stable/v4.0/QnAMaker.json +++ b/specification/cognitiveservices/data-plane/QnAMaker/stable/v4.0/QnAMaker.json @@ -1477,4 +1477,4 @@ "x-ms-parameter-location": "method" } } - } +} From e97c78ed6447907b75a839a8639666f80c7f1e3b Mon Sep 17 00:00:00 2001 From: vipeketi Date: Tue, 6 Oct 2020 17:36:41 +0530 Subject: [PATCH 4/7] changedsince and filename with space sample added --- .../data-plane/QnAMaker/stable/v4.0/QnAMaker.json | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/specification/cognitiveservices/data-plane/QnAMaker/stable/v4.0/QnAMaker.json b/specification/cognitiveservices/data-plane/QnAMaker/stable/v4.0/QnAMaker.json index 97200377d315..cad95c93663e 100644 --- a/specification/cognitiveservices/data-plane/QnAMaker/stable/v4.0/QnAMaker.json +++ b/specification/cognitiveservices/data-plane/QnAMaker/stable/v4.0/QnAMaker.json @@ -567,6 +567,9 @@ }, { "$ref": "#/parameters/source" + }, + { + "$ref": "#/parameters/changedsince" } ], "consumes": [ @@ -1424,7 +1427,16 @@ "in": "query", "required": false, "x-nullable": false, - "description": "The source property filter to apply. Sample value: Editorial.", + "description": "The source property filter to apply. Sample value: Editorial, smartLight%20FAQ.tsv .", + "x-ms-parameter-location": "method" + }, + "changedsince": { + "type": "string", + "name": "changedsince", + "in": "query", + "required": false, + "x-nullable": false, + "description": "The changedsince property filter to apply. Sample value: 1d 1m 1h 1s.", "x-ms-parameter-location": "method" }, "OperationId": { From c6a79692e716727f0be9984db8e230f37e90ca9b Mon Sep 17 00:00:00 2001 From: vipeketi Date: Tue, 6 Oct 2020 17:44:44 +0530 Subject: [PATCH 5/7] adding changedsince to customwords for spellcheck --- custom-words.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/custom-words.txt b/custom-words.txt index 1312a8690409..0c47d7b96cb8 100644 --- a/custom-words.txt +++ b/custom-words.txt @@ -282,6 +282,7 @@ Certificatethumbprint certverify Chademo chainer +changedsince changepoint changestate CHECKACCESS From 80f1a8b3e6f990d0c3eee8d22beefa7029b1b24e Mon Sep 17 00:00:00 2001 From: vipeketi Date: Tue, 6 Oct 2020 22:04:57 +0530 Subject: [PATCH 6/7] changedSince Description camelCase --- custom-words.txt | 2 +- .../data-plane/QnAMaker/stable/v4.0/QnAMaker.json | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/custom-words.txt b/custom-words.txt index 0c47d7b96cb8..a162607f2476 100644 --- a/custom-words.txt +++ b/custom-words.txt @@ -282,7 +282,7 @@ Certificatethumbprint certverify Chademo chainer -changedsince +changedSince changepoint changestate CHECKACCESS diff --git a/specification/cognitiveservices/data-plane/QnAMaker/stable/v4.0/QnAMaker.json b/specification/cognitiveservices/data-plane/QnAMaker/stable/v4.0/QnAMaker.json index cad95c93663e..1c7eecf7fb9a 100644 --- a/specification/cognitiveservices/data-plane/QnAMaker/stable/v4.0/QnAMaker.json +++ b/specification/cognitiveservices/data-plane/QnAMaker/stable/v4.0/QnAMaker.json @@ -569,7 +569,7 @@ "$ref": "#/parameters/source" }, { - "$ref": "#/parameters/changedsince" + "$ref": "#/parameters/changedSince" } ], "consumes": [ @@ -1430,13 +1430,13 @@ "description": "The source property filter to apply. Sample value: Editorial, smartLight%20FAQ.tsv .", "x-ms-parameter-location": "method" }, - "changedsince": { + "changedSince": { "type": "string", - "name": "changedsince", + "name": "changedSince", "in": "query", "required": false, "x-nullable": false, - "description": "The changedsince property filter to apply. Sample value: 1d 1m 1h 1s.", + "description": "changedSince property is used to return all QnAs created or updated after a specific time duration. The user can provide the following values: 1s: Returns all QnA pairs updated/created in the last 1 second. 1m : Returns all QnA pairs updated/created in the past 1 minute. 1h : Returns all QnA pairs updated/created in the past hour. 1d : Returns all QnA pairs updated/created in the past 1 day.", "x-ms-parameter-location": "method" }, "OperationId": { From e29b0e04e7f0651323c6e67c5cf1eb81c2853ed5 Mon Sep 17 00:00:00 2001 From: vipeketi Date: Wed, 7 Oct 2020 13:20:23 +0530 Subject: [PATCH 7/7] Reduced description for changedSince Description --- .../data-plane/QnAMaker/stable/v4.0/QnAMaker.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/cognitiveservices/data-plane/QnAMaker/stable/v4.0/QnAMaker.json b/specification/cognitiveservices/data-plane/QnAMaker/stable/v4.0/QnAMaker.json index 1c7eecf7fb9a..78e71e4204c4 100644 --- a/specification/cognitiveservices/data-plane/QnAMaker/stable/v4.0/QnAMaker.json +++ b/specification/cognitiveservices/data-plane/QnAMaker/stable/v4.0/QnAMaker.json @@ -1436,7 +1436,7 @@ "in": "query", "required": false, "x-nullable": false, - "description": "changedSince property is used to return all QnAs created or updated after a specific time duration. The user can provide the following values: 1s: Returns all QnA pairs updated/created in the last 1 second. 1m : Returns all QnA pairs updated/created in the past 1 minute. 1h : Returns all QnA pairs updated/created in the past hour. 1d : Returns all QnA pairs updated/created in the past 1 day.", + "description": "changedSince property is used to return all QnAs created or updated after a specific time duration. The user can filter QnAs by seconds (s), minutes (m), hours (h) and days (d). The user may use any integral value along with the suffix for time. For instance, the value of 5m returns all QnA pairs updated or created in the last 5 minutes.", "x-ms-parameter-location": "method" }, "OperationId": {