-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Adding swagger for new SQL Pool rest APIs #11030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding swagger for new SQL Pool rest APIs #11030
Conversation
[Staging] Swagger Validation Report
️✔️ |
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-java - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net - Release
|
azure-resource-manager-schemas - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js - Release
|
azure-sdk-for-python - Release
|
azure-sdk-for-python
|
azure-sdk-for-go - Release
|
|
No pipelines are associated with this pull request. |
|
As per Synapse RPs communication with SQL team - "Spoke to the owners of the SQL API and they say the original API is old and for historical reasons they have not supported the 'list' operation. Supporting it at this time is not an option , so I'm not sure if SQL RP doesn't support the operation, how we could support the operation from the Synapse RP, because we have nothing to call on the SQL RP side." |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
|
@tunafish88 Please fix the linting violations, as outlined here: https://aka.ms/ci-fix |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@tunafish88 You will need to follow the guidance here: http://aka.ms/ci-fix to suppress the linter errors as the ARM team has signed off on them. |
Thanks for pointing this out Mark. I actually did follow this, filled out a suppression request form, got the suppression approval, added the suppression in the readme file and sent a new iteration. I'm not sure why the error is still showing up. I reached out the arm reviewer (and ccd you) asking them about it. |
...ification/synapse/resource-manager/Microsoft.Synapse/preview/2019-06-01-preview/sqlPool.json
Show resolved
Hide resolved
...ification/synapse/resource-manager/Microsoft.Synapse/preview/2019-06-01-preview/sqlPool.json
Show resolved
Hide resolved
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
…ted by a member of the ARM team
|
Azure Pipelines successfully started running 1 pipeline(s). |
Description:
These APIs are being added for SQL Pools. Behind the scenes these APIs just make a call to the corresponding rest API for SQL Databases (datawarehouses in particular).
Currently for SQL databases dynamic datamaskingPolicy only Get, Put are Supported and not list. (This has always been the case and is by design). Similar explanation for 'SqlPoolVulnerabilityAssessmentRuleBaseline'.
SQL Pool is maintaining parity with whatever SQL DB offers.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.