Skip to content

Conversation

@msHich
Copy link
Contributor

@msHich msHich commented Sep 24, 2020

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 24, 2020

[Staging] Swagger Validation Report

BreakingChange: 9 Errors, 0 Warnings [Detail] [Expand]
Rule Message
1022 - RemovedAdditionalProperties The new version removes the 'additionalProperties' element.
New: Microsoft.Portal/preview/2020-09-01-preview/portal.json#L550:9
Old: Microsoft.Portal/preview/2020-09-01-preview/portal.json#L553:9
1022 - RemovedAdditionalProperties The new version removes the 'additionalProperties' element.
New: Microsoft.Portal/preview/2020-09-01-preview/portal.json#L550:9
Old: Microsoft.Portal/preview/2020-09-01-preview/portal.json#L553:9
1022 - RemovedAdditionalProperties The new version removes the 'additionalProperties' element.
New: Microsoft.Portal/preview/2020-09-01-preview/portal.json#L530:9
Old: Microsoft.Portal/preview/2020-09-01-preview/portal.json#L530:9
1022 - RemovedAdditionalProperties The new version removes the 'additionalProperties' element.
New: Microsoft.Portal/preview/2020-09-01-preview/portal.json#L550:9
Old: Microsoft.Portal/preview/2020-09-01-preview/portal.json#L553:9
1034 - AddedRequiredProperty The new version has new required property 'order' that was not found in the old version.
New: Microsoft.Portal/preview/2020-09-01-preview/portal.json#L525:7
1034 - AddedRequiredProperty The new version has new required property 'parts' that was not found in the old version.
New: Microsoft.Portal/preview/2020-09-01-preview/portal.json#L525:7
1034 - AddedRequiredProperty The new version has new required property 'order, parts' that was not found in the old version.
New: Microsoft.Portal/preview/2020-09-01-preview/portal.json#L553:11
Old: Microsoft.Portal/preview/2020-09-01-preview/portal.json#L559:11
1034 - AddedRequiredProperty The new version has new required property 'position' that was not found in the old version.
New: Microsoft.Portal/preview/2020-09-01-preview/portal.json#L404:7
1034 - AddedRequiredProperty The new version has new required property 'position' that was not found in the old version.
New: Microsoft.Portal/preview/2020-09-01-preview/portal.json#L533:11
Old: Microsoft.Portal/preview/2020-09-01-preview/portal.json#L536:11
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
️✔️ModelValidation [Detail]
 Validation passes for ModelValidation. 
️✔️SemanticValidation [Detail]
 Validation passes for SemanticValidation. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 24, 2020

Azure CLI Extension Generation - Release

  • Installation instruction for service portal [Preview Changes]
    curl -L "https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/azure-rest-api-specs/10934/azure-cli-extensions/portal/portal-0.1.0-py3-none-any.whl" -o portal-0.1.0-py3-none-any.whl
    az extension add --source=portal-0.1.0-py3-none-any.whl
    
️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from b7d54cc with merge commit 654e235. Azure CLI Automation 13.0.17.20200918.2
    [AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'ProxyResource' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceProviderOperation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ProxyResource' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
    [AutoRest] WARNING (): Operation Update has already existed in group! Skip split!
    [AutoRest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
    [AutoRest] 
    [AutoRest] NO TEST SCENARIO PROVIDED - DEFAULT WILL BE USED
    [AutoRest] ADD FOLLOWING SECTION TO readme.cli.md FILE TO MODIFY IT
    [AutoRest] --------------------------------------------------------
    [AutoRest]   test-scenario:
    [AutoRest]     - name: /Dashboards/put/Create or update a Dashboard
    [AutoRest]     - name: /Dashboards/get/Get a Dashboard
    [AutoRest]     - name: /Dashboards/get/List all custom resource providers on the resourceGroup
    [AutoRest]     - name: /Dashboards/get/List all custom resource providers on the subscription
    [AutoRest]     - name: /Dashboards/patch/Update a Dashboard
    [AutoRest]     - name: /TenantConfigurations/put/Create or update Tenant configuration
    [AutoRest]     - name: /TenantConfigurations/get/Get Tenant configuration
    [AutoRest]     - name: /TenantConfigurations/get/Get list of Tenant configurations
    [AutoRest]     - name: /Dashboards/delete/Delete a Dashboard
    [AutoRest]     - name: /TenantConfigurations/delete/Delete Tenant configuration
    [AutoRest] --------------------------------------------------------
  • Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Mon, 28 Sep 2020 06:01:10 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"04C1:292D:1B8E0EE:2D64330:5F717C26","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 24, 2020

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from b7d54cc with merge commit 654e235. SDK Automation 13.0.17.20200918.2
  • ⚠️preview/portal/mgmt/2015-08-01-preview [View full logs
    No file is changed.
  • ⚠️preview/portal/mgmt/2018-10-01-preview [View full logs
    No file is changed.
  • ️✔️preview/portal/mgmt/2019-01-01-preview [View full logs]  [Release SDK Changes]
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Mon, 28 Sep 2020 06:07:01 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0782:3D3C:CBD8FD:1E1460A:5F717D85","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 24, 2020

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from b7d54cc with merge commit 654e235. SDK Automation 13.0.17.20200918.2
    Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 24, 2020

azure-sdk-for-js - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from b7d54cc with merge commit 654e235. SDK Automation 13.0.17.20200918.2
    Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 24, 2020

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 24, 2020

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from b7d54cc with merge commit 654e235. SDK Automation 13.0.17.20200918.2
    [azure-mgmt-portal][ChangeLog] WARNING: Failed to generate ChangeLog.
  • ⚠️azure-mgmt-portal [View full logs]  [Release SDK Changes]
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-portal
    [build_conf] INFO:packaging_tools.conf:Build default conf for azure-mgmt-portal
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-portal
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Mon, 28 Sep 2020 06:01:46 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0482:7761:1C844FC:3041C05:5F717C4A","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    Not exact 2 reports found:
    code_reports/latest/report.json
    Not generating changelog.
    [ChangeLog] WARNING: Failed to generate ChangeLog.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 24, 2020

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 24, 2020

azure-resource-manager-schemas - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from b7d54cc with merge commit 654e235. Schema Automation 13.0.17.20200918.2
    [portal][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
    [portal][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
    [portal][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
  • ️✔️portal [View full logs]  [Release Schema Changes]
      [after_scripts|node] PostProcessor finished successfully.
      [after_scripts|node]   5775 passing (1m)
      AzureResourceSchema has no registered package commands.
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Mon, 28 Sep 2020 06:07:05 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0403:0777:1483056A:187C9C88:5F717D89","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Sep 24, 2020

    Trenton Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @ruowan ruowan self-assigned this Sep 28, 2020
    @ruowan
    Copy link
    Member

    ruowan commented Sep 28, 2020

    @msHich The CI check reports breaking change. Is there any customer impact?

    @msHich
    Copy link
    Contributor Author

    msHich commented Sep 28, 2020 via email

    @ruowan ruowan added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Sep 28, 2020
    @ruowan ruowan merged commit 654e235 into Azure:master Sep 28, 2020
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    4 participants