Skip to content

Conversation

@navysingla
Copy link
Contributor

Fix to make parameters optional, This API is added only couple of weeks back, no actual customers yet, no SDKs released

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 4, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
️✔️ModelValidation [Detail]
 Validation passes for ModelValidation. 
️✔️SemanticValidation [Detail]
 Validation passes for SemanticValidation. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 4, 2020

Azure CLI Extension Generation - Release

  • Installation instruction for service account [Preview Changes]
    az extension add --source=https://sdkautomation.blob.core.windows.net/sdkautomation-pipeline/Azure/azure-rest-api-specs/10709/azure-cli-extensions/Azure/azure-cli-extensions/account/account-0.1.0-py3-none-any.whl
️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 764d123 with merge commit d3339ca. Azure CLI Automation 13.0.17.20200904.2
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Location' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'LocationListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Subscription' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'SubscriptionPolicies' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'SubscriptionListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'TenantIdDescription' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'TenantListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'CanceledSubscriptionId' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'RenamedSubscriptionId' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'EnabledSubscriptionId' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PutAliasRequestProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PutAliasResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PutAliasResponseProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PutAliasListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
    [AutoRest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
    [AutoRest] 
    [AutoRest] NO TEST SCENARIO PROVIDED - DEFAULT WILL BE USED
    [AutoRest] ADD FOLLOWING SECTION TO readme.cli.md FILE TO MODIFY IT
    [AutoRest] --------------------------------------------------------
    [AutoRest]   test-scenario:
    [AutoRest]     - name: /Alias/put/CreateAlias
    [AutoRest]     - name: /Alias/get/GetAlias
    [AutoRest]     - name: /Alias/get/GetAlias
    [AutoRest]     - name: /Subscriptions/get/getSubscription
    [AutoRest]     - name: /Subscriptions/get/listLocations
    [AutoRest]     - name: /Subscriptions/get/listSubscriptions
    [AutoRest]     - name: /Subscription/post/cancelSubscription
    [AutoRest]     - name: /Subscription/post/enableSubscription
    [AutoRest]     - name: /Subscription/post/renameSubscription
    [AutoRest]     - name: /Tenants/get/listTenants
    [AutoRest]     - name: /Alias/delete/DeleteAlias
    [AutoRest] --------------------------------------------------------

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 4, 2020

azure-sdk-for-go - Release

failed [Logs] [Expand Details]
  • Generate from 764d123 with merge commit d3339ca. SDK Automation 13.0.17.20200904.2
    [AutoRest] FATAL: System.InvalidOperationException: output-folder must not be under a preview subdirectory for stable swagger set Microsoft.Subscription/stable/2016-06-01/subscriptions.json, Microsoft.Subscription/preview/2019-10-01-preview/subscriptions.json
    [AutoRest]    at AutoRest.Go.CodeGeneratorGo.PreviewCheck(String folder) in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 186
    [AutoRest]    at AutoRest.Go.CodeGeneratorGo.d__7.MoveNext() in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 60
    [AutoRest] --- End of stack trace from previous location where exception was thrown ---
    [AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
    [AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
    [AutoRest]    at AutoRest.Go.Program.d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 107
    [AutoRest] --- End of stack trace from previous location where exception was thrown ---
    [AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
    [AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
    [AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
    [AutoRest]    at NewPlugin.d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
    [AutoRest] FATAL: go/generate - FAILED
    [AutoRest] FATAL: Error: Plugin go reported failure.
    [AutoRest] Failure during batch task - {"tag":"package-2019-10-preview"} -- Error: Plugin go reported failure..
    [AutoRest]   Error: Plugin go reported failure.
    Failed to run autorest.
    Error: /z/node_modules/.bin/autorest [email protected]/autorest.go@~2.1.153 --go --verbose --multiapi --use-onever --preview-chk --version=V2 --go-sdk-folder=/z/work/src/github.com/Azure/azure-sdk-for-go /z/work/azure-rest-api-specs/specification/subscription/resource-manager/readme.md FATAL: System.InvalidOperationException: output-folder must not be under a preview subdirectory for stable swagger set Microsoft.Subscription/stable/2016-06-01/subscriptions.json, Microsoft.Subscription/preview/2019-10-01-preview/subscriptions.json
       at AutoRest.Go.CodeGeneratorGo.PreviewCheck(String folder) in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 186
       at AutoRest.Go.CodeGeneratorGo.d__7.MoveNext() in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 60
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
       at AutoRest.Go.Program.d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 107
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
       at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
       at NewPlugin.d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
    FATAL: go/generate - FAILED
    FATAL: Error: Plugin go reported failure.
    Failure during batch task - {"tag":"package-2019-10-preview"} -- Error: Plugin go reported failure..
      Error: Plugin go reported failure.
    , {} 
    Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 4, 2020

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 4, 2020

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 764d123 with merge commit d3339ca. SDK Automation 13.0.17.20200904.2
  • ️✔️@azure/arm-subscriptions [View full logs]  [Release SDK Changes]
    Only show 100 items here, please refer to log for details.
    [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
    [npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
    [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/subscriptionClient.js → ./dist/arm-subscriptions.js...
    [npmPack] created ./dist/arm-subscriptions.js in 246ms
    [npmPack] npm notice 
    [npmPack] npm notice package: @azure/[email protected]
    [npmPack] npm notice === Tarball Contents === 
    [npmPack] npm notice 4.6kB  esm/operations/alias.js                          
    [npmPack] npm notice 546B   esm/models/aliasMappers.js                       
    [npmPack] npm notice 46.6kB dist/arm-subscriptions.js                        
    [npmPack] npm notice 14.9kB dist/arm-subscriptions.min.js                    
    [npmPack] npm notice 345B   esm/models/index.js                              
    [npmPack] npm notice 508B   esm/operations/index.js                          
    [npmPack] npm notice 15.2kB esm/models/mappers.js                            
    [npmPack] npm notice 1.5kB  esm/operations/operations.js                     
    [npmPack] npm notice 458B   esm/models/operationsMappers.js                  
    [npmPack] npm notice 1.7kB  esm/models/parameters.js                         
    [npmPack] npm notice 990B   rollup.config.js                                 
    [npmPack] npm notice 1.6kB  esm/subscriptionClient.js                        
    [npmPack] npm notice 2.2kB  esm/subscriptionClientContext.js                 
    [npmPack] npm notice 3.6kB  esm/operations/subscriptionOperations.js         
    [npmPack] npm notice 508B   esm/models/subscriptionOperationsMappers.js      
    [npmPack] npm notice 3.8kB  esm/operations/subscriptions.js                  
    [npmPack] npm notice 498B   esm/models/subscriptionsMappers.js               
    [npmPack] npm notice 2.2kB  esm/operations/tenants.js                        
    [npmPack] npm notice 441B   esm/models/tenantsMappers.js                     
    [npmPack] npm notice 1.7kB  package.json                                     
    [npmPack] npm notice 457B   tsconfig.json                                    
    [npmPack] npm notice 1.7kB  esm/operations/alias.d.ts.map                    
    [npmPack] npm notice 2.8kB  esm/operations/alias.js.map                      
    [npmPack] npm notice 254B   esm/models/aliasMappers.d.ts.map                 
    [npmPack] npm notice 267B   esm/models/aliasMappers.js.map                   
    [npmPack] npm notice 99.9kB dist/arm-subscriptions.js.map                    
    [npmPack] npm notice 14.7kB dist/arm-subscriptions.min.js.map                
    [npmPack] npm notice 6.4kB  esm/models/index.d.ts.map                        
    [npmPack] npm notice 225B   esm/operations/index.d.ts.map                    
    [npmPack] npm notice 126B   esm/models/index.js.map                          
    [npmPack] npm notice 240B   esm/operations/index.js.map                      
    [npmPack] npm notice 1.2kB  esm/models/mappers.d.ts.map                      
    [npmPack] npm notice 8.9kB  esm/models/mappers.js.map                        
    [npmPack] npm notice 663B   esm/operations/operations.d.ts.map               
    [npmPack] npm notice 908B   esm/operations/operations.js.map                 
    [npmPack] npm notice 215B   esm/models/operationsMappers.d.ts.map            
    [npmPack] npm notice 228B   esm/models/operationsMappers.js.map              
    [npmPack] npm notice 443B   esm/models/parameters.d.ts.map                   
    [npmPack] npm notice 1.2kB  esm/models/parameters.js.map                     
    [npmPack] npm notice 735B   esm/subscriptionClient.d.ts.map                  
    [npmPack] npm notice 918B   esm/subscriptionClient.js.map                    
    [npmPack] npm notice 424B   esm/subscriptionClientContext.d.ts.map           
    [npmPack] npm notice 1.2kB  esm/subscriptionClientContext.js.map             
    [npmPack] npm notice 1.6kB  esm/operations/subscriptionOperations.d.ts.map   
    [npmPack] npm notice 2.2kB  esm/operations/subscriptionOperations.js.map     
    [npmPack] npm notice 255B   esm/models/subscriptionOperationsMappers.d.ts.map
    [npmPack] npm notice 268B   esm/models/subscriptionOperationsMappers.js.map  
    [npmPack] npm notice 1.8kB  esm/operations/subscriptions.d.ts.map            
    [npmPack] npm notice 2.4kB  esm/operations/subscriptions.js.map              
    [npmPack] npm notice 244B   esm/models/subscriptionsMappers.d.ts.map         
    [npmPack] npm notice 257B   esm/models/subscriptionsMappers.js.map           
    [npmPack] npm notice 1.0kB  esm/operations/tenants.d.ts.map                  
    [npmPack] npm notice 1.4kB  esm/operations/tenants.js.map                    
    [npmPack] npm notice 199B   esm/models/tenantsMappers.d.ts.map               
    [npmPack] npm notice 212B   esm/models/tenantsMappers.js.map                 
    [npmPack] npm notice 3.3kB  README.md                                        
    [npmPack] npm notice 3.2kB  esm/operations/alias.d.ts                        
    [npmPack] npm notice 6.9kB  src/operations/alias.ts                          
    [npmPack] npm notice 236B   esm/models/aliasMappers.d.ts                     
    [npmPack] npm notice 523B   src/models/aliasMappers.ts                       
    [npmPack] npm notice 17.2kB esm/models/index.d.ts                            
    [npmPack] npm notice 192B   esm/operations/index.d.ts                        
    [npmPack] npm notice 16.7kB src/models/index.ts                              
    [npmPack] npm notice 476B   src/operations/index.ts                          
    [npmPack] npm notice 1.6kB  esm/models/mappers.d.ts                          
    [npmPack] npm notice 12.3kB src/models/mappers.ts                            
    [npmPack] npm notice 1.1kB  esm/operations/operations.d.ts                   
    [npmPack] npm notice 2.3kB  src/operations/operations.ts                     
    [npmPack] npm notice 148B   esm/models/operationsMappers.d.ts                
    [npmPack] npm notice 422B   src/models/operationsMappers.ts                  
    [npmPack] npm notice 475B   esm/models/parameters.d.ts                       
    [npmPack] npm notice 1.7kB  src/models/parameters.ts                         
    [npmPack] npm notice 1.0kB  esm/subscriptionClient.d.ts                      
    [npmPack] npm notice 1.6kB  src/subscriptionClient.ts                        
    [npmPack] npm notice 649B   esm/subscriptionClientContext.d.ts               
    [npmPack] npm notice 2.0kB  src/subscriptionClientContext.ts                 
    [npmPack] npm notice 3.2kB  esm/operations/subscriptionOperations.d.ts       
    [npmPack] npm notice 6.5kB  src/operations/subscriptionOperations.ts         
    [npmPack] npm notice 198B   esm/models/subscriptionOperationsMappers.d.ts    
    [npmPack] npm notice 462B   src/models/subscriptionOperationsMappers.ts      
    [npmPack] npm notice 4.0kB  esm/operations/subscriptions.d.ts                
    [npmPack] npm notice 7.7kB  src/operations/subscriptions.ts                  
    [npmPack] npm notice 188B   esm/models/subscriptionsMappers.d.ts             
    [npmPack] npm notice 463B   src/models/subscriptionsMappers.ts               
    [npmPack] npm notice 2.0kB  esm/operations/tenants.d.ts                      
    [npmPack] npm notice 4.0kB  src/operations/tenants.ts                        
    [npmPack] npm notice 131B   esm/models/tenantsMappers.d.ts                   

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 4, 2020

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 4, 2020

azure-sdk-for-python - Release

- Breaking Change detected in SDK

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 764d123 with merge commit d3339ca. SDK Automation 13.0.17.20200904.2
  • ⚠️azure-mgmt-subscription [View full logs]  [Release SDK Changes] Breaking Change Detected
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-subscription
    [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-subscription
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    [ChangeLog] Size of delta 39.408% size of original (original: 9120 chars, delta: 3594 chars)
    [ChangeLog] **Features**
    [ChangeLog] 
    [ChangeLog]   - Added operation group AliasOperations
    [ChangeLog] 
    [ChangeLog] **Breaking changes**
    [ChangeLog] 
    [ChangeLog]   - Removed operation SubscriptionOperations.create_subscription
    [ChangeLog]   - Removed operation SubscriptionOperations.create_csp_subscription
    [ChangeLog]   - Removed operation SubscriptionOperations.create_subscription_in_enrollment_account
    [ChangeLog]   - Removed operation group SubscriptionOperationOperations

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 4, 2020

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 4, 2020

azure-resource-manager-schemas - Release

⚠️ warning [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 4, 2020

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@PhoenixHe-NV
Copy link

@navysingla Please fix the go generation failure by updating output-folder and remove preview in path

@navysingla
Copy link
Contributor Author

@navysingla Please fix the go generation failure by updating output-folder and remove preview in path

Which output folder to update? why it is needed now as I am just changing required parameters to optional?

@PhoenixHe-NV
Copy link

Go SDK owner will help to fix this. Merge this PR.

@PhoenixHe-NV PhoenixHe-NV merged commit d3339ca into Azure:master Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants