[Text Analytics] Make redactedText required #10691

deyaaeldeen · 2020-09-03T20:30:54Z

Make redactedText property required.

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

openapi-pipeline-app · 2020-09-03T20:30:59Z

[Staging] Swagger Validation Report

️❌BreakingChange: 2 Errors, 0 Warnings [Detail] [Expand]

Rule	Message
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'redactedText' that was not found in the old version. New: TextAnalytics/preview/v3.1-preview.2/TextAnalytics.json#L922:11 Old: TextAnalytics/preview/v3.1-preview.2/TextAnalytics.json#L922:11
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'redactedText' that was not found in the old version. New: TextAnalytics/preview/v3.1-preview.2/TextAnalytics.json#L974:5 Old: TextAnalytics/preview/v3.1-preview.2/TextAnalytics.json#L974:5

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️️✔️Avocado [Detail]

 Validation passes for Avocado.

️️✔️ModelValidation [Detail]

 Validation passes for ModelValidation.

️️✔️SemanticValidation [Detail]

 Validation passes for SemanticValidation.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-09-03T20:31:11Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-09-03T20:32:51Z

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-09-03T20:32:52Z

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from f74cb60 with merge commit ff06cd3. SDK Automation 13.0.17.20200904.2
⚠️cognitiveservices/v2.0 [View full logs]
- cognitiveservices.v2.0.zip
```
No file is changed.
```
⚠️cognitiveservices/v2.1 [View full logs]
- cognitiveservices.v2.1.zip
```
No file is changed.
```

openapi-sdkautomation · 2020-09-03T20:33:09Z

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from f74cb60 with merge commit ff06cd3. SDK Automation 13.0.17.20200904.2

Failed to find any changed packages. Please check the changed file list.
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/TextAnalyticsClient.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/implementation/TextAnalyticsClientImpl.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/implementation/package-info.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/models/DetectedLanguage.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/models/DocumentStatistics.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/models/EntitiesBatchResult.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/models/EntitiesBatchResultItem.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/models/EntityRecord.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/models/ErrorRecord.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/models/ErrorResponse.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/models/ErrorResponseException.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/models/InternalError.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/models/KeyPhraseBatchResult.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/models/KeyPhraseBatchResultItem.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/models/LanguageBatchInput.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/models/LanguageBatchResult.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/models/LanguageBatchResultItem.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/models/LanguageInput.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/models/MatchRecord.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/models/MultiLanguageBatchInput.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/models/MultiLanguageInput.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/models/RequestStatistics.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/models/SentimentBatchResult.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/models/SentimentBatchResultItem.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/models/package-info.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/package-info.java

openapi-sdkautomation · 2020-09-03T20:33:26Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from f74cb60 with merge commit ff06cd3. SDK Automation 13.0.17.20200904.2

️✔️@azure/cognitiveservices-textanalytics [View full logs] [Release SDK Changes]

azure-cognitiveservices-textanalytics-4.0.0.tgz

[npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
[npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
[npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/textAnalyticsClient.js → ./dist/cognitiveservices-textanalytics.js...
[npmPack] created ./dist/cognitiveservices-textanalytics.js in 158ms
[npmPack] npm notice 
[npmPack] npm notice package: @azure/[email protected]
[npmPack] npm notice === Tarball Contents === 
[npmPack] npm notice 32.5kB dist/cognitiveservices-textanalytics.js        
[npmPack] npm notice 10.6kB dist/cognitiveservices-textanalytics.min.js    
[npmPack] npm notice 345B   esm/models/index.js                            
[npmPack] npm notice 18.5kB esm/models/mappers.js                          
[npmPack] npm notice 803B   esm/models/parameters.js                       
[npmPack] npm notice 1.0kB  rollup.config.js                               
[npmPack] npm notice 4.6kB  esm/textAnalyticsClient.js                     
[npmPack] npm notice 2.0kB  esm/textAnalyticsClientContext.js              
[npmPack] npm notice 1.7kB  package.json                                   
[npmPack] npm notice 457B   tsconfig.json                                  
[npmPack] npm notice 67.1kB dist/cognitiveservices-textanalytics.js.map    
[npmPack] npm notice 9.5kB  dist/cognitiveservices-textanalytics.min.js.map
[npmPack] npm notice 5.1kB  esm/models/index.d.ts.map                      
[npmPack] npm notice 126B   esm/models/index.js.map                        
[npmPack] npm notice 1.1kB  esm/models/mappers.d.ts.map                    
[npmPack] npm notice 10.3kB esm/models/mappers.js.map                      
[npmPack] npm notice 255B   esm/models/parameters.d.ts.map                 
[npmPack] npm notice 508B   esm/models/parameters.js.map                   
[npmPack] npm notice 1.8kB  esm/textAnalyticsClient.d.ts.map               
[npmPack] npm notice 2.8kB  esm/textAnalyticsClient.js.map                 
[npmPack] npm notice 398B   esm/textAnalyticsClientContext.d.ts.map        
[npmPack] npm notice 970B   esm/textAnalyticsClientContext.js.map          
[npmPack] npm notice 3.6kB  README.md                                      
[npmPack] npm notice 13.6kB esm/models/index.d.ts                          
[npmPack] npm notice 13.3kB src/models/index.ts                            
[npmPack] npm notice 1.4kB  esm/models/mappers.d.ts                        
[npmPack] npm notice 14.5kB src/models/mappers.ts                          
[npmPack] npm notice 210B   esm/models/parameters.d.ts                     
[npmPack] npm notice 810B   src/models/parameters.ts                       
[npmPack] npm notice 4.9kB  esm/textAnalyticsClient.d.ts                   
[npmPack] npm notice 8.8kB  src/textAnalyticsClient.ts                     
[npmPack] npm notice 758B   esm/textAnalyticsClientContext.d.ts            
[npmPack] npm notice 1.7kB  src/textAnalyticsClientContext.ts              
[npmPack] npm notice 1.1kB  LICENSE.txt                                    
[npmPack] npm notice === Tarball Details === 
[npmPack] npm notice name:          @azure/cognitiveservices-textanalytics         
[npmPack] npm notice version:       4.0.0                                          
[npmPack] npm notice filename:      azure-cognitiveservices-textanalytics-4.0.0.tgz
[npmPack] npm notice package size:  32.0 kB                                        
[npmPack] npm notice unpacked size: 237.3 kB                                       
[npmPack] npm notice shasum:        5b1df9aacbc66dfc7e8af2fade6bbfa2530aa6bc       
[npmPack] npm notice integrity:     sha512-kQCZKgUxT/14U[...]21zcUjNa+R1MQ==       
[npmPack] npm notice total files:   34                                             
[npmPack] npm notice

openapi-sdkautomation · 2020-09-03T20:33:30Z

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-09-03T20:33:32Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from f74cb60 with merge commit ff06cd3. SDK Automation 13.0.17.20200904.2

️✔️azure-cognitiveservices-language-textanalytics [View full logs] [Release SDK Changes]

[build_conf] INFO:packaging_tools:Building template azure-cognitiveservices-language-textanalytics
[build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
[build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
[build_conf] INFO:packaging_tools:Template done azure-cognitiveservices-language-textanalytics
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[ChangeLog] Traceback (most recent call last):
[ChangeLog]   File "/usr/lib/python3.6/runpy.py", line 193, in _run_module_as_main
[ChangeLog]     "__main__", mod_spec)
[ChangeLog]   File "/usr/lib/python3.6/runpy.py", line 85, in _run_code
[ChangeLog]     exec(code, run_globals)
[ChangeLog]   File "/z/work/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/change_log.py", line 200, in 
[ChangeLog]     change_log = build_change_log(old_report, new_report)
[ChangeLog]   File "/z/work/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/change_log.py", line 147, in build_change_log
[ChangeLog]     change_log.operation(diff_line)
[ChangeLog]   File "/z/work/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/change_log.py", line 38, in operation
[ChangeLog]     _, operation_name, *remaining_path = path
[ChangeLog] ValueError: not enough values to unpack (expected at least 2, got 1)
[ChangeLog] Size of delta 7.210% size of original (original: 8641 chars, delta: 623 chars)

openapi-sdkautomation · 2020-09-03T20:33:34Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-09-03T20:33:50Z

azure-resource-manager-schemas - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-09-03T20:33:56Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

iscai-msft

approving the code, waiting to see what the service team says

[Text Analytics] Make redactedText required

f74cb60

deyaaeldeen requested review from iscai-msft, laramume, maririos and mssfang September 3, 2020 20:30

deyaaeldeen requested a review from yangyuan as a code owner September 3, 2020 20:30

openapi-assignment-bot bot assigned lmazuel Sep 3, 2020

iscai-msft approved these changes Sep 3, 2020

View reviewed changes

deyaaeldeen mentioned this pull request Sep 3, 2020

[Text Analytics] Generate sdk with 3.1 preview.2 Azure/azure-sdk-for-js#11015

Merged

lmazuel approved these changes Sep 4, 2020

View reviewed changes

lmazuel merged commit ff06cd3 into Azure:master Sep 4, 2020

deyaaeldeen deleted the required-redacted-text branch September 4, 2020 20:13

[Text Analytics] Make redactedText required #10691

[Text Analytics] Make redactedText required #10691

Uh oh!

Conversation

deyaaeldeen commented Sep 3, 2020

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

Uh oh!

openapi-pipeline-app bot commented Sep 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

[Staging] Swagger Validation Report

Uh oh!

azure-pipelines bot commented Sep 3, 2020

Uh oh!

openapi-sdkautomation bot commented Sep 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Azure CLI Extension Generation - Release

Uh oh!

openapi-sdkautomation bot commented Sep 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go - Release

Uh oh!

openapi-sdkautomation bot commented Sep 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java - Release

Uh oh!

openapi-sdkautomation bot commented Sep 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js - Release

Uh oh!

openapi-sdkautomation bot commented Sep 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net - Release

Uh oh!

openapi-sdkautomation bot commented Sep 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python - Release

Uh oh!

openapi-sdkautomation bot commented Sep 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python-track2 - Release

Uh oh!

openapi-sdkautomation bot commented Sep 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-resource-manager-schemas - Release

Uh oh!

openapi-sdkautomation bot commented Sep 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Trenton Generation - Release

Uh oh!

iscai-msft left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

openapi-pipeline-app bot commented Sep 3, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 3, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 3, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 3, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 3, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 3, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 3, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 3, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 3, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 3, 2020 •

edited

Loading