Add TenantConfiguration API to the Microsoft.Portal provider (version 2019-01-01-preview) #10603

AKachan0v · 2020-08-27T00:27:37Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

openapi-pipeline-app · 2020-08-27T00:27:41Z

[Staging] Swagger Validation Report

️️✔️BreakingChange [Detail]

 There are no breaking changes.

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️️✔️Avocado [Detail]

 Validation passes for Avocado.

️️✔️ModelValidation [Detail]

 Validation passes for ModelValidation.

️️✔️SemanticValidation [Detail]

 Validation passes for SemanticValidation.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-08-27T00:27:53Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-08-27T00:29:55Z

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 3f298df with merge commit 8f09f31. SDK Automation 13.0.17.20200904.2

Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-go/pull/8034: HttpError: Reference does not exist, {"name":"HttpError","status":422,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-length":"122","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 08 Sep 2020 04:41:31 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"422 Unprocessable Entity","strict-transport-security":"max-age=31536000; includeSubdomains; preload","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"04C2:3D18:2545665:3EC0818:5F570B7B","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4711","x-ratelimit-reset":"1599540714","x-ratelimit-used":"289","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-go/git/refs/heads/sdkAutomation/preview_portal_mgmt_2019-01-01-preview@10603","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest/reference/git#delete-a-reference"}

⚠️preview/portal/mgmt/2015-08-01-preview [View full logs]
- preview.portal.mgmt.2015-08-01-preview.zip
```
No file is changed.
```
⚠️preview/portal/mgmt/2018-10-01-preview [View full logs]
- preview.portal.mgmt.2018-10-01-preview.zip
```
No file is changed.
```
️✔️preview/portal/mgmt/2019-01-01-preview [View full logs] [Release SDK Changes]
- preview.portal.mgmt.2019-01-01-preview.zip

openapi-sdkautomation · 2020-08-27T00:30:01Z

Azure CLI Extension Generation - Release

Installation instruction for service portal [Preview Changes]
az extension add --source=https://sdkautomation.blob.core.windows.net/sdkautomation-pipeline/Azure/azure-rest-api-specs/10603/azure-cli-extensions/Azure/azure-cli-extensions/portal/portal-0.1.0-py3-none-any.whl

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 3f298df with merge commit 8f09f31. Azure CLI Automation 13.0.17.20200904.2

Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-cli-extensions/pull/185: HttpError: Reference does not exist, {"name":"HttpError","status":422,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-length":"122","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 08 Sep 2020 04:39:26 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"422 Unprocessable Entity","strict-transport-security":"max-age=31536000; includeSubdomains; preload","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"0787:B50D:4F4F16A:5F77E05:5F570AFE","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4925","x-ratelimit-reset":"1599540714","x-ratelimit-used":"75","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-cli-extensions/git/refs/heads/sdkAutomation/portal@10603","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest/reference/git#delete-a-reference"}
[AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'ProxyResource' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceProviderOperation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ProxyResource' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
[AutoRest] WARNING (): Operation Update has already existed in group! Skip split!
[AutoRest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
[AutoRest] 
[AutoRest] NO TEST SCENARIO PROVIDED - DEFAULT WILL BE USED
[AutoRest] ADD FOLLOWING SECTION TO readme.cli.md FILE TO MODIFY IT
[AutoRest] --------------------------------------------------------
[AutoRest]   test-scenario:
[AutoRest]     - name: /Dashboards/put/Create or update a Dashboard
[AutoRest]     - name: /Dashboards/get/Get a Dashboard
[AutoRest]     - name: /Dashboards/get/List all custom resource providers on the resourceGroup
[AutoRest]     - name: /Dashboards/get/List all custom resource providers on the subscription
[AutoRest]     - name: /Dashboards/patch/Update a Dashboard
[AutoRest]     - name: /TenantConfigurations/put/Create or update Tenant configuration
[AutoRest]     - name: /TenantConfigurations/get/Get Tenant configuration
[AutoRest]     - name: /TenantConfigurations/get/Get list of Tenant configurations
[AutoRest]     - name: /Dashboards/delete/Delete a Dashboard
[AutoRest]     - name: /TenantConfigurations/delete/Delete Tenant configuration
[AutoRest] --------------------------------------------------------

️✔️portal [View full logs] [Release Azure CLI Changes]
- portal-0.1.0-py3-none-any.whl
- portal-0.1.0.zip

openapi-sdkautomation · 2020-08-27T00:30:04Z

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 3f298df with merge commit 8f09f31. SDK Automation 13.0.17.20200904.2
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-08-27T00:30:05Z

azure-sdk-for-js - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 3f298df with merge commit 8f09f31. SDK Automation 13.0.17.20200904.2
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-08-27T00:30:25Z

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-08-27T00:30:29Z

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 3f298df with merge commit 8f09f31. SDK Automation 13.0.17.20200904.2

Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-python/pull/1931: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 08 Sep 2020 04:39:46 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"044C:DA25:1E70BD93:24D76170:5F570B12","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4844","x-ratelimit-reset":"1599540714","x-ratelimit-used":"156","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-python/git/refs/heads/sdkAutomation/azure-mgmt-portal@10603","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest/reference/git#delete-a-reference"}
[azure-mgmt-portal][ChangeLog] WARNING: Failed to generate ChangeLog.

⚠️azure-mgmt-portal [View full logs] [Release SDK Changes]

[build_conf] INFO:packaging_tools:Building template azure-mgmt-portal
[build_conf] INFO:packaging_tools.conf:Build default conf for azure-mgmt-portal
[build_conf] INFO:packaging_tools:Template done azure-mgmt-portal
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
Not exact 2 reports found:
code_reports/latest/report.json
Not generating changelog.
[ChangeLog] WARNING: Failed to generate ChangeLog.

openapi-sdkautomation · 2020-08-27T00:30:33Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-08-27T00:30:48Z

azure-resource-manager-schemas - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 3f298df with merge commit 8f09f31. Schema Automation 13.0.17.20200904.2
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-08-27T00:30:54Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azure-pipelines · 2020-08-27T00:35:44Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-08-27T01:09:36Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-08-27T18:20:49Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-08-27T18:48:44Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-08-27T19:50:49Z

Azure Pipelines successfully started running 1 pipeline(s).

...portal/resource-manager/Microsoft.Portal/preview/2019-01-01-preview/tenantConfiguration.json

majastrz

I added a few comments. Please take a look.

azure-pipelines · 2020-09-04T18:47:27Z

Azure Pipelines successfully started running 1 pipeline(s).

majastrz · 2020-09-04T19:05:39Z

Once you add the LIST call I should be able to sign off.

azure-pipelines · 2020-09-04T20:22:52Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-09-04T20:27:10Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-09-04T20:30:31Z

Azure Pipelines successfully started running 1 pipeline(s).

majastrz

Signed off from ARM side.

azure-pipelines · 2020-09-04T23:59:45Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-09-05T00:32:36Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-09-05T05:59:59Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-09-05T06:03:05Z

Azure Pipelines successfully started running 1 pipeline(s).

PhoenixHe-NV · 2020-09-07T03:40:24Z

Confirming cli extension generation failure

qiaozha · 2020-09-08T03:50:05Z

/azp run

azure-pipelines · 2020-09-08T03:50:23Z

Azure Pipelines successfully started running 3 pipeline(s).

Alex Kachanov added 2 commits August 26, 2020 17:20

#7912260: Add tenant configuration API

d536317

Fix version

c5faedd

openapi-assignment-bot bot assigned PhoenixHe-NV Aug 27, 2020

openapi-sdkautomation bot mentioned this pull request Aug 27, 2020

[AutoPR azure-mgmt-portal] Dev portal microsoft.portal 2019 01 01 preview AzureSDKAutomation/azure-sdk-for-python#1874

Closed

Fix references

364a7d9

Alex Kachanov added 2 commits August 26, 2020 17:55

Fix Prettier

7232309

Add new file to readme.md

a5b3761

This was referenced Aug 27, 2020

[AutoPR portal] Dev portal microsoft.portal 2019 01 01 preview AzureSDKAutomation/azure-cli-extensions#185

Closed

[AutoPR portal] Dev portal microsoft.portal 2019 01 01 preview AzureSDKAutomation/azure-resource-manager-schemas#157

Closed

Fix Linter warnings

c76232d

Add Delete method

991fe3d

Adds suppression to readme

6316333

AKachan0v marked this pull request as ready for review August 27, 2020 20:33

AKachan0v changed the title ~~Dev portal microsoft.portal 2019 01 01 preview~~ Add TenantConfiguration API to the Microsoft.Portal provider (version 2019-01-01-preview) Aug 27, 2020

majastrz reviewed Sep 3, 2020

View reviewed changes

...portal/resource-manager/Microsoft.Portal/preview/2019-01-01-preview/tenantConfiguration.json Outdated Show resolved Hide resolved

majastrz added ARMChangesRequested and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 3, 2020

majastrz requested changes Sep 3, 2020

View reviewed changes

Change resource type to plural and descriptions

7b9793e

Add Tenant configuration list

00cc003

Fix example position

a3e8f91

Fix Prettier

04a90d4

majastrz approved these changes Sep 4, 2020

View reviewed changes

majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested labels Sep 4, 2020

Change version for common types

cc655e6

Use local definition instead of ref common types

fda576f

Revoke 2 latest commits and return repo to signed off state

fa1bc17

Fix Prettier

3f298df

PhoenixHe-NV approved these changes Sep 8, 2020

View reviewed changes

PhoenixHe-NV merged commit 8f09f31 into Azure:master Sep 8, 2020

AKachan0v deleted the dev-portal-Microsoft.Portal-2019-01-01-preview branch November 2, 2020 19:38

Add TenantConfiguration API to the Microsoft.Portal provider (version 2019-01-01-preview) #10603

Add TenantConfiguration API to the Microsoft.Portal provider (version 2019-01-01-preview) #10603

Uh oh!

Conversation

AKachan0v commented Aug 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

Uh oh!

openapi-pipeline-app bot commented Aug 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

[Staging] Swagger Validation Report

Uh oh!

azure-pipelines bot commented Aug 27, 2020

Uh oh!

openapi-sdkautomation bot commented Aug 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go - Release

Uh oh!

openapi-sdkautomation bot commented Aug 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Azure CLI Extension Generation - Release

Uh oh!

openapi-sdkautomation bot commented Aug 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java - Release

Uh oh!

openapi-sdkautomation bot commented Aug 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js - Release

Uh oh!

openapi-sdkautomation bot commented Aug 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net - Release

Uh oh!

openapi-sdkautomation bot commented Aug 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python - Release

Uh oh!

openapi-sdkautomation bot commented Aug 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python-track2 - Release

Uh oh!

openapi-sdkautomation bot commented Aug 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-resource-manager-schemas - Release

Uh oh!

openapi-sdkautomation bot commented Aug 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Trenton Generation - Release

Uh oh!

azure-pipelines bot commented Aug 27, 2020

Uh oh!

azure-pipelines bot commented Aug 27, 2020

Uh oh!

azure-pipelines bot commented Aug 27, 2020

Uh oh!

azure-pipelines bot commented Aug 27, 2020

Uh oh!

azure-pipelines bot commented Aug 27, 2020

Uh oh!

Uh oh!

majastrz left a comment

Choose a reason for hiding this comment

Uh oh!

azure-pipelines bot commented Sep 4, 2020

Uh oh!

majastrz commented Sep 4, 2020

Uh oh!

azure-pipelines bot commented Sep 4, 2020

Uh oh!

azure-pipelines bot commented Sep 4, 2020

Uh oh!

azure-pipelines bot commented Sep 4, 2020

Uh oh!

majastrz left a comment

Choose a reason for hiding this comment

Uh oh!

azure-pipelines bot commented Sep 4, 2020

AKachan0v commented Aug 27, 2020 •

edited

Loading

openapi-pipeline-app bot commented Aug 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 27, 2020 •

edited

Loading