[2019-10-01-preview] Fixes and additional improvements for Public Preview #10382

innosam · 2020-08-07T07:36:51Z

Support to pass source id in Prepare/Move/Commit/Discard operations.
Define the additinal error information schema.
Expose the read only source settings.
Few fixes in marking the properties readonly/mandatory as
appropriate.

### Breaking Changes
This is a Preview PR and the breaking change policy does not apply. Guidelines-and-Scope

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

openapi-pipeline-app · 2020-08-07T07:36:55Z

[Staging] Swagger Validation Report

️❌BreakingChange: 22 Errors, 0 Warnings [Detail] [Expand]

Only 10 items are listed, please refer to log for more details.

Rule	Message
`❌` 1011 - AddingResponseCode	The new version adds a response code '201'. New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L56:11
`❌` 1026 - TypeChanged	The new version has a different type 'array' than the previous one 'object'. New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1942:9 Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1874:9
`❌` 1026 - TypeChanged	The new version has a different type 'array' than the previous one 'object'. New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1942:9 Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1874:9
`❌` 1026 - TypeChanged	The new version has a different type 'array' than the previous one 'object'. New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1942:9 Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1874:9
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1207:9 Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1181:9
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1305:9 Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1266:9
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1054:5 Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1036:5
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'moveResources' that was not found in the old version. New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L412:13 Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L406:13
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'moveResources' that was not found in the old version. New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L477:13 Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L471:13
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'moveResources' that was not found in the old version. New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1443:5 Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1386:5

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️️✔️Avocado [Detail]

 Validation passes for Avocado.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-08-07T07:37:08Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-08-07T08:16:34Z

azure-sdk-for-java - Release

❌ failed [Logs] [Expand Details]

❌ Generate from 91cbf78 with merge commit 96782ca. SDK Automation 13.0.17.20200807.2

[AutoRest] FATAL: System.Exception: Duplicate File Generation: src/main/java//implementation/MoveCollectionsImpl.java
[AutoRest]    at AutoRest.Core.CodeGenerator.d__13.MoveNext() in /home/vsts/work/1/s/autorest.common/src/CodeGenerator.cs:line 151
[AutoRest] --- End of stack trace from previous location where exception was thrown ---
[AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
[AutoRest]    at AutoRest.Core.CodeGenerator.d__12.MoveNext() in /home/vsts/work/1/s/autorest.common/src/CodeGenerator.cs:line 121
[AutoRest] --- End of stack trace from previous location where exception was thrown ---
[AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
[AutoRest]    at AutoRest.Java.CodeGeneratorJv.d__10.MoveNext() in /home/vsts/work/1/s/src/vanilla/CodeGeneratorJv.cs:line 58
[AutoRest] --- End of stack trace from previous location where exception was thrown ---
[AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
[AutoRest]    at AutoRest.Java.Program.d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 114
[AutoRest] --- End of stack trace from previous location where exception was thrown ---
[AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
[AutoRest]    at NewPlugin.d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
[AutoRest] FATAL: java/generate - FAILED
[AutoRest] FATAL: Error: Plugin java reported failure.
[AutoRest]   Error: Plugin java reported failure.
Failed to run autorest.
Error: /z/node_modules/.bin/autorest --version=V2 --java --verbose --multiapi [email protected]/autorest.java@preview --azure-libraries-for-java-folder=/z/work/azure-sdk-for-java /z/work/azure-rest-api-specs/specification/regionmove/resource-manager/readme.md FATAL: System.Exception: Duplicate File Generation: src/main/java//implementation/MoveCollectionsImpl.java
   at AutoRest.Core.CodeGenerator.d__13.MoveNext() in /home/vsts/work/1/s/autorest.common/src/CodeGenerator.cs:line 151
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Core.CodeGenerator.d__12.MoveNext() in /home/vsts/work/1/s/autorest.common/src/CodeGenerator.cs:line 121
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Java.CodeGeneratorJv.d__10.MoveNext() in /home/vsts/work/1/s/src/vanilla/CodeGeneratorJv.cs:line 58
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Java.Program.d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 114
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at NewPlugin.d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
FATAL: java/generate - FAILED
FATAL: Error: Plugin java reported failure.
  Error: Plugin java reported failure.
, {} 
Failed to find any diff after autorest so no changed packages was found.

openapi-sdkautomation · 2020-08-07T08:17:04Z

azure-sdk-for-go - Release

❌ failed [Logs] [Expand Details]

❌ Generate from 91cbf78 with merge commit 96782ca. SDK Automation 13.0.17.20200807.2

[AutoRest] FATAL: System.InvalidOperationException: namespace can only contains lower case letters, numbers and underscore
[AutoRest]    at AutoRest.Go.CodeGeneratorGo.d__7.MoveNext() in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 58
[AutoRest] --- End of stack trace from previous location where exception was thrown ---
[AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
[AutoRest]    at AutoRest.Go.Program.d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 107
[AutoRest] --- End of stack trace from previous location where exception was thrown ---
[AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
[AutoRest]    at NewPlugin.d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
[AutoRest] FATAL: go/generate - FAILED
[AutoRest] FATAL: Error: Plugin go reported failure.
[AutoRest]   Error: Plugin go reported failure.
Failed to run autorest.
Error: /z/node_modules/.bin/autorest [email protected]/autorest.go@~2.1.153 --go --verbose --multiapi --use-onever --preview-chk --version=V2 --go-sdk-folder=/z/work/src/github.com/Azure/azure-sdk-for-go /z/work/azure-rest-api-specs/specification/regionmove/resource-manager/readme.md FATAL: System.InvalidOperationException: namespace can only contains lower case letters, numbers and underscore
   at AutoRest.Go.CodeGeneratorGo.d__7.MoveNext() in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 58
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Go.Program.d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 107
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at NewPlugin.d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
FATAL: go/generate - FAILED
FATAL: Error: Plugin go reported failure.
  Error: Plugin go reported failure.
, {} 
Failed to find any diff after autorest so no changed packages was found.

openapi-sdkautomation · 2020-08-07T08:17:19Z

azure-sdk-for-js - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 91cbf78 with merge commit 96782ca. SDK Automation 13.0.17.20200807.2
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-08-07T08:17:46Z

Azure CLI Extension Generation - Release

⌛ Pending...

openapi-sdkautomation · 2020-08-07T08:17:56Z

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 91cbf78 with merge commit 96782ca. SDK Automation 13.0.17.20200807.2

Failed to find any changed packages. Please check the changed file list.
/z/work/azure-sdk-for-python/sdk/azure-mgmt/regionmove/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/regionmove/_configuration.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/regionmove/_region_move_service_api.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/regionmove/models/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/regionmove/models/_models.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/regionmove/models/_models_py3.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/regionmove/models/_paged_models.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/regionmove/models/_region_move_service_api_enums.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/regionmove/operations/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/regionmove/operations/_move_collection_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/regionmove/operations/_move_collections_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/regionmove/operations/_move_resources_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/regionmove/operations/_operations_discovery_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/regionmove/operations/_unresolved_dependencies_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/regionmove/version.py

azuresdkci · 2020-08-07T08:17:56Z

Can one of the admins verify this patch?

openapi-sdkautomation · 2020-08-07T08:18:11Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-08-07T08:18:16Z

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

PhoenixHe-NV · 2020-08-10T02:01:03Z

/azp run

azure-pipelines · 2020-08-10T02:01:24Z

Azure Pipelines successfully started running 3 pipeline(s).

openapi-sdkautomation · 2020-08-10T02:03:36Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azure-pipelines · 2020-08-10T08:50:19Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-08-11T12:50:30Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-08-11T12:58:59Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-08-11T13:04:39Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-08-11T13:17:27Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-08-11T13:23:32Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-08-11T20:35:56Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-08-11T20:49:17Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-08-11T20:55:12Z

Azure Pipelines successfully started running 1 pipeline(s).

PhoenixHe-NV

Your PR contains a lot of breaking change. Please try to avoid breaking change or please provide reason for each of them

PhoenixHe-NV · 2020-08-13T11:37:08Z

...move/resource-manager/Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json

        "provisioningState": {
-          "$ref": "#/definitions/ProvisioningState"
+          "$ref": "#/definitions/ProvisioningState",
+          "readOnly": true


This will not work. If you want to modify the readOnly, please consider adding another model

do you mean this is breaking change and hence not allowed to change it to readonly?

I mean it will not work to add "readOnly" on a ref directly. Only comment and description are allowed on ref

got it, i have updated the referred definition to readonly.

...move/resource-manager/Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json

azure-pipelines · 2020-08-14T11:08:03Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-08-14T11:14:44Z

azure-resource-manager-schemas - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 91cbf78 with merge commit 96782ca. Schema Automation 13.0.17.20200807.2

⚠️regionmove [View full logs] [Release Schema Changes]

[after_scripts|node] PostProcessor finished successfully.
[after_scripts|node]   5608 passing (1m)
[after_scripts|node]   1 failing
AzureResourceSchema has no registered package commands.

azure-pipelines · 2020-08-14T11:22:59Z

Azure Pipelines successfully started running 1 pipeline(s).

1. Support to pass source id in Prepare/Move/Commit/Discard operations. 2. Define the additinal error information schema. 3. Expose the read only source settings. 4. Few fixes in marking the properties readonly/mandatory as appropriate.

azure-pipelines · 2020-08-14T11:47:03Z

Azure Pipelines successfully started running 1 pipeline(s).

innosam · 2020-08-14T11:59:37Z

Breaking Changes Details

The service is in private preview, and we are doing this fixes/improvements as part of public preview that is tentatively planned on 27th September 2020.
Additionally our private preview customer do not use the API's directly instead rely on the portal for the usage.
We are also working on releasing auto generated powershell and SDK's so the swagger is being actively validated before public preview.

Summary of breaking change:
Improvements:

The additionalInfo object has been expanded to the exact definition.
IsOptional readOnly field is added to the MoveResourceDependency definition.

Bugs in swagger:

Fixed a bug in PUT of moveCollection which should also return 201.
The provisioningState definition of type string has been made readOnly.
The moveResources has been required property in Prepare/InitiateMove/Commit/Discard operations.
The sourceRegion and targetRegion are required property in MoveCollectionProperties.
The targetResourceName in ResourceSettings is a required property.
The sourceId is a required property was not marked correctly earlier in MoveResourceProperties.

Explanations for the breaking change in detail:

Rule	Message	Reason
❌ 1012 - RemovedResponseCode	The new version removes the response code '200' Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L56:11	The move collection creation should return 201 and not 200 this was a bug in swagger.
❌ 1026 - TypeChanged	The new version has a different type 'array' than the previous one 'object'. New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1936:9 Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1874:9	The additionalInfo was kept as object as a placeholder, and now have expanded to the correct service result.
❌ 1026 - TypeChanged	The new version has a different type 'array' than the previous one 'object'. New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1936:9 Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1874:9	same-as-above
❌ 1026 - TypeChanged	The new version has a different type 'array' than the previous one 'object'. New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1936:9 Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1874:9	same-as-above
❌ 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1201:9 Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1181:9	Have made the referenced definition of type string as read-only.
❌ 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1299:9 Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1266:9	Have made the referenced definition of type string as read-only.
❌ 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1048:5 Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1036:5	Bug in swagger: The provisioning state is read-only and not something which user can modify.
❌ 1034 - AddedRequiredProperty	The new version has new required property 'moveResources' that was not found in the old version. New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L341:13 Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L341:13	Bug in swagger: The moveResources is a required property was not marked correctly earlier.
❌ 1034 - AddedRequiredProperty	The new version has new required property 'moveResources' that was not found in the old version. New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L406:13 Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L406:13	Bug in swagger: The moveResources is a required property was not marked correctly earlier.
❌ 1034 - AddedRequiredProperty	The new version has new required property 'moveResources' that was not found in the old version. New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L471:13 Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L471:13	Bug in swagger: The moveResources is a required property was not marked correctly earlier.
❌ 1034 - AddedRequiredProperty	The new version has new required property 'targetResourceName' that was not found in the old version. New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1217:9 Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1197:9	Bug in swagger: The targetResourceName in ResourceSettings is a required property.
❌ 1034 - AddedRequiredProperty	The new version has new required property 'sourceRegion, targetRegion' that was not found in the old version. New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1347:9 Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1314:9	Bug in swagger: The sourceRegion and targetRegion are required property.
❌ 1034 - AddedRequiredProperty	The new version has new required property 'targetResourceName' that was not found in the old version. New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1639:5 Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1582:5	Bug in swagger: The targetResourceName in ResourceSettings is a required property.
❌ 1034 - AddedRequiredProperty	The new version has new required property 'moveResources' that was not found in the old version. New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1437:5 Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1386:5	Bug in swagger: The moveResources is a required property was not marked correctly earlier.
❌ 1034 - AddedRequiredProperty	The new version has new required property 'sourceId' that was not found in the old version. New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1278:9 Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1249:9	Bug in swagger: The sourceId is a required property was not marked correctly earlier.
❌ 1034 - AddedRequiredProperty	The new version has new required property 'moveResources' that was not found in the old version. New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L276:13 Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L276:13	Bug in swagger: The moveResources is a required property was not marked correctly earlier.
❌ 1034 - AddedRequiredProperty	The new version has new required property 'sourceId' that was not found in the old version. New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1194:5 Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1177:5	Bug in swagger: The sourceId is a required property was not marked correctly earlier.
❌ 1034 - AddedRequiredProperty	The new version has new required property 'sourceRegion, targetRegion' that was not found in the old version. New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1283:5 Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1254:5	Bug in swagger: The sourceRegion and targetRegion are required property was not marked correctly earlier.
❌ 1034 - AddedRequiredProperty	The new version has new required property 'moveResources' that was not found in the old version. New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1368:5 Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1335:5	Bug in swagger: The moveResources is a required property was not marked correctly earlier.
❌ 1034 - AddedRequiredProperty	The new version has new required property 'moveResources' that was not found in the old version. New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1391:5 Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1352:5	Bug in swagger: The moveResources is a required property was not marked correctly earlier.
❌ 1034 - AddedRequiredProperty	The new version has new required property 'moveResources' that was not found in the old version. New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1414:5 Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1369:5	Bug in swagger: The moveResources is a required property was not marked correctly earlier.
❌ 1041 - AddedPropertyInResponse	The new version has a new property 'isOptional' in response that was not found in the old version. New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1133:7 Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1120:7	This isOptional field has been added recently as part of public preview changes.

PhoenixHe-NV · 2020-08-17T05:21:09Z

@innosam Your go generation failed. @ArcturusZhang for more comments

ArcturusZhang · 2020-08-17T05:23:17Z

Hi to resolve the go SDK generation issue, could you please also change the namespace and output folder in this file?
You could do it by referencing the changes to readme.go.md in this PR, or you could also ignore this issue and after that PR is merged, merging back from master would automatically resolve the go SDK generation issue

PhoenixHe-NV · 2020-08-17T05:25:21Z

Thanks @ArcturusZhang and @innosam . Merge.

1. Support to pass source id in Prepare/Move/Commit/Discard operations. 2. Define the additinal error information schema. 3. Expose the read only source settings. 4. Few fixes in marking the properties readonly/mandatory as appropriate. Co-authored-by: Harkirat Singh <[email protected]>

openapi-assignment-bot bot assigned PhoenixHe-NV Aug 7, 2020

innosam force-pushed the hsingh/publicpreviewdelta branch from 6fe592c to 5162774 Compare August 10, 2020 08:50

innosam changed the title ~~Additional improvements for Public Preview~~ Fixed and additional improvements for Public Preview Aug 10, 2020

innosam changed the title ~~Fixed and additional improvements for Public Preview~~ Fixes and additional improvements for Public Preview Aug 10, 2020

innosam force-pushed the hsingh/publicpreviewdelta branch from 5162774 to 2a25935 Compare August 11, 2020 12:50

innosam force-pushed the hsingh/publicpreviewdelta branch from 2a25935 to 653938d Compare August 11, 2020 12:58

openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 11, 2020

innosam removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 11, 2020

innosam force-pushed the hsingh/publicpreviewdelta branch from 653938d to 4459e90 Compare August 11, 2020 13:04

innosam force-pushed the hsingh/publicpreviewdelta branch from 4459e90 to 342301c Compare August 11, 2020 13:17

innosam force-pushed the hsingh/publicpreviewdelta branch from 342301c to b918654 Compare August 11, 2020 13:23

innosam requested a review from pilor August 11, 2020 18:11

innosam force-pushed the hsingh/publicpreviewdelta branch from a058510 to 6520fe0 Compare August 11, 2020 20:48

innosam requested a review from PhoenixHe-NV August 11, 2020 20:49

innosam force-pushed the hsingh/publicpreviewdelta branch from 6520fe0 to ded8339 Compare August 11, 2020 20:54

PhoenixHe-NV suggested changes Aug 13, 2020

View reviewed changes

PhoenixHe-NV added the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label Aug 13, 2020

innosam requested a review from PhoenixHe-NV August 14, 2020 04:26

innosam force-pushed the hsingh/publicpreviewdelta branch from ded8339 to 7a7b66b Compare August 14, 2020 11:07

innosam force-pushed the hsingh/publicpreviewdelta branch from 7a7b66b to 7033ff0 Compare August 14, 2020 11:22

openapi-sdkautomation bot mentioned this pull request Aug 14, 2020

[AutoPR regionmove] [2019-10-01-preview] Fixes and additional improvements for Public Preview AzureSDKAutomation/azure-resource-manager-schemas#32

Closed

Additional improvements for Public Preview

91cbf78

1. Support to pass source id in Prepare/Move/Commit/Discard operations. 2. Define the additinal error information schema. 3. Expose the read only source settings. 4. Few fixes in marking the properties readonly/mandatory as appropriate.

innosam force-pushed the hsingh/publicpreviewdelta branch from 7033ff0 to 91cbf78 Compare August 14, 2020 11:46

innosam removed the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label Aug 14, 2020

PhoenixHe-NV approved these changes Aug 17, 2020

View reviewed changes

PhoenixHe-NV added the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label Aug 17, 2020

PhoenixHe-NV added Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 and removed Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review labels Aug 17, 2020

PhoenixHe-NV merged commit 96782ca into Azure:master Aug 17, 2020

[2019-10-01-preview] Fixes and additional improvements for Public Preview #10382

[2019-10-01-preview] Fixes and additional improvements for Public Preview #10382

Uh oh!

Conversation

innosam commented Aug 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

Uh oh!

openapi-pipeline-app bot commented Aug 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

[Staging] Swagger Validation Report

Uh oh!

azure-pipelines bot commented Aug 7, 2020

Uh oh!

openapi-sdkautomation bot commented Aug 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java - Release

Uh oh!

openapi-sdkautomation bot commented Aug 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go - Release

Uh oh!

openapi-sdkautomation bot commented Aug 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js - Release

Uh oh!

openapi-sdkautomation bot commented Aug 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Azure CLI Extension Generation - Release

Uh oh!

openapi-sdkautomation bot commented Aug 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python - Release

Uh oh!

azuresdkci commented Aug 7, 2020

Uh oh!

openapi-sdkautomation bot commented Aug 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Trenton Generation - Release

Uh oh!

openapi-sdkautomation bot commented Aug 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net - Release

Uh oh!

PhoenixHe-NV commented Aug 10, 2020

Uh oh!

azure-pipelines bot commented Aug 10, 2020

Uh oh!

openapi-sdkautomation bot commented Aug 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python-track2 - Release

Uh oh!

azure-pipelines bot commented Aug 10, 2020

Uh oh!

azure-pipelines bot commented Aug 11, 2020

Uh oh!

azure-pipelines bot commented Aug 11, 2020

Uh oh!

azure-pipelines bot commented Aug 11, 2020

Uh oh!

azure-pipelines bot commented Aug 11, 2020

Uh oh!

azure-pipelines bot commented Aug 11, 2020

Uh oh!

azure-pipelines bot commented Aug 11, 2020

Uh oh!

azure-pipelines bot commented Aug 11, 2020

Uh oh!

azure-pipelines bot commented Aug 11, 2020

Uh oh!

PhoenixHe-NV left a comment

Choose a reason for hiding this comment

Uh oh!

PhoenixHe-NV Aug 13, 2020

Choose a reason for hiding this comment

Uh oh!

innosam Aug 14, 2020

Choose a reason for hiding this comment

innosam commented Aug 7, 2020 •

edited

Loading

openapi-pipeline-app bot commented Aug 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 10, 2020 •

edited

Loading

innosam Aug 14, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 14, 2020 •

edited

Loading

innosam commented Aug 14, 2020 •

edited

Loading