Adding Untracked Public Maintenance Config Resource Type #10281

sotaneja · 2020-07-28T20:00:22Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
(API is not available yet so these are not breaking changes)
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

openapi-pipeline-app · 2020-07-28T20:00:27Z

[Staging] Swagger Validation Report

️❌BreakingChange: 3 Errors, 0 Warnings [Detail] [Expand]

Rule	Message
`❌` 1020 - AddedEnumValue	The new version is adding enum value(s) 'SQLDB, SQLManagedInstance' from the old version. New: Microsoft.Maintenance/preview/2020-07-01-preview/Maintenance.json#L1495:9 Old: Microsoft.Maintenance/preview/2020-07-01-preview/Maintenance.json#L1405:9
`❌` 1020 - AddedEnumValue	The new version is adding enum value(s) 'SQLDB, SQLManagedInstance' from the old version. New: Microsoft.Maintenance/preview/2020-07-01-preview/Maintenance.json#L1672:9 Old: Microsoft.Maintenance/preview/2020-07-01-preview/Maintenance.json#L1568:9
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'visibility' in response that was not found in the old version. New: Microsoft.Maintenance/preview/2020-07-01-preview/Maintenance.json#L1483:7 Old: Microsoft.Maintenance/preview/2020-07-01-preview/Maintenance.json#L1393:7

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️️✔️Avocado [Detail]

 Validation passes for Avocado.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-07-28T20:00:40Z

Azure Pipelines successfully started running 1 pipeline(s).

azuresdkci · 2020-07-28T20:01:26Z

Can one of the admins verify this patch?

openapi-sdkautomation · 2020-07-28T20:02:10Z

azure-sdk-for-net - Release

⌛ Pending...

openapi-sdkautomation · 2020-07-28T20:02:10Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-07-28T20:02:14Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 96a06e7 with merge commit 5699b02. SDK Automation 13.0.17.20200619.4

️✔️azure-mgmt-maintenance [View full logs] [Release SDK Changes]

[build_conf] INFO:packaging_tools:Building template azure-mgmt-maintenance
[build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
[build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
[build_conf] INFO:packaging_tools:Template done azure-mgmt-maintenance
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[ChangeLog] Size of delta 11.936% size of original (original: 14385 chars, delta: 1717 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog]   - Model MaintenanceConfiguration has a new parameter duration
[ChangeLog]   - Model MaintenanceConfiguration has a new parameter recur_every
[ChangeLog]   - Model MaintenanceConfiguration has a new parameter visibility
[ChangeLog]   - Model MaintenanceConfiguration has a new parameter time_zone
[ChangeLog]   - Model MaintenanceConfiguration has a new parameter expiration_date_time
[ChangeLog]   - Model MaintenanceConfiguration has a new parameter start_date_time
[ChangeLog]   - Added operation group PublicMaintenanceConfigurationsOperations

openapi-sdkautomation · 2020-07-28T20:07:43Z

azure-sdk-for-go - Release

⌛ Pending...

openapi-sdkautomation · 2020-07-28T20:08:03Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-07-28T20:08:43Z

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-07-28T20:09:12Z

azure-sdk-for-java - Release

⌛ Pending...

openapi-sdkautomation · 2020-07-28T20:09:29Z

azure-sdk-for-js - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azure-pipelines · 2020-07-29T16:57:24Z

Azure Pipelines successfully started running 1 pipeline(s).

ArcturusZhang · 2020-07-30T02:42:03Z

Approved breaking changes since the author claims

(API is not available yet so these are not breaking changes)

* Adding Untracked Public Maintenance Config Resource Type * Fixing linter checks

Adding Untracked Public Maintenance Config Resource Type

79aa694

openapi-assignment-bot bot assigned ArcturusZhang Jul 28, 2020

openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 28, 2020

Fixing linter checks

96a06e7

openapi-sdkautomation bot mentioned this pull request Jul 29, 2020

[AutoPR azure-mgmt-maintenance] Adding Untracked Public Maintenance Config Resource Type AzureSDKAutomation/azure-sdk-for-python#1669

Closed

ArcturusZhang added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jul 30, 2020

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 30, 2020

ArcturusZhang approved these changes Jul 31, 2020

View reviewed changes

ArcturusZhang merged commit 5699b02 into Azure:master Jul 31, 2020

sotaneja mentioned this pull request Jul 31, 2020

Adding new Resource Public maintenance configurations and GET/LISTAPI Azure/azure-sdk-for-net#13873

Merged

00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020

Adding Untracked Public Maintenance Config Resource Type (Azure#10281)

0d4fcc4

* Adding Untracked Public Maintenance Config Resource Type * Fixing linter checks

Adding Untracked Public Maintenance Config Resource Type #10281

Adding Untracked Public Maintenance Config Resource Type #10281

Uh oh!

Conversation

sotaneja commented Jul 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

Uh oh!

openapi-pipeline-app bot commented Jul 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

[Staging] Swagger Validation Report

Uh oh!

azure-pipelines bot commented Jul 28, 2020

Uh oh!

azuresdkci commented Jul 28, 2020

Uh oh!

openapi-sdkautomation bot commented Jul 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net - Release

Uh oh!

openapi-sdkautomation bot commented Jul 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Trenton Generation - Release

Uh oh!

openapi-sdkautomation bot commented Jul 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python - Release

Uh oh!

openapi-sdkautomation bot commented Jul 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go - Release

Uh oh!

openapi-sdkautomation bot commented Jul 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python-track2 - Release

Uh oh!

openapi-sdkautomation bot commented Jul 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Azure CLI Extension Generation - Release

Uh oh!

openapi-sdkautomation bot commented Jul 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java - Release

Uh oh!

openapi-sdkautomation bot commented Jul 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js - Release

Uh oh!

azure-pipelines bot commented Jul 29, 2020

Uh oh!

ArcturusZhang commented Jul 30, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sotaneja commented Jul 28, 2020 •

edited

Loading

openapi-pipeline-app bot commented Jul 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 28, 2020 •

edited

Loading