Skip to content

Storage/sealblob #10201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gapra-msft merged 4 commits into from
Jul 20, 2020
Merged

Storage/sealblob #10201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
157ca01
removed source if tags from start copy from url
gapra-msft Jul 10, 2020
7ea382d
Added seal blob changes
gapra-msft Jul 20, 2020
0d34db6
Merge branch 'storage-dataplane-preview' into storage/sealblob
gapra-msft Jul 20, 2020
9ef4535
made changes to seal blob for 74
gapra-msft Jul 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions specification/storage/data-plane/Microsoft.BlobStorage/preview/2019-12-12/blob.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6125,9 +6125,6 @@
},
{
"$ref": "#/parameters/BlobTagsHeader"
},
Copy link
Member Author

@gapra-msft gapra-msft Jul 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to do make these changes for 74

{
"$ref": "#/parameters/SealBlob"
}
],
"responses": {
Expand Down Expand Up @@ -9651,7 +9648,8 @@
"type": "string",
"format": "date-time-rfc1123"
},
"IsSealed": {
"Sealed": {
"x-ms-client-name": "IsSealed",
"type": "boolean"
},
"RehydratePriority": {
Expand Down
6 changes: 2 additions & 4 deletions specification/storage/data-plane/Microsoft.BlobStorage/preview/2020-02-10/blob.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6125,9 +6125,6 @@
},
{
"$ref": "#/parameters/BlobTagsHeader"
},
{
"$ref": "#/parameters/SealBlob"
Copy link
Contributor

@xiafu-msft xiafu-msft Jul 20, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we also want to remove SealBlob?

azure-rest-api-specs/specification/storage/data-plane/Microsoft.BlobStorage/preview/2020-02-10/blob.json

Lines 11789 to 11797 in 9ef4535

"SealBlob": {
"name": "x-ms-seal-blob",
"x-ms-client-name": "SealBlob",
"in": "header",
"required": false,
"type": "boolean",
"x-ms-parameter-location": "method",
"description": "Overrides the sealed state of the destination blob. Service version 2019-12-12 and newer."
},

Copy link
Member Author

@gapra-msft gapra-msft Jul 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, seal blob is used in some other APIs still

Copy link
Contributor

@xiafu-msft xiafu-msft Jul 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right!!!

}
],
"responses": {
Expand Down Expand Up @@ -9651,7 +9648,8 @@
"type": "string",
"format": "date-time-rfc1123"
},
"IsSealed": {
"Sealed": {
"x-ms-client-name": "IsSealed",
"type": "boolean"
},
"RehydratePriority": {
Expand Down