From b1776f08b09e55e13c388bc973e4ebf22fe079d5 Mon Sep 17 00:00:00 2001 From: Dongwei Wang Date: Wed, 15 Jul 2020 04:14:43 -0700 Subject: [PATCH 1/2] Add SQL DW Gen3 --- .../2020-04-01-preview/sqlDatabase.json | 2 +- .../preview/2020-04-01-preview/sqlPool.json | 36 +++++++++---------- .../synapse/resource-manager/readme.md | 11 +++--- 3 files changed, 25 insertions(+), 24 deletions(-) diff --git a/specification/synapse/resource-manager/Microsoft.Synapse/preview/2020-04-01-preview/sqlDatabase.json b/specification/synapse/resource-manager/Microsoft.Synapse/preview/2020-04-01-preview/sqlDatabase.json index efff72a45220..1730cb88fb49 100644 --- a/specification/synapse/resource-manager/Microsoft.Synapse/preview/2020-04-01-preview/sqlDatabase.json +++ b/specification/synapse/resource-manager/Microsoft.Synapse/preview/2020-04-01-preview/sqlDatabase.json @@ -2,7 +2,7 @@ "swagger": "2.0", "info": { "version": "2020-04-01-preview", - "title": "SynapseSqlManagementClient", + "title": "SynapseSqlV3ManagementClient", "description": "The Azure Synapse SQL management API provides a RESTful set of web APIs that interact with Azure Synapse SQL services to manage your resources. The API enables users to create, retrieve, update, and delete SqlPools, SqlDatabases, and other entities." }, "host": "management.azure.com", diff --git a/specification/synapse/resource-manager/Microsoft.Synapse/preview/2020-04-01-preview/sqlPool.json b/specification/synapse/resource-manager/Microsoft.Synapse/preview/2020-04-01-preview/sqlPool.json index cba91ee61f96..300ebf52cb3f 100644 --- a/specification/synapse/resource-manager/Microsoft.Synapse/preview/2020-04-01-preview/sqlPool.json +++ b/specification/synapse/resource-manager/Microsoft.Synapse/preview/2020-04-01-preview/sqlPool.json @@ -2,7 +2,7 @@ "swagger": "2.0", "info": { "version": "2020-04-01-preview", - "title": "SynapseSqlManagementClient", + "title": "SynapseSqlV3ManagementClient", "description": "The Azure Synapse SQL management API provides a RESTful set of web APIs that interact with Azure Synapse SQL services to manage your resources. The API enables users to create, retrieve, update, and delete SqlPools, SqlDatabases, and other entities." }, "host": "management.azure.com", @@ -19,10 +19,10 @@ "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/sqlPools/{sqlPoolName}": { "get": { "tags": [ - "SqlPools" + "SqlPoolsV3" ], "description": "Gets a SqlPool.", - "operationId": "SqlPools_Get", + "operationId": "SqlPoolsV3_Get", "parameters": [ { "$ref": "../../../../../common-types/resource-management/v1/types.json#/parameters/ResourceGroupNameParameter" @@ -44,7 +44,7 @@ "200": { "description": "Successfully retrieved the specified SqlPool.", "schema": { - "$ref": "#/definitions/SqlPool" + "$ref": "#/definitions/SqlPoolV3" } }, "default": { @@ -62,10 +62,10 @@ }, "put": { "tags": [ - "SqlPools" + "SqlPoolsV3" ], "description": "Creates a new SqlPool or updates an existing SqlPool.", - "operationId": "SqlPools_CreateOrUpdate", + "operationId": "SqlPoolsV3_CreateOrUpdate", "parameters": [ { "$ref": "../../../../../common-types/resource-management/v1/types.json#/parameters/ResourceGroupNameParameter" @@ -82,7 +82,7 @@ "description": "The requested SqlPool resource state.", "required": true, "schema": { - "$ref": "#/definitions/SqlPool" + "$ref": "#/definitions/SqlPoolV3" } }, { @@ -96,7 +96,7 @@ "200": { "description": "Successfully updated the SqlPool.", "schema": { - "$ref": "#/definitions/SqlPool" + "$ref": "#/definitions/SqlPoolV3" } }, "202": { @@ -105,7 +105,7 @@ "201": { "description": "Successfully created the SqlPool.", "schema": { - "$ref": "#/definitions/SqlPool" + "$ref": "#/definitions/SqlPoolV3" } }, "default": { @@ -124,10 +124,10 @@ }, "delete": { "tags": [ - "SqlPools" + "SqlPoolsV3" ], "description": "Deletes the SqlPool.", - "operationId": "SqlPools_Delete", + "operationId": "SqlPoolsV3_Delete", "parameters": [ { "$ref": "../../../../../common-types/resource-management/v1/types.json#/parameters/ResourceGroupNameParameter" @@ -171,10 +171,10 @@ }, "patch": { "tags": [ - "SqlPools" + "SqlPoolsV3" ], "description": "Updates an existing sqlpool.", - "operationId": "SqlPools_Update", + "operationId": "SqlPoolsV3_Update", "parameters": [ { "$ref": "../../../../../common-types/resource-management/v1/types.json#/parameters/SubscriptionIdParameter" @@ -205,7 +205,7 @@ "200": { "description": "Successfully updated the SqlPool.", "schema": { - "$ref": "#/definitions/SqlPool" + "$ref": "#/definitions/SqlPoolV3" } }, "202": { @@ -229,10 +229,10 @@ "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/sqlPools": { "get": { "tags": [ - "SqlPools" + "SqlPoolsV3" ], "description": "Gets a list of sql pools.", - "operationId": "SqlPools_ListByWorkspace", + "operationId": "SqlPoolsV3_ListByWorkspace", "parameters": [ { "$ref": "../../../../../common-types/resource-management/v1/types.json#/parameters/SubscriptionIdParameter" @@ -318,7 +318,7 @@ } } }, - "SqlPool": { + "SqlPoolV3": { "description": "A sql pool resource.", "required": [ "location" @@ -381,7 +381,7 @@ "description": "Array of results.", "type": "array", "items": { - "$ref": "#/definitions/SqlPool" + "$ref": "#/definitions/SqlPoolV3" }, "readOnly": true }, diff --git a/specification/synapse/resource-manager/readme.md b/specification/synapse/resource-manager/readme.md index 870c1484aa8c..17129e505e75 100644 --- a/specification/synapse/resource-manager/readme.md +++ b/specification/synapse/resource-manager/readme.md @@ -24,7 +24,6 @@ To see additional help and options, run: These are the global settings for the Azure Synapse Analytics API. ``` yaml -title: SynapseManagementClient description: Azure Synapse Analytics Management Client openapi-type: arm azure-arm: true @@ -49,13 +48,12 @@ input-file: - Microsoft.Synapse/preview/2019-06-01-preview/privatelinkhub.json ``` -### Tag: package-2020-04-01-preview +### Tag: package-sqlGen3-2020-04-01-preview -These settings apply only when `--tag=package-2020-04-01-preview` is specified on the command line. +These settings apply only when `--tag=package-sqlGen3-2020-04-01-preview` is specified on the command line. -``` yaml $(tag) == 'package-2020-04-01-preview' +``` yaml $(tag) == 'package-sqlGen3-2020-04-01-preview' input-file: -- Microsoft.Synapse/preview/2020-04-01-preview/operations.json - Microsoft.Synapse/preview/2020-04-01-preview/sqlPool.json - Microsoft.Synapse/preview/2020-04-01-preview/sqlDatabase.json @@ -114,6 +112,9 @@ csharp: namespace: Microsoft.Azure.Management.Synapse output-folder: $(csharp-sdks-folder)/synapse/Microsoft.Azure.Management.Synapse/src/Generated clear-output-folder: true +batch: + - tag: package-2019-06-01-preview + - tag: package-sqlGen3-2020-04-01-preview ``` ## Go From 5db19b2b87136067b5165578c3aba82502db5e12 Mon Sep 17 00:00:00 2001 From: Dongwei Wang Date: Tue, 21 Jul 2020 13:12:12 +0800 Subject: [PATCH 2/2] Add suppression rule for false alert --- specification/synapse/resource-manager/readme.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/specification/synapse/resource-manager/readme.md b/specification/synapse/resource-manager/readme.md index 17129e505e75..e5e8ab6fbe1c 100644 --- a/specification/synapse/resource-manager/readme.md +++ b/specification/synapse/resource-manager/readme.md @@ -73,6 +73,14 @@ directive: reason: Does not apply to sqlPool and bigDataPool as they are nested tracked resources - suppress: TrackedResourceListBySubscription reason: Does not apply to sqlPool and bigDataPool as they are nested tracked resources + - suppress: OperationsAPIImplementation + reason: We do have a operations api as "/providers/Microsoft.Synapse/operations" + from: sqlDatabase.json + where: $.paths + - suppress: OperationsAPIImplementation + reason: We do have a operations api as "/providers/Microsoft.Synapse/operations" + from: sqlPool.json + where: $.paths ``` ---