Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to clear RollingUpgradePolicy in Virtual Machine Scaleset #3751

Open
JunyiYi opened this issue Aug 28, 2018 · 5 comments
Open

Unable to clear RollingUpgradePolicy in Virtual Machine Scaleset #3751

JunyiYi opened this issue Aug 28, 2018 · 5 comments
Labels
Compute Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@JunyiYi
Copy link

JunyiYi commented Aug 28, 2018

RollingUpgradePolicy is an optional parameter in Virtual Machine Scaleset. But I'm not able to remove it once it is set. I tried using null, using empty object {}, I also tried pass nothing, but no luck to succeed.

Thanks.

@holderbaum
Copy link

Hello Azure Team,

apparently, this issue is hindering the terraform development. Right now, there is no way to configure a rolling update for VMSS via terraform. Since the rolling update is quite a central and useful feature of the scale sets, this is a big issue for us.

Is there any estimate when this issue will be fixed? 😃

Cheers
Jakob

@anuchandy
Copy link
Member

Just a thought – the documentation https://docs.microsoft.com/en-us/rest/api/compute/virtualmachinescalesets/createorupdate#rollingupgradepolicy describes the default values for various properties of RollingUpgradePolicy, i.e. it describes the value service uses if we create a VMSS without explicitly setting RollingUpgradePolicy.

Given above documentation, If someone want to remove RollingUpgradePolicy it means they want to rollback to the default value that service uses, right? If so – can we explicitly pass the default values that documentation describes & work around for now while compute team looking into it?

new RollingUpgradePolicy {
maxBatchInstancePercent: 20,
maxUnhealthyInstancePercent: 20,
maxUnhealthyUpgradedInstancePercent: 20,
pauseTimeBetweenBatches: 0
};

@JunyiYi
Copy link
Author

JunyiYi commented Sep 14, 2018

Thanks @anuchandy for the workaround.
It might be a good idea for users who wants to remove the value.
But this method will affect users who initially does not set the value since we will always set the default values for them in this workaround. And finally Terraform will report to them that their VMSS is changed (new properties added).

@bsiegel bsiegel added the Service Attention Workflow: This issue is responsible by Azure service team. label Sep 26, 2018
@salameer
Copy link
Member

@anuchandy, is this still an issue based of JuniY? if so please add "Service attention" label to it

@salameer salameer removed the Service Attention Workflow: This issue is responsible by Azure service team. label Oct 25, 2018
@JackTn JackTn added the Service Attention Workflow: This issue is responsible by Azure service team. label Jan 8, 2021
@ghost
Copy link

ghost commented Jan 8, 2021

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @Drewm3, @avirishuv, @Vaibhav-Agar, @amjads1.

Issue Details

RollingUpgradePolicy is an optional parameter in Virtual Machine Scaleset. But I'm not able to remove it once it is set. I tried using null, using empty object {}, I also tried pass nothing, but no luck to succeed.

Thanks.

Author: JunyiYi
Assignees: -
Labels:

Compute, Service Attention

Milestone: -

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compute Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Development

No branches or pull requests

6 participants