Skip to content

Commit d87cfa4

Browse files
author
Eduardo Coronado
committed
Address PR comments
1 parent 7de2dcf commit d87cfa4

File tree

6 files changed

+4
-116
lines changed

6 files changed

+4
-116
lines changed

specification/synapse/resource-manager/Microsoft.Synapse/preview/2019-06-01-preview/examples/CreateOrUpdateKey.json

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,6 @@
99
"properties": {
1010
"isActiveCMK": true,
1111
"keyVaultUrl": "https://vault.azure.net/keys/somesecret"
12-
},
13-
"location": "East US",
14-
"tags": {
15-
"key": "value"
1612
}
1713
}
1814
},
@@ -21,14 +17,10 @@
2117
"body": {
2218
"id": "/subscriptions/01234567-89ab-4def-0123-456789abcdef/resourceGroups/ExampleResourceGroup/providers/Microsoft.Synapse/workspaces/ExampleWorkspace/keys/somekey",
2319
"type": "Microsoft.Synapse/workspaces/keys",
24-
"location": "East US",
2520
"name": "somekey",
2621
"properties": {
2722
"isActiveCMK": true,
2823
"keyVaultUrl": "https://vault.azure.net/keys/somesecret"
29-
},
30-
"tags": {
31-
"key": "value"
3224
}
3325
}
3426
},

specification/synapse/resource-manager/Microsoft.Synapse/preview/2019-06-01-preview/examples/DeleteKey.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
"id": "/subscriptions/01234567-89ab-4def-0123-456789abcdef/resourceGroups/ExampleResourceGroup/providers/Microsoft.Synapse/workspaces/ExampleWorkspace/keys/somekey",
1313
"type": "Microsoft.Synapse/workspaces/keys",
1414
"name": "somekey",
15-
"location": "West US 2",
1615
"properties": {
1716
"isActiveCMK": true,
1817
"keyVaultUrl": "https://vault.azure.net/keys/key1"

specification/synapse/resource-manager/Microsoft.Synapse/preview/2019-06-01-preview/examples/GetKey.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,10 @@
1212
"id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/ExampleResourceGroup/providers/Microsoft.Synapse/workspaces/ExampleWorkspace/keys/somekey",
1313
"name": "somekey",
1414
"type": "Microsoft.Synapse/workspaces/keys",
15-
"location": "Japan East",
1615
"properties": {
1716
"isActiveCMK": true,
1817
"keyVaultUrl": "https://vault.azure.net/keys/key1"
19-
},
20-
"tags": {}
18+
}
2119
}
2220
}
2321
}

specification/synapse/resource-manager/Microsoft.Synapse/preview/2019-06-01-preview/examples/ListKeysInWorkspace.json

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,23 +13,19 @@
1313
"id": "/subscriptions/01234567-89ab-4def-0123-456789abcdef/resourceGroups/ExampleResourceGroup/providers/Microsoft.Synapse/workspaces/ExampleWorkspace/keys/key1",
1414
"name": "key1",
1515
"type": "Microsoft.Synapse/workspaces/keys",
16-
"location": "Japan East",
1716
"properties": {
1817
"keyVaultUrl": "https://vault.azure.net/keys/somesecret1",
1918
"isActiveCMK": false
20-
},
21-
"tags": {}
19+
}
2220
},
2321
{
2422
"id": "/subscriptions/01234567-89ab-4def-0123-456789abcdef/resourceGroups/ExampleResourceGroup/providers/Microsoft.Synapse/workspaces/ExampleWorkspace/keys/key2",
2523
"name": "key2",
2624
"type": "Microsoft.Synapse/workspaces/keys",
27-
"location": "Japan East",
2825
"properties": {
2926
"keyVaultUrl": "https://vault.azure.net/keys/somesecret2",
3027
"isActiveCMK": true
31-
},
32-
"tags": {}
28+
}
3329
}
3430
]
3531
}

specification/synapse/resource-manager/Microsoft.Synapse/preview/2019-06-01-preview/examples/UpdateKey.json

Lines changed: 0 additions & 27 deletions
This file was deleted.

specification/synapse/resource-manager/Microsoft.Synapse/preview/2019-06-01-preview/keys.json

Lines changed: 1 addition & 71 deletions
Original file line numberDiff line numberDiff line change
@@ -229,63 +229,6 @@
229229
"$ref": "./examples/DeleteKey.json"
230230
}
231231
}
232-
},
233-
"patch": {
234-
"operationId": "Keys_Patch",
235-
"description": "Patch a workspace key",
236-
"tags": [
237-
"Keys"
238-
],
239-
"deprecated": false,
240-
"parameters": [
241-
{
242-
"$ref": "../../../../../common-types/resource-management/v1/types.json#/parameters/ApiVersionParameter"
243-
},
244-
{
245-
"$ref": "../../../../../common-types/resource-management/v1/types.json#/parameters/SubscriptionIdParameter"
246-
},
247-
{
248-
"$ref": "../../../../../common-types/resource-management/v1/types.json#/parameters/ResourceGroupNameParameter"
249-
},
250-
{
251-
"$ref": "./workspace.json#/parameters/workspaceNameParameter"
252-
},
253-
{
254-
"$ref": "#/parameters/keyNameParameter"
255-
},
256-
{
257-
"schema": {
258-
"$ref": "#/definitions/KeyPatchInfo"
259-
},
260-
"in": "body",
261-
"name": "keyProperties",
262-
"required": true,
263-
"description": "Key patch request properties"
264-
}
265-
],
266-
"responses": {
267-
"200": {
268-
"description": "OK",
269-
"schema": {
270-
"$ref": "#/definitions/Key"
271-
}
272-
},
273-
"default": {
274-
"schema": {
275-
"$ref": "#/definitions/ErrorContract"
276-
},
277-
"description": "*** Error Responses: ***\n\n * 500 InternalServerError- Some error occurred while deleting Workspace Key."
278-
}
279-
},
280-
"consumes": [],
281-
"produces": [
282-
"application/json"
283-
],
284-
"x-ms-examples": {
285-
"Patch a workspace key": {
286-
"$ref": "./examples/UpdateKey.json"
287-
}
288-
}
289232
}
290233
}
291234
},
@@ -341,7 +284,7 @@
341284
"type": "object",
342285
"allOf": [
343286
{
344-
"$ref": "../../../../../common-types/resource-management/v1/types.json#/definitions/TrackedResource"
287+
"$ref": "../../../../../common-types/resource-management/v1/types.json#/definitions/ProxyResource"
345288
}
346289
],
347290
"properties": {
@@ -352,19 +295,6 @@
352295
}
353296
}
354297
},
355-
"KeyPatchInfo": {
356-
"description": "KeyInfo patch details",
357-
"type": "object",
358-
"properties": {
359-
"tags": {
360-
"description": "Resource tags",
361-
"additionalProperties": {
362-
"type": "string"
363-
},
364-
"type": "object"
365-
}
366-
}
367-
},
368298
"KeyProperties": {
369299
"description": "Key properties",
370300
"type": "object",

0 commit comments

Comments
 (0)