Skip to content

Commit a1a1273

Browse files
author
Rajeev Vokkarne
committed
Fix merge conflict
2 parents 4878dfb + f7708b4 commit a1a1273

File tree

4,324 files changed

+550223
-26585
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

4,324 files changed

+550223
-26585
lines changed

.azure-pipelines-preproduction/package-lock.json

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.azure-pipelines-preproduction/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@
2525
"ts-node": "^8.1.0",
2626
"tslib": "^1.10.0",
2727
"typescript": "3.5.3",
28-
"prettier": "^1.18.2"
28+
"prettier": "^1.18.2",
29+
"minimist": "^1.2.3"
2930
},
3031
"homepage": "https://github.com/azure/azure-rest-api-specs",
3132
"repository": {

.azure-pipelines/BreakingChange.yml

Lines changed: 0 additions & 13 deletions
This file was deleted.

.azure-pipelines/SDKAutomation.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,8 @@ jobs:
4242
SDK_REPO_NAME: azure-sdk-for-go
4343
Trenton:
4444
SDK_REPO_NAME: azure-sdk-for-trenton
45+
Schema:
46+
SDK_REPO_NAME: azure-resource-manager-schemas
4547
steps:
4648
- checkout: none
4749
- script: |
Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
schedules:
2+
- cron: "0 0 * * *"
3+
displayName: Daily build
4+
branches:
5+
include:
6+
- master
7+
always: true
8+
9+
pool:
10+
vmImage: 'Ubuntu-16.04'
11+
12+
variables:
13+
IMAGE_TAG_PREFIX: $[format('1.0.{0:HHm}', pipeline.startTime)]
14+
15+
steps:
16+
- task: Docker@2
17+
displayName: Login to production ACR
18+
inputs:
19+
command: login
20+
containerRegistry: $(CONTAINER_REGISTRY_SERVICE_CONNECTION)
21+
22+
- task: Docker@2
23+
displayName: Login to dogfood ACR
24+
inputs:
25+
command: login
26+
containerRegistry: $(DOGFOOD_CONTAINER_REGISTRY_SERVICE_CONNECTION)
27+
28+
- task: CopyFiles@2
29+
inputs:
30+
SourceFolder: $(Build.SourcesDirectory)
31+
contents: .git/**
32+
targetFolder: $(Build.SourcesDirectory)/scripts/datacontainer
33+
34+
- task: Docker@2
35+
displayName: Build and Push
36+
inputs:
37+
command: buildAndPush
38+
Dockerfile: scripts/datacontainer/Dockerfile
39+
repository: $(CONTAINER_REGISTRY_REPOSITORY_NAME)
40+
tags: |
41+
latest
42+
$(IMAGE_TAG_PREFIX)$(Build.BuildNumber)

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 17 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,19 +2,27 @@
22
</i>
33

44
### Contribution checklist:
5+
- [ ] I commit to follow the [Breaking Change Policy](http://aka.ms/bcforapi) of “no breaking changes
56
- [ ] I have reviewed the [documentation](https://aka.ms/ameonboard) for the workflow.
6-
- [ ] [Validation tools](https://aka.ms/swaggertools) were run on swagger spec(s) and have all been fixed in this PR. [How to fix?](https://aka.ms/ci-fix)
7+
- [ ] [Validation tools](https://aka.ms/swaggertools) were run on swagger spec(s) and errors have all been fixed in this PR. [How to fix?](https://aka.ms/ci-fix)
78

89
If any further question about AME onboarding or validation tools, please view the [FAQ](https://aka.ms/faqinprreview).
910

1011
### ARM API Review Checklist
11-
- [ ] Service team MUST add the "**WaitForARMFeedback**" label if the management plane API changes fall into one of the below categories.
12-
- adding/removing APIs.
13-
- adding/removing properties.
14-
- adding/removing API-version.
15-
- adding a new service in Azure.
12+
- [ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
13+
- Adding new API(s)
14+
- Adding a new API version
15+
- Adding a new service
1616

17-
<i>Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.</i>
17+
- [ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (*RP Manifest Approvers* team under <ins>Azure Resource Manager service</ins>) from IcM and reach out to them.
1818

19-
- [ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
20-
Please follow the link to find more details on [API review process](https://aka.ms/SwaggerPRReview).
19+
### Breaking Change Review Checklist
20+
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the [Breaking Change Policy](http://aka.ms/bcforapi).
21+
22+
- [ ] Removing API(s) in stable version
23+
- [ ] Removing properties in stable version
24+
- [ ] Removing API version(s) in stable version
25+
- [ ] Updating API in stable version with Breaking Change Validation errors
26+
- [ ] Updating API(s) in preview over 1 year
27+
28+
Please follow the link to find more details on [PR review process](https://aka.ms/SwaggerPRReview).

.github/assignment.yml

Lines changed: 0 additions & 154 deletions
This file was deleted.

.github/issue_assignment.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
booleanFilterExpression: "needs-triage"
44
assignees:
55
- yungezz
6-
- zikalino
76
- erich-wang
87
- NullMDR
98
- raych1
@@ -20,3 +19,4 @@
2019
- qianwens
2120
- ruowan
2221
- MyronFanQiu
22+
- jianyexi

.github/pull_request_assignment.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
paths:
1414
- "specification/network/**"
1515
reviewers:
16-
- lirenhe
1716
- MyronFanQiu
1817

1918
- rule:
@@ -96,6 +95,7 @@
9695
- rule:
9796
paths:
9897
- "specification/mixedreality/**"
98+
- "specification/hdinsight/**"
9999
reviewers:
100100
- leni-msft
101101

@@ -136,7 +136,6 @@
136136
- "**"
137137
reviewers:
138138
- yungezz
139-
- zikalino
140139
- erich-wang
141140
- NullMDR
142141
- raych1
@@ -152,3 +151,4 @@
152151
- leni-msft
153152
- qianwens
154153
- ruowan
154+
- jianyexi

.github/reviewer.yml

Lines changed: 0 additions & 13 deletions
This file was deleted.

0 commit comments

Comments
 (0)