Skip to content

Commit 921c854

Browse files
gorandomPraveenkumar Ravikumar
gorandom
and
Praveenkumar Ravikumar
authored
[Hub Generated] Review request for Microsoft.Cache to add version stable/2020-12-01 (#15674)
* Fixing swagger correctness issues * reverting the newly added status code * prettier formatting * adding custom words * s360 issue fix * Fixing model validation error Co-authored-by: Praveenkumar Ravikumar <[email protected]>
1 parent 767f6ae commit 921c854

File tree

5 files changed

+172
-64
lines changed

5 files changed

+172
-64
lines changed

‎custom-words.txt‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1141,8 +1141,10 @@ mariadb
11411141
Marketo
11421142
marketplaceagreementsapi
11431143
marketplaceordering
1144+
maxclients
11441145
maxcoordinates
11451146
MAXERRORS
1147+
maxfragmentationmemory
11461148
maximumblobsize
11471149
maxmemory
11481150
maxpagesize

‎specification/redis/resource-manager/Microsoft.Cache/stable/2020-06-01/examples/RedisCacheListPrivateEndpointConnections.json‎

Lines changed: 33 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -8,40 +8,42 @@
88
},
99
"responses": {
1010
"200": {
11-
"body": [
12-
{
13-
"id": "/subscriptions/{subscriptionId}/resourceGroups/rgtest01/providers/Microsoft.Cache/Redis/cachetest01/privateEndpointConnections/pectest01",
14-
"name": "pectest01",
15-
"type": "Microsoft.Cache/Redis/privateEndpointConnections",
16-
"properties": {
17-
"provisioningState": "Succeeded",
18-
"privateEndpoint": {
19-
"id": "/subscriptions/{subscriptionId}/resourceGroups/rgtest01/providers/Microsoft.Network/privateEndpoints/petest01"
20-
},
21-
"privateLinkServiceConnectionState": {
22-
"status": "Approved",
23-
"description": "Auto-Approved",
24-
"actionsRequired": "None"
11+
"body": {
12+
"value": [
13+
{
14+
"id": "/subscriptions/{subscriptionId}/resourceGroups/rgtest01/providers/Microsoft.Cache/Redis/cachetest01/privateEndpointConnections/pectest01",
15+
"name": "pectest01",
16+
"type": "Microsoft.Cache/Redis/privateEndpointConnections",
17+
"properties": {
18+
"provisioningState": "Succeeded",
19+
"privateEndpoint": {
20+
"id": "/subscriptions/{subscriptionId}/resourceGroups/rgtest01/providers/Microsoft.Network/privateEndpoints/petest01"
21+
},
22+
"privateLinkServiceConnectionState": {
23+
"status": "Approved",
24+
"description": "Auto-Approved",
25+
"actionsRequired": "None"
26+
}
2527
}
26-
}
27-
},
28-
{
29-
"id": "/subscriptions/{subscriptionId}/resourceGroups/rgtest01/providers/Microsoft.Cache/Redis/cachetest01/privateEndpointConnections/pectest01",
30-
"name": "pectest01",
31-
"type": "Microsoft.Cache/Redis/privateEndpointConnections",
32-
"properties": {
33-
"provisioningState": "Succeeded",
34-
"privateEndpoint": {
35-
"id": "/subscriptions/{subscriptionId}/resourceGroups/rgtest01/providers/Microsoft.Network/privateEndpoints/petest01"
36-
},
37-
"privateLinkServiceConnectionState": {
38-
"status": "Approved",
39-
"description": "Auto-Approved",
40-
"actionsRequired": "None"
28+
},
29+
{
30+
"id": "/subscriptions/{subscriptionId}/resourceGroups/rgtest01/providers/Microsoft.Cache/Redis/cachetest01/privateEndpointConnections/pectest01",
31+
"name": "pectest01",
32+
"type": "Microsoft.Cache/Redis/privateEndpointConnections",
33+
"properties": {
34+
"provisioningState": "Succeeded",
35+
"privateEndpoint": {
36+
"id": "/subscriptions/{subscriptionId}/resourceGroups/rgtest01/providers/Microsoft.Network/privateEndpoints/petest01"
37+
},
38+
"privateLinkServiceConnectionState": {
39+
"status": "Approved",
40+
"description": "Auto-Approved",
41+
"actionsRequired": "None"
42+
}
4143
}
4244
}
43-
}
44-
]
45+
]
46+
}
4547
}
4648
}
4749
}

‎specification/redis/resource-manager/Microsoft.Cache/stable/2020-06-01/redis.json‎

Lines changed: 52 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1819,6 +1819,53 @@
18191819
"properties": {
18201820
"redisConfiguration": {
18211821
"type": "object",
1822+
"properties": {
1823+
"rdb-backup-enabled": {
1824+
"type": "string",
1825+
"description": "Specifies whether the rdb backup is enabled"
1826+
},
1827+
"rdb-backup-frequency": {
1828+
"type": "string",
1829+
"description": "Specifies the frequency for creating rdb backup"
1830+
},
1831+
"rdb-backup-max-snapshot-count": {
1832+
"type": "string",
1833+
"description": "Specifies the maximum number of snapshots for rdb backup"
1834+
},
1835+
"rdb-storage-connection-string": {
1836+
"type": "string",
1837+
"description": "The storage account connection string for storing rdb file"
1838+
},
1839+
"aof-storage-connection-string-0": {
1840+
"type": "string",
1841+
"description": "First storage account connection string"
1842+
},
1843+
"aof-storage-connection-string-1": {
1844+
"type": "string",
1845+
"description": "Second storage account connection string"
1846+
},
1847+
"maxfragmentationmemory-reserved": {
1848+
"type": "string",
1849+
"description": "Value in megabytes reserved for fragmentation per shard"
1850+
},
1851+
"maxmemory-policy": {
1852+
"type": "string",
1853+
"description": "The eviction strategy used when your data won't fit within its memory limit."
1854+
},
1855+
"maxmemory-reserved": {
1856+
"type": "string",
1857+
"description": "Value in megabytes reserved for non-cache usage per shard e.g. failover."
1858+
},
1859+
"maxmemory-delta": {
1860+
"type": "string",
1861+
"description": "Value in megabytes reserved for non-cache usage per shard e.g. failover."
1862+
},
1863+
"maxclients": {
1864+
"type": "string",
1865+
"description": "The max clients config",
1866+
"readOnly": true
1867+
}
1868+
},
18221869
"additionalProperties": {
18231870
"type": "string"
18241871
},
@@ -2527,7 +2574,11 @@
25272574
},
25282575
"linkedRedisCacheLocation": {
25292576
"type": "string",
2530-
"description": "Location of the linked redis cache."
2577+
"description": "Location of the linked redis cache.",
2578+
"x-ms-mutability": [
2579+
"create",
2580+
"read"
2581+
]
25312582
},
25322583
"serverRole": {
25332584
"type": "string",

‎specification/redis/resource-manager/Microsoft.Cache/stable/2020-12-01/examples/RedisCacheListPrivateEndpointConnections.json‎

Lines changed: 33 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -8,40 +8,42 @@
88
},
99
"responses": {
1010
"200": {
11-
"body": [
12-
{
13-
"id": "/subscriptions/{subscriptionId}/resourceGroups/rgtest01/providers/Microsoft.Cache/Redis/cachetest01/privateEndpointConnections/pectest01",
14-
"name": "pectest01",
15-
"type": "Microsoft.Cache/Redis/privateEndpointConnections",
16-
"properties": {
17-
"provisioningState": "Succeeded",
18-
"privateEndpoint": {
19-
"id": "/subscriptions/{subscriptionId}/resourceGroups/rgtest01/providers/Microsoft.Network/privateEndpoints/petest01"
20-
},
21-
"privateLinkServiceConnectionState": {
22-
"status": "Approved",
23-
"description": "Auto-Approved",
24-
"actionsRequired": "None"
11+
"body": {
12+
"value": [
13+
{
14+
"id": "/subscriptions/{subscriptionId}/resourceGroups/rgtest01/providers/Microsoft.Cache/Redis/cachetest01/privateEndpointConnections/pectest01",
15+
"name": "pectest01",
16+
"type": "Microsoft.Cache/Redis/privateEndpointConnections",
17+
"properties": {
18+
"provisioningState": "Succeeded",
19+
"privateEndpoint": {
20+
"id": "/subscriptions/{subscriptionId}/resourceGroups/rgtest01/providers/Microsoft.Network/privateEndpoints/petest01"
21+
},
22+
"privateLinkServiceConnectionState": {
23+
"status": "Approved",
24+
"description": "Auto-Approved",
25+
"actionsRequired": "None"
26+
}
2527
}
26-
}
27-
},
28-
{
29-
"id": "/subscriptions/{subscriptionId}/resourceGroups/rgtest01/providers/Microsoft.Cache/Redis/cachetest01/privateEndpointConnections/pectest01",
30-
"name": "pectest01",
31-
"type": "Microsoft.Cache/Redis/privateEndpointConnections",
32-
"properties": {
33-
"provisioningState": "Succeeded",
34-
"privateEndpoint": {
35-
"id": "/subscriptions/{subscriptionId}/resourceGroups/rgtest01/providers/Microsoft.Network/privateEndpoints/petest01"
36-
},
37-
"privateLinkServiceConnectionState": {
38-
"status": "Approved",
39-
"description": "Auto-Approved",
40-
"actionsRequired": "None"
28+
},
29+
{
30+
"id": "/subscriptions/{subscriptionId}/resourceGroups/rgtest01/providers/Microsoft.Cache/Redis/cachetest01/privateEndpointConnections/pectest01",
31+
"name": "pectest01",
32+
"type": "Microsoft.Cache/Redis/privateEndpointConnections",
33+
"properties": {
34+
"provisioningState": "Succeeded",
35+
"privateEndpoint": {
36+
"id": "/subscriptions/{subscriptionId}/resourceGroups/rgtest01/providers/Microsoft.Network/privateEndpoints/petest01"
37+
},
38+
"privateLinkServiceConnectionState": {
39+
"status": "Approved",
40+
"description": "Auto-Approved",
41+
"actionsRequired": "None"
42+
}
4143
}
4244
}
43-
}
44-
]
45+
]
46+
}
4547
}
4648
}
4749
}

‎specification/redis/resource-manager/Microsoft.Cache/stable/2020-12-01/redis.json‎

Lines changed: 52 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1822,6 +1822,53 @@
18221822
"properties": {
18231823
"redisConfiguration": {
18241824
"type": "object",
1825+
"properties": {
1826+
"rdb-backup-enabled": {
1827+
"type": "string",
1828+
"description": "Specifies whether the rdb backup is enabled"
1829+
},
1830+
"rdb-backup-frequency": {
1831+
"type": "string",
1832+
"description": "Specifies the frequency for creating rdb backup"
1833+
},
1834+
"rdb-backup-max-snapshot-count": {
1835+
"type": "string",
1836+
"description": "Specifies the maximum number of snapshots for rdb backup"
1837+
},
1838+
"rdb-storage-connection-string": {
1839+
"type": "string",
1840+
"description": "The storage account connection string for storing rdb file"
1841+
},
1842+
"aof-storage-connection-string-0": {
1843+
"type": "string",
1844+
"description": "First storage account connection string"
1845+
},
1846+
"aof-storage-connection-string-1": {
1847+
"type": "string",
1848+
"description": "Second storage account connection string"
1849+
},
1850+
"maxfragmentationmemory-reserved": {
1851+
"type": "string",
1852+
"description": "Value in megabytes reserved for fragmentation per shard"
1853+
},
1854+
"maxmemory-policy": {
1855+
"type": "string",
1856+
"description": "The eviction strategy used when your data won't fit within its memory limit."
1857+
},
1858+
"maxmemory-reserved": {
1859+
"type": "string",
1860+
"description": "Value in megabytes reserved for non-cache usage per shard e.g. failover."
1861+
},
1862+
"maxmemory-delta": {
1863+
"type": "string",
1864+
"description": "Value in megabytes reserved for non-cache usage per shard e.g. failover."
1865+
},
1866+
"maxclients": {
1867+
"type": "string",
1868+
"description": "The max clients config",
1869+
"readOnly": true
1870+
}
1871+
},
18251872
"additionalProperties": {
18261873
"type": "string"
18271874
},
@@ -2472,7 +2519,11 @@
24722519
},
24732520
"linkedRedisCacheLocation": {
24742521
"type": "string",
2475-
"description": "Location of the linked redis cache."
2522+
"description": "Location of the linked redis cache.",
2523+
"x-ms-mutability": [
2524+
"create",
2525+
"read"
2526+
]
24762527
},
24772528
"serverRole": {
24782529
"type": "string",

0 commit comments

Comments
 (0)