[Hub Generated] Review request for Microsoft.Notebooks to add version preview/2019-10-11-preview (#15642)

* Add new API with examples, add a few new response for current API endpoints

* change file name back

* remove nullable parameter

* change operation name of patch

* add description to allowPublicNetworkResource

* change example from string to boolean

* Change publicnetworkaccess from boolean to string+

* change name

* change example to string

* change property name

Co-authored-by: Geoffrey Troyer <[email protected]>

Author: getroyer

specification/notebooks/resource-manager/Microsoft.Notebooks/preview/2019-10-11-preview/examples/NBResourcePEDelete.json

@@ -20,6 +20,7 @@
     }
   },
   "responses": {
-    "200": {}
+    "200": {},
+    "204": {}
   }
 }

specification/notebooks/resource-manager/Microsoft.Notebooks/preview/2019-10-11-preview/examples/NBResourcePEUpdate.json

@@ -77,6 +77,7 @@
           }
         ]
       }
-    }
+    },
+    "404": {}
   }
 }

specification/notebooks/resource-manager/Microsoft.Notebooks/preview/2019-10-11-preview/examples/NBResourcePatch.json

@@ -0,0 +1,16 @@
+{
+  "parameters": {
+    "resourceName": "testResource",
+    "resourceGroupName": "testRP",
+    "subscriptionId": "00000000-0000-0000-0000-000000000000",
+    "parameters": {
+      "properties": {
+        "publicNetworkAccess": "Enabled"
+      }
+    }
+  },
+  "responses": {
+    "200": {},
+    "404": {}
+  }
+}

specification/notebooks/resource-manager/Microsoft.Notebooks/preview/2019-10-11-preview/notebooks.json

@@ -208,6 +208,59 @@
             }
           }
         }
+      },
+      "patch": {
+        "tags": [
+          "NotebookProxy"
+        ],
+        "operationId": "NotebookProxies_Update",
+        "x-ms-examples": {
+          "Update Notebook Proxy": {
+            "$ref": "./examples/NBResourcePatch.json"
+          }
+        },
+        "consumes": [
+          "application/json"
+        ],
+        "produces": [
+          "application/json"
+        ],
+        "summary": "Patch NotebookProxy resource.",
+        "description": "Patch NotebookProxy resource with specified configuration.",
+        "parameters": [
+          {
+            "$ref": "#/parameters/SubscriptionIdParameter"
+          },
+          {
+            "$ref": "#/parameters/ResourceGroupNameParameter"
+          },
+          {
+            "$ref": "#/parameters/ResourceNameParameter"
+          },
+          {
+            "name": "parameters",
+            "description": "The properties of the NotebookProxy to be created or updated.",
+            "in": "body",
+            "required": true,
+            "schema": {
+              "$ref": "#/definitions/MutableNotebookProxy"
+            }
+          }
+        ],
+        "responses": {
+          "200": {
+            "description": "OK"
+          },
+          "404": {
+            "description": "NotFound"
+          },
+          "default": {
+            "description": "Error response describing why the operation failed.",
+            "schema": {
+              "$ref": "#/definitions/CloudError"
+            }
+          }
+        }
       }
     },
     "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Notebooks/notebookProxies": {
@@ -400,6 +453,9 @@
               "$ref": "#/definitions/NotebookPEResponse"
             }
           },
+          "404": {
+            "description": "Not found"
+          },
           "default": {
             "description": "Error response describing why the operation failed.",
             "schema": {
@@ -461,6 +517,9 @@
           "200": {
             "description": "Success"
           },
+          "204": {
+            "description": "No Content"
+          },
           "default": {
             "description": "Error response describing why the operation failed.",
             "schema": {
@@ -512,6 +571,31 @@
         "publicDns": {
           "description": "The public DNS name",
           "type": "string"
+        },
+        "publicNetworkAccess": {
+          "description": "Allow public network access on a V-Net locked notebook resource",
+          "type": "string"
+        }
+      }
+    },
+    "MutableNotebookProxy": {
+      "description": "The mutable properties on a NotebookProxy resource ",
+      "type": "object",
+      "properties": {
+        "properties": {
+          "$ref": "#/definitions/MutableNotebookResource",
+          "description": "The mutable properties of NotebookProxy resource.",
+          "x-ms-client-flatten": true
+        }
+      }
+    },
+    "MutableNotebookResource": {
+      "description": "Properties of NotebookProxy resource",
+      "type": "object",
+      "properties": {
+        "publicNetworkAccess": {
+          "description": "A flag that allows public network access to a private link locked notebook resource.",
+          "type": "string"
         }
       }
     },