Skip to content

Commit 25e3eaa

Browse files
tamilmani1989tamilmani1989
authored
API Spec change for DNC RP (#10819)
* updated apispec * spell error fix * removed dncappid from response * updated apispec * Added appid and endpoint in response * adde controller id in delegated subnet response * updated examples * updated * updated apispec * spell check and prettier fix * spell check fix * updated title same in all files * updated operationid * reverting to new change * addressed review comments * addressed feedback comments * spell check fix * updated readme.md * updated definition name * addressed feedback comments * fixed lint issue
1 parent 7d9eaf4 commit 25e3eaa

25 files changed

+2168
-1133
lines changed

‎specification/dnc/resource-manager/Microsoft.DelegatedNetwork/preview/2020-08-08-preview/DelegatedNetwork.json‎

Lines changed: 0 additions & 1038 deletions
This file was deleted.

‎specification/dnc/resource-manager/Microsoft.DelegatedNetwork/preview/2020-08-08-preview/controller.json‎

Lines changed: 506 additions & 0 deletions
Large diffs are not rendered by default.

‎specification/dnc/resource-manager/Microsoft.DelegatedNetwork/preview/2020-08-08-preview/delegatedSubnets.json‎

Lines changed: 520 additions & 0 deletions
Large diffs are not rendered by default.

‎specification/dnc/resource-manager/Microsoft.DelegatedNetwork/preview/2020-08-08-preview/examples/delegatedNetworkControllerListByRG.json‎ renamed to ‎specification/dnc/resource-manager/Microsoft.DelegatedNetwork/preview/2020-08-08-preview/examples/controllerListByRG.json‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,15 @@
1010
"body": {
1111
"value": [
1212
{
13-
"id": "/subscriptions/613192d7-503f-477a-9cfe-4efc3ee2bd60/resourceGroups/TestRG/providers/Microsoft.DelegatedNetwork/controller/dnctestcontroller1",
13+
"id": "/subscriptions/613192d7-503f-477a-9cfe-4efc3ee2bd60/resourceGroups/TestRG/providers/Microsoft.DelegatedNetwork/controller/testcontroller",
1414
"location": "West US",
15-
"name": "dnctestcontroller1",
15+
"name": "testcontroller",
1616
"type": "Microsoft.DelegatedNetwork/controller",
1717
"properties": {
18-
"state": "Succeeded",
18+
"provisioningState": "Succeeded",
19+
"resourceGuid": "5a82cbcf-e8ea-4175-ac2b-ad36a73f9801",
1920
"dncAppId": "ac1192d7-503f-477a-9cfe-4efc3ee2bd60",
21+
"dncTenantId": "66192d7-503f-477a-9cfe-4efc3ee2bd60",
2022
"dncEndpoint": "https://orch.useast.dnc.azure.com"
2123
}
2224
}

‎specification/dnc/resource-manager/Microsoft.DelegatedNetwork/preview/2020-08-08-preview/examples/delegatedNetworkControllerListBySub.json‎ renamed to ‎specification/dnc/resource-manager/Microsoft.DelegatedNetwork/preview/2020-08-08-preview/examples/controllerListBySub.json‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,15 @@
99
"body": {
1010
"value": [
1111
{
12-
"id": "/subscriptions/613192d7-503f-477a-9cfe-4efc3ee2bd60/resourceGroups/TestRG/providers/Microsoft.DelegatedNetwork/controller/dnctestcontroller1",
12+
"id": "/subscriptions/613192d7-503f-477a-9cfe-4efc3ee2bd60/resourceGroups/TestRG/providers/Microsoft.DelegatedNetwork/controller/testcontroller",
1313
"location": "West US",
14-
"name": "dnctestcontroller1",
14+
"name": "testcontroller",
1515
"type": "Microsoft.DelegatedNetwork/controller",
1616
"properties": {
17-
"state": "Succeeded",
17+
"provisioningState": "Succeeded",
18+
"resourceGuid": "5a82cbcf-e8ea-4175-ac2b-ad36a73f9801",
1819
"dncAppId": "ac1192d7-503f-477a-9cfe-4efc3ee2bd60",
20+
"dncTenantId": "66192d7-503f-477a-9cfe-4efc3ee2bd60",
1921
"dncEndpoint": "https://orch.useast.dnc.azure.com"
2022
}
2123
}

‎specification/dnc/resource-manager/Microsoft.DelegatedNetwork/preview/2020-08-08-preview/examples/delegatedNetworkOperationsList.json‎

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,33 @@
3434
"description": "Delete a Controller Service instance."
3535
}
3636
},
37+
{
38+
"name": "Microsoft.DelegatedNetwork/orchestratorInstances/write",
39+
"display": {
40+
"provider": "Microsoft Delegated Network Service",
41+
"resource": "Microsoft Delegated Network orchestratorInstance",
42+
"operation": "Create or update a orchestratorInstance.",
43+
"description": "Create or update a orchestratorInstance."
44+
}
45+
},
46+
{
47+
"name": "Microsoft.DelegatedNetwork/controller/read",
48+
"display": {
49+
"provider": "Microsoft Delegated Network Service",
50+
"resource": "Microsoft Delegated Network orchestratorInstance",
51+
"operation": "Get a orchestratorInstances.",
52+
"description": "Get a orchestratorInstance."
53+
}
54+
},
55+
{
56+
"name": "Microsoft.DelegatedNetwork/controller/delete",
57+
"display": {
58+
"provider": "Microsoft Delegated Network Service",
59+
"resource": "Microsoft Delegated Network orchestratorInstance",
60+
"operation": "Delete a orchestratorInstance.",
61+
"description": "Delete a orchestratorInstance."
62+
}
63+
},
3764
{
3865
"name": "Microsoft.DelegatedNetwork/delegatedSubnets/write",
3966
"display": {

‎specification/dnc/resource-manager/Microsoft.DelegatedNetwork/preview/2020-08-08-preview/examples/delegatedSubnetListByRG.json‎

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,19 @@
1010
"body": {
1111
"value": [
1212
{
13-
"id": "/subscriptions/613192d7-503f-477a-9cfe-4efc3ee2bd60/resourceGroups/TestRG/providers/Microsoft.Network/virtualNetworks/testvnet/subnets/testsubnet/providers/Microsoft.DelegatedNetwork/delegatedSubnets/delegated1",
13+
"id": "/subscriptions/613192d7-503f-477a-9cfe-4efc3ee2bd60/resourceGroups/TestRG/providers/Microsoft.DelegatedNetwork/delegatedSubnets/delegated1",
1414
"location": "West US",
1515
"name": "delegated1",
1616
"type": "Microsoft.DelegatedNetwork/delegatedSubnets",
1717
"properties": {
18-
"state": "Succeeded",
19-
"resourceGuid": "5a82cbcf-e8ea-4175-ac2b-ad36a73f9801"
18+
"provisioningState": "Succeeded",
19+
"resourceGuid": "5a82cbcf-e8ea-4175-ac2b-ad36a73f9801",
20+
"subnetDetails": {
21+
"id": "/subscriptions/613192d7-503f-477a-9cfe-4efc3ee2bd60/resourceGroups/TestRG/providers/Microsoft.Network/virtualNetworks/testvnet/subnets/testsubnet"
22+
},
23+
"controllerDetails": {
24+
"id": "/subscriptions/613192d7-503f-477a-9cfe-4efc3ee2bd60/resourceGroups/TestRG/providers/Microsoft.DelegatedNetwork/controller/dnctestcontroller"
25+
}
2026
}
2127
}
2228
]

‎specification/dnc/resource-manager/Microsoft.DelegatedNetwork/preview/2020-08-08-preview/examples/delegatedSubnetListBySub.json‎

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,14 @@
1414
"name": "delegated1",
1515
"type": "Microsoft.DelegatedNetwork/delegatedSubnets",
1616
"properties": {
17-
"state": "Succeeded",
18-
"resourceGuid": "5a82cbcf-e8ea-4175-ac2b-ad36a73f9801"
17+
"provisioningState": "Succeeded",
18+
"resourceGuid": "5a82cbcf-e8ea-4175-ac2b-ad36a73f9801",
19+
"subnetDetails": {
20+
"id": "/subscriptions/613192d7-503f-477a-9cfe-4efc3ee2bd60/resourceGroups/TestRG/providers/Microsoft.Network/virtualNetworks/testvnet/subnets/testsubnet"
21+
},
22+
"controllerDetails": {
23+
"id": "/subscriptions/613192d7-503f-477a-9cfe-4efc3ee2bd60/resourceGroups/TestRG/providers/Microsoft.DelegatedNetwork/controller/dnctestcontroller"
24+
}
1925
}
2026
}
2127
]

‎specification/dnc/resource-manager/Microsoft.DelegatedNetwork/preview/2020-08-08-preview/examples/deleteController.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"parameters": {
33
"subscriptionId": "613192d7-503f-477a-9cfe-4efc3ee2bd60",
44
"resourceGroupName": "TestRG",
5-
"resourceName": "dnctestcontroller",
5+
"resourceName": "testcontroller",
66
"api-version": "2020-08-08-preview"
77
},
88
"responses": {

‎specification/dnc/resource-manager/Microsoft.DelegatedNetwork/preview/2020-08-08-preview/examples/deleteDelegatedSubnet.json‎

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,8 @@
22
"parameters": {
33
"subscriptionId": "613192d7-503f-477a-9cfe-4efc3ee2bd60",
44
"resourceGroupName": "TestRG",
5-
"vnetName": "testvnet",
6-
"subnetName": "testsubnet",
75
"resourceName": "delegated1",
8-
"api-version": "2020-08-08-preview",
9-
"delegatedSubnetParameters": {
10-
"controllerID": "/subscriptions/613192d7-503f-477a-9cfe-4efc3ee2bd60/resourceGroups/TestRG/providers/Microsoft.DelegatedNetwork/controller/dnctestcontroller"
11-
}
6+
"api-version": "2020-08-08-preview"
127
},
138
"responses": {
149
"200": {

0 commit comments

Comments
 (0)