Skip to content

Commit 05bea67

Browse files
alexgoldschmidtAlex Goldschmidt
andauthored
[Hub Generated] Review request for Microsoft.Consumption to add version stable/2021-05-01 (#15648)
* Make changes based on s360 * Fix example errors * Missed an instance of purchaseDate type * No schema for 204 * Ran prettier Co-authored-by: Alex Goldschmidt <[email protected]>
1 parent 7326c66 commit 05bea67

File tree

4 files changed

+30
-6
lines changed

4 files changed

+30
-6
lines changed

specification/consumption/resource-manager/Microsoft.Consumption/stable/2021-05-01/consumption.json

Lines changed: 25 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1710,7 +1710,7 @@
17101710
"url": "https://docs.microsoft.com/en-us/rest/api/consumption/"
17111711
},
17121712
"x-ms-examples": {
1713-
"EventsListByBillingProfile": {
1713+
"LotsListByBillingProfile": {
17141714
"$ref": "./examples/LotsListByBillingProfile.json"
17151715
}
17161716
},
@@ -1829,6 +1829,9 @@
18291829
"$ref": "#/definitions/CreditSummary"
18301830
}
18311831
},
1832+
"204": {
1833+
"description": "No Content. The request has succeeded but returned no results."
1834+
},
18321835
"default": {
18331836
"description": "Error response describing why the operation failed.",
18341837
"schema": {
@@ -5044,6 +5047,11 @@
50445047
"description": "The balance in billing currency after the event.",
50455048
"readOnly": true,
50465049
"$ref": "#/definitions/AmountWithExchangeRate"
5050+
},
5051+
"etag": {
5052+
"readOnly": true,
5053+
"type": "string",
5054+
"description": "The etag for the resource."
50475055
}
50485056
}
50495057
},
@@ -5125,7 +5133,7 @@
51255133
"type": "string",
51265134
"readOnly": true
51275135
},
5128-
"purchaseDate": {
5136+
"purchasedDate": {
51295137
"description": "The date when the lot was added.",
51305138
"type": "string",
51315139
"format": "date-time",
@@ -5172,6 +5180,11 @@
51725180
"description": "The reseller of the lot.",
51735181
"readOnly": true,
51745182
"$ref": "#/definitions/Reseller"
5183+
},
5184+
"etag": {
5185+
"readOnly": true,
5186+
"type": "string",
5187+
"description": "The etag for the resource."
51755188
}
51765189
}
51775190
},
@@ -5229,6 +5242,11 @@
52295242
"description": "Credit's reseller.",
52305243
"readOnly": true,
52315244
"$ref": "#/definitions/Reseller"
5245+
},
5246+
"etag": {
5247+
"readOnly": true,
5248+
"type": "string",
5249+
"description": "The etag for the resource."
52325250
}
52335251
}
52345252
},
@@ -5373,6 +5391,11 @@
53735391
},
53745392
"AmountWithExchangeRate": {
53755393
"description": "The amount with exchange rate.",
5394+
"allOf": [
5395+
{
5396+
"$ref": "#/definitions/amount"
5397+
}
5398+
],
53765399
"properties": {
53775400
"exchangeRate": {
53785401
"description": "The exchange rate.",

specification/consumption/resource-manager/Microsoft.Consumption/stable/2021-05-01/examples/CreditSummaryByBillingProfile.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@
4141
}
4242
}
4343
}
44-
}
44+
},
45+
"204": {}
4546
}
4647
}

specification/consumption/resource-manager/Microsoft.Consumption/stable/2021-05-01/examples/LotsListByBillingAccount.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"source": "ConsumptionCommitment",
2424
"startDate": "2019-10-01T00:00:00Z",
2525
"expirationDate": "2019-11-01T00:00:00Z",
26-
"purchaseDate": "2019-09-01T00:00:00Z",
26+
"purchasedDate": "2019-09-01T00:00:00Z",
2727
"status": "Active"
2828
}
2929
},
@@ -43,7 +43,7 @@
4343
"source": "ConsumptionCommitment",
4444
"startDate": "2019-11-01T00:00:00Z",
4545
"expirationDate": "2019-12-31T00:00:00Z",
46-
"purchaseDate": "2019-09-01T00:00:00Z",
46+
"purchasedDate": "2019-09-01T00:00:00Z",
4747
"status": "Expired"
4848
}
4949
}

specification/consumption/resource-manager/Microsoft.Consumption/stable/2021-05-01/examples/LotsListByBillingAccountWithFilters.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
"source": "ConsumptionCommitment",
2525
"startDate": "2019-10-01T00:00:00Z",
2626
"expirationDate": "2019-11-01T00:00:00Z",
27-
"purchaseDate": "2019-09-01T00:00:00Z",
27+
"purchasedDate": "2019-09-01T00:00:00Z",
2828
"status": "Active"
2929
}
3030
}

0 commit comments

Comments
 (0)