Skip to content

Commit 046b74c

Browse files
committed
2 parents 3b598b7 + 9635c95 commit 046b74c

File tree

177 files changed

+19479
-629
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

177 files changed

+19479
-629
lines changed

.azure-pipelines/PrettierCheck.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
jobs:
22
- job: "PrettierCheck"
3-
condition: "not(variables['PRIVATE'])"
43
variables:
54
NODE_OPTIONS: '--max-old-space-size=8192'
65
pool:

.azure-pipelines/Spellcheck.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
jobs:
22
- job: "Spellcheck"
3-
condition: "not(variables['PRIVATE'])"
43
variables:
54
NODE_OPTIONS: '--max-old-space-size=8192'
65
pool:

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ If any further question about AME onboarding or validation tools, please view th
1414
- Adding a new API version
1515
- Adding a new service
1616

17+
- [ ] Please ensure you've reviewed following [guidelines](https://aka.ms/rpguidelines) including [ARM resource provider contract](https://github.com/Azure/azure-resource-manager-rpc) and [REST guidelines](https://github.com/microsoft/api-guidelines/blob/vNext/azure/Guidelines.md). Estimated time (4 hours). This is required before you can request review from ARM API Review board.
18+
1719
- [ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (*RP Manifest Approvers* team under <ins>Azure Resource Manager service</ins>) from IcM and reach out to them.
1820

1921
### Breaking Change Review Checklist

.github/pull_request_assignment.yml

Lines changed: 133 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,127 @@
1616
- lmazuel
1717
- tjprescott
1818

19+
20+
- rule:
21+
paths:
22+
- "specification/network/**"
23+
reviewers:
24+
- MyronFanQiu
25+
- lirenhe
26+
27+
- rule:
28+
paths:
29+
- "specification/@(applicationinsights|operationalinsights)/**"
30+
reviewers:
31+
- MyronFanQiu
32+
33+
- rule:
34+
paths: "specification/@(resources|powerplatform)/**"
35+
reviewers:
36+
- raych1
37+
38+
- rule:
39+
paths: "specification/compute/**"
40+
reviewers:
41+
- ArcturusZhang
42+
- fengzhou-msft
43+
- yungezz
44+
45+
- rule:
46+
paths:
47+
- "specification/machinelearningservices/**"
48+
reviewers:
49+
- ArcturusZhang
50+
51+
- rule:
52+
paths:
53+
- "specification/@(azureactivedirectory|appplatform)/**"
54+
reviewers:
55+
- njuCZ
56+
57+
- rule:
58+
paths:
59+
- "specification/authorization/**"
60+
reviewers:
61+
- qianwens
62+
- yungezz
63+
64+
- rule:
65+
paths:
66+
- "specification/datafactory/**"
67+
reviewers:
68+
- qianwens
69+
70+
- rule:
71+
paths:
72+
- "specification/monitor/**"
73+
reviewers:
74+
- weidongxu-microsoft
75+
- MyronFanQiu
76+
77+
- rule:
78+
paths:
79+
- "specification/storage/**"
80+
reviewers:
81+
- qianwens
82+
- Juliehzl
83+
84+
1985
- rule:
2086
paths: "specification/mediaservices/**"
2187
reviewers:
2288
- allenjzhang
89+
- rule:
90+
paths:
91+
- "specification/@(keyvault|notificationhubs)/**"
92+
- "specification/@(databricks|containerregistry)/**"
93+
reviewers:
94+
- fengzhou-msft
95+
96+
- rule:
97+
paths:
98+
- "specification/@(containerservice|containerinstance)/**"
99+
reviewers:
100+
- PhoenixHe-msft
101+
- fengzhou-msft
102+
- yungezz
103+
104+
- rule:
105+
paths:
106+
- "specification/mixedreality/**"
107+
- "specification/hdinsight/**"
108+
reviewers:
109+
- leni-msft
110+
111+
- rule:
112+
paths:
113+
- "specification/portal/**"
114+
reviewers:
115+
- PhoenixHe-msft
116+
117+
- rule:
118+
paths:
119+
- "specification/web/**"
120+
reviewers:
121+
- weidongxu-microsoft
122+
123+
- rule:
124+
paths:
125+
- "documentation/**"
126+
reviewers:
127+
- josefree
128+
- akning-ms
129+
130+
- rule:
131+
paths:
132+
- "**/package.json"
133+
- ".github/**"
134+
- "**/azure-pipelines.yml"
135+
- ".azure-pipelines/**"
136+
- ".azure-pipelines-preproduction/**"
137+
reviewers:
138+
- akning-ms
139+
- PhoenixHe-msft
23140

24141
- rule:
25142
paths:
@@ -45,6 +162,19 @@
45162
paths:
46163
- "**"
47164
reviewers:
48-
- allenjzhang
49-
- markcowl
50-
165+
- yungezz
166+
- erich-wang
167+
- PhoenixHe-msft
168+
- lirenhe
169+
- weidongxu-microsoft
170+
- ArcturusZhang
171+
- xccc-msft
172+
- raych1
173+
- ChenTanyi
174+
- fengzhou-msft
175+
- njuCZ
176+
- akning-ms
177+
- leni-msft
178+
- qianwens
179+
- ruowan
180+
- jianyexi

CODEOWNERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@
6060
/specification/relay/ @sethmanheim @v-ajnava
6161
/specification/resources/ @Tiano2017 @rajshah11 @vivsriaus
6262
/specification/scheduler/ @pinwang81
63-
/specification/search/data-plane/ @brjohnstmsft @arv100kri @bleroy
63+
/specification/search/data-plane/ @brjohnstmsft @arv100kri @bleroy @heaths @AlexGhiondea
6464
/specification/search/resource-manager/ @abhi1509 @miwelsh @tjacobhi
6565
/specification/serialconsole/ @amitchat @craigw @asinn826
6666
/specification/service-map/ @daveirwin1

custom-words.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -282,6 +282,7 @@ Certificatethumbprint
282282
certverify
283283
Chademo
284284
chainer
285+
changedSince
285286
changepoint
286287
changestate
287288
CHECKACCESS

0 commit comments

Comments
 (0)