Skip to content

Update Microsoft.Authorization api version for Get-RoleDefinition 5 #23396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Update Microsoft.Authorization api version for Get-RoleDefinition 5 #23396

wants to merge 4 commits into from

Conversation

@mumoryan
Copy link
Contributor

@mumoryan mumoryan commented Nov 13, 2023

Description

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Nov 13, 2023 •
edited
Loading

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.ApplicationInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Az.Authorization
🔄Generated Sdk Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Az.Blueprint
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
️✔️Az.Compute
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Az.CosmosDB
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Az.DeploymentManager
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Az.DevSpaces
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
️✔️Az.KeyVault
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Az.MachineLearning
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
️✔️Az.ManagedServiceIdentity
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Monitor
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.OperationalInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.PrivateDns
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
❌Az.Resources
❌Build
❌PowerShell Core - Windows
Type Code Position Detail
❌ CS0246 D:\a_work\1\s\src\Resources\Resources\Models.Authorization\AuthorizationClient.cs(592,118) The type or namespace name 'DenyAssignmentFilter' could not be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\Resources\Resources\Resources.csproj]
❌ CS0246 D:\a_work\1\s\src\Resources\Resources\Models.Authorization\AuthorizationClientExtensions.cs(34,98) The type or namespace name 'RoleAssignment' could not be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\Resources\Resources\Resources.csproj]
❌ CS0246 D:\a_work\1\s\src\Resources\Resources\Models.Authorization\AuthorizationClientExtensions.cs(34,35) The type or namespace name 'RoleAssignment' could not be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\Resources\Resources\Resources.csproj]
❌ CS0246 D:\a_work\1\s\src\Resources\Resources\Models.Authorization\AuthorizationClientExtensions.cs(67,64) The type or namespace name 'RoleAssignment' could not be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\Resources\Resources\Resources.csproj]
❌ CS0246 D:\a_work\1\s\src\Resources\Resources\Models.Authorization\AuthorizationClientExtensions.cs(129,64) The type or namespace name 'ClassicAdministrator' could not be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\Resources\Resources\Resources.csproj]
❌ CS0246 D:\a_work\1\s\src\Resources\Resources\Models.Authorization\AuthorizationClientExtensions.cs(149,90) The type or namespace name 'RoleAssignment' could not be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\Resources\Resources\Resources.csproj]
❌ CS0246 D:\a_work\1\s\src\Resources\Resources\Models.Authorization\AuthorizationClientExtensions.cs(259,64) The type or namespace name 'DenyAssignment' could not be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\Resources\Resources\Resources.csproj]
❌ CS0246 D:\a_work\1\s\src\Resources\Resources\Models.Authorization\AuthorizationClientExtensions.cs(297,90) The type or namespace name 'DenyAssignment' could not be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\Resources\Resources\Resources.csproj]
❌ CS0246 D:\a_work\1\s\src\Resources\Resources\Models.ResourceGroups\ResourceClient.cs(319,16) The type or namespace name 'ProviderOperationsMetadata' could not be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\Resources\Resources\Resources.csproj]
❌ CS0246 D:\a_work\1\s\src\Resources\Resources\Models.ResourceGroups\ResourceClient.cs(322,22) The type or namespace name 'ProviderOperationsMetadata' could not be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\Resources\Resources\Resources.csproj]
❌ CS0246 D:\a_work\1\s\src\Resources\Resources\Providers\GetAzureProviderOperationCmdlet.cs(125,111) The type or namespace name 'ProviderOperationsMetadata' could not be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\Resources\Resources\Resources.csproj]
❌ CS0246 D:\a_work\1\s\src\Resources\Resources\Providers\GetAzureProviderOperationCmdlet.cs(133,82) The type or namespace name 'ProviderOperation' could not be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\Resources\Resources\Resources.csproj]
❌Windows PowerShell - Windows
Type Code Position Detail
❌ CS0246 D:\a_work\1\s\src\Resources\Resources\Models.Authorization\AuthorizationClient.cs(592,118) The type or namespace name 'DenyAssignmentFilter' could not be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\Resources\Resources\Resources.csproj]
❌ CS0246 D:\a_work\1\s\src\Resources\Resources\Models.Authorization\AuthorizationClientExtensions.cs(34,98) The type or namespace name 'RoleAssignment' could not be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\Resources\Resources\Resources.csproj]
❌ CS0246 D:\a_work\1\s\src\Resources\Resources\Models.Authorization\AuthorizationClientExtensions.cs(34,35) The type or namespace name 'RoleAssignment' could not be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\Resources\Resources\Resources.csproj]
❌ CS0246 D:\a_work\1\s\src\Resources\Resources\Models.Authorization\AuthorizationClientExtensions.cs(67,64) The type or namespace name 'RoleAssignment' could not be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\Resources\Resources\Resources.csproj]
❌ CS0246 D:\a_work\1\s\src\Resources\Resources\Models.Authorization\AuthorizationClientExtensions.cs(129,64) The type or namespace name 'ClassicAdministrator' could not be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\Resources\Resources\Resources.csproj]
❌ CS0246 D:\a_work\1\s\src\Resources\Resources\Models.Authorization\AuthorizationClientExtensions.cs(149,90) The type or namespace name 'RoleAssignment' could not be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\Resources\Resources\Resources.csproj]
❌ CS0246 D:\a_work\1\s\src\Resources\Resources\Models.Authorization\AuthorizationClientExtensions.cs(259,64) The type or namespace name 'DenyAssignment' could not be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\Resources\Resources\Resources.csproj]
❌ CS0246 D:\a_work\1\s\src\Resources\Resources\Models.Authorization\AuthorizationClientExtensions.cs(297,90) The type or namespace name 'DenyAssignment' could not be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\Resources\Resources\Resources.csproj]
❌ CS0246 D:\a_work\1\s\src\Resources\Resources\Models.ResourceGroups\ResourceClient.cs(319,16) The type or namespace name 'ProviderOperationsMetadata' could not be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\Resources\Resources\Resources.csproj]
❌ CS0246 D:\a_work\1\s\src\Resources\Resources\Models.ResourceGroups\ResourceClient.cs(322,22) The type or namespace name 'ProviderOperationsMetadata' could not be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\Resources\Resources\Resources.csproj]
❌ CS0246 D:\a_work\1\s\src\Resources\Resources\Providers\GetAzureProviderOperationCmdlet.cs(125,111) The type or namespace name 'ProviderOperationsMetadata' could not be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\Resources\Resources\Resources.csproj]
❌ CS0246 D:\a_work\1\s\src\Resources\Resources\Providers\GetAzureProviderOperationCmdlet.cs(133,82) The type or namespace name 'ProviderOperation' could not be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\Resources\Resources\Resources.csproj]
🔄Breaking Change Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Signature Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Help File Existence Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄File Change Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄UX Metadata Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
️✔️Az.Sql
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Storage
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

@NoriZC
Copy link
Contributor

NoriZC commented Nov 16, 2023

Hi @mumoryan, are you planning to add new features by upgrading api version? If so, please follow the Track 1 SDK migration guide to generate by autorest.powershell instead of autorest.csharp, which is about to be deprecated.

I recommend to close this pr and raise a new one to work on autorest.powershell.

@mumoryan
Copy link
Contributor Author

mumoryan commented Dec 21, 2023

Closing old prs. Merged one in #23797

@mumoryan mumoryan closed this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@VeryEarly VeryEarly

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mumoryan @NoriZC @VeryEarly