Skip to content

Comments

Fix the telemetry collection logic#22908

Merged
VeryEarly merged 6 commits intoAzure:mainfrom
kceiw:mahuang/FixTel
Oct 11, 2023
Merged

Fix the telemetry collection logic#22908
VeryEarly merged 6 commits intoAzure:mainfrom
kceiw:mahuang/FixTel

Conversation

@kceiw
Copy link
Contributor

@kceiw kceiw commented Oct 6, 2023

Description

In sometimes the user input was collected with more information than we need. This fix is to use regex to narrow down the edge case so we will only collect the user input when it's in a proper Az cmdlet format.

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Oct 6, 2023

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

@kceiw kceiw removed the request for review from dingmeng-xue October 6, 2023 17:54
@VeryEarly VeryEarly self-assigned this Oct 8, 2023
@VeryEarly
Copy link
Collaborator

hi @kceiw, can you share the release plan for this fix?

@VeryEarly VeryEarly merged commit 6d6d067 into Azure:main Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants