diff --git a/src/ManagedServices/ManagedServices/ChangeLog.md b/src/ManagedServices/ManagedServices/ChangeLog.md index 70a893f43094..e2638c8b2e0e 100644 --- a/src/ManagedServices/ManagedServices/ChangeLog.md +++ b/src/ManagedServices/ManagedServices/ChangeLog.md @@ -18,6 +18,7 @@ - Additional information about change #1 --> ## Upcoming Release +* Updated breaking change warnings on cmdlets of managed services assignment and definition ## Version 1.1.0 * Added breaking change warnings on cmdlets of managed services assignment and definition diff --git a/src/ManagedServices/ManagedServices/Commands/NewAzureRmManagedServicesAssignment.cs b/src/ManagedServices/ManagedServices/Commands/NewAzureRmManagedServicesAssignment.cs index a938c1153768..1792bf257a41 100644 --- a/src/ManagedServices/ManagedServices/Commands/NewAzureRmManagedServicesAssignment.cs +++ b/src/ManagedServices/ManagedServices/Commands/NewAzureRmManagedServicesAssignment.cs @@ -42,6 +42,11 @@ public class NewAzureRmManagedServicesAssignment : ManagedServicesCmdletBase [ScopeCompleter] public string Scope { get; set; } + [CmdletParameterBreakingChange( + nameOfParameterChanging: "RegistrationDefinitionName", + deprecateByVersion: ManagedServicesUtility.UpcomingVersion, + changeInEfectByDate: ManagedServicesUtility.UpcomingVersionReleaseDate, + ChangeDescription = ManagedServicesUtility.DeprecatedParameterDescription)] [Parameter(ParameterSetName = DefaultParameterSet, Mandatory = true, HelpMessage = "The registration definition identifier.")] [ValidateNotNullOrEmpty] public string RegistrationDefinitionName { get; set; } @@ -50,7 +55,7 @@ public class NewAzureRmManagedServicesAssignment : ManagedServicesCmdletBase nameOfParameterChanging: "RegistrationDefinitionResourceId", deprecateByVersion: ManagedServicesUtility.UpcomingVersion, changeInEfectByDate: ManagedServicesUtility.UpcomingVersionReleaseDate, - ChangeDescription = ManagedServicesUtility.DeprecatedParameterDescription)] + ReplaceMentCmdletParameterName = "RegistrationDefinitionId")] [Parameter(ParameterSetName = ByResourceIdParameterSet, ValueFromPipelineByPropertyName = true, Mandatory = true, HelpMessage = "The fully qualified resource id of the registration definition.")] [ValidateNotNullOrEmpty] [Alias("ResourceId")] diff --git a/src/ManagedServices/ManagedServices/Commands/NewAzureRmManagedServicesDefinition.cs b/src/ManagedServices/ManagedServices/Commands/NewAzureRmManagedServicesDefinition.cs index a5da0a046708..4918cc6f8163 100644 --- a/src/ManagedServices/ManagedServices/Commands/NewAzureRmManagedServicesDefinition.cs +++ b/src/ManagedServices/ManagedServices/Commands/NewAzureRmManagedServicesDefinition.cs @@ -15,6 +15,7 @@ using Microsoft.Azure.Management.ManagedServices.Models; using Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Extensions; using Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Models; +using Microsoft.WindowsAzure.Commands.Common.CustomAttributes; using Microsoft.WindowsAzure.Commands.Utilities.Common; using System; using System.Collections.Generic; @@ -23,10 +24,14 @@ namespace Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands { - [WindowsAzure.Commands.Common.CustomAttributes.GenericBreakingChange( + [GenericBreakingChange( message: "New mandatory parameter 'DisplayName' will be added to represent a user-friendly name for a registration definition", deprecateByVersion: ManagedServicesUtility.UpcomingVersion, changeInEfectByDate: ManagedServicesUtility.UpcomingVersionReleaseDate)] + [GenericBreakingChange( + message: "New mandatory parameter 'Authorization' will be added to represent a list containing principal IDs and role definition IDs.", + deprecateByVersion: ManagedServicesUtility.UpcomingVersion, + changeInEfectByDate: ManagedServicesUtility.UpcomingVersionReleaseDate)] [Cmdlet( VerbsCommon.New, Microsoft.Azure.Commands.ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "ManagedServicesDefinition", diff --git a/src/ManagedServices/ManagedServices/Extensions/ManagedServicesUtility.cs b/src/ManagedServices/ManagedServices/Extensions/ManagedServicesUtility.cs index b120094a86b3..c524a7e05e75 100644 --- a/src/ManagedServices/ManagedServices/Extensions/ManagedServicesUtility.cs +++ b/src/ManagedServices/ManagedServices/Extensions/ManagedServicesUtility.cs @@ -22,7 +22,7 @@ namespace Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Extensions public static class ManagedServicesUtility { // TODO: Remove these three string as well as breaking changes attributes for Oct. 27th change - public const string UpcomingVersion = "1.0.3"; + public const string UpcomingVersion = "1.3.0"; public const string UpcomingVersionReleaseDate = "10/27/2020"; public const string DeprecatedParameterDescription = "Parameter is being deprecated without being replaced";