disable send-azpredictorrating in results az.tools.predictor

[brwilkinson]

Description

I was wondering what is the setting to disable this?

Script or Debug output

No response

Environment data

No response

Module versions

No response

Error output

No response

[dcaro]

@brwilkinson we introduced this in the preview but there is no setting to remove the message. We will remove this in the upcoming preview.
cc @kceiw

[brwilkinson]

Thank you @dcaro

[craiglandis]

This broke all prediction for me, not just Az prediction. With Az.Tools.Predictor loaded I only ever see a single prediction - for Send-AzPredictorRating. Adding a feedback mechanism that breaks the module is not a great way to solicit feedback. :-)

I've uninstalled it for now. Since it's typically in use, I close all PS sessions and run this from CMD -

pwsh -noprofile -nologo -command Uninstall-Module -Name Az.Tools.Predictor

[brwilkinson]

@craiglandis what pwsh version are you on and which version of psreadline do you have installed?

[craiglandis]

@craiglandis what pwsh version are you on and which version of psreadline do you have installed?

PS 7.2.1, Az.Tools.Predictor 0.5.0

[brwilkinson]

Script 2.2.0 beta4 PSReadLine ?

    if ( $PSVersionTable.psversion.Major -ge 7  -and $PSVersionTable.PSVersion.Minor -ge 2)
    {
        Enable-AzPredictor
        Set-PSReadLineOption -PredictionViewStyle ListView
        Set-PSReadLineOption -PredictionSource HistoryAndPlugin
    }

Is this what you have?

[kceiw]

@craiglandis Can you please help us to improve the qualify by giving us some examples like what you types when you see it's broken?

Az Predictor only shows the suggestions based on the command history and the command you're typing (The commands are Az commands). If there are no suggestions, it doesn't show anything. It gets the suggestions from our server. So it also requires Internet connection. "Send-AzPredictorRating" doesn't require Internet connection and is always shown as the last item in the suggestion list. So even if there are no suggestions for what you types or there is no Internet connection, we still show this cmdlet.

I ask for your input because I would like to try it at my side and also trying to see if we have any gaps in the model we use for the suggestions.

[brwilkinson]

Hi @dcaro It seems the survey prompt is having more impact than I initially thought.

There has been an issue over on PowerShell/vscode-powershell#3701 that relates to the survey functionality.

It seems the eventsubscriber as below is causing exceptions within PsReadline and powershell editor services within VSCode.

Get-EventSubscriber -Force  | foreach action | foreach command

                if ([Microsoft.Azure.PowerShell.Tools.AzPredictor.AzPredictorData]::ShowSurveyOnIdle) {
                    [Microsoft.Azure.PowerShell.Tools.AzPredictor.AzPredictorData]::ShowSurveyOnIdle = $False
                    Write-Host ''
                    Write-Host ''; Write-Host `Survey: -ForegroundColor $Host.PrivateData.VerboseBackgroundColor -BackgroundColor $host.PrivateData.VerboseForegroundColor -NoNewLine; Write-Host ' How was your experience using the Az Predictor module?'
                    Write-Host ''
                    Write-Host 'Run ' -NoNewline; Write-Host Open-AzPredictorSurvey -ForegroundColor $Host.PrivateData.VerboseBackgroundColor -BackgroundColor $host.PrivateData.VerboseForegroundColor -NoNewline; Write-Host ' to give us your feedback.'
                    Write-Host ''
                    Write-Host '(Use "Ctrl + C" to return to the prompt)'
                }

[brwilkinson]

for a workaround I am deleting the event subscriber directly after the AzPredictor is loaded.

    if ( $PSVersionTable.psversion.Major -ge 7 -and $PSVersionTable.PSVersion.Minor -ge 2)
    {
        Enable-AzPredictor
        Set-PSReadLineOption -PredictionViewStyle ListView
        Set-PSReadLineOption -PredictionSource HistoryAndPlugin
        Get-EventSubscriber -Force -SourceIdentifier PowerShell.OnIdle -EA 0 | Unregister-Event -Force
    }

[brwilkinson]

Please ... please ... please ... please... please... please... please...

please can we remove this feature ?

How many people have sent a ratings request ?

This is EXTREMELY frustrating.

I can only say that if I walked into your Office and put a quite distracting object on your clean office desk that takes up quite a large amount of space "of your workspace" so that you had to constantly look at it, how frustrating would that be?

or at least make it configurable or time based?

I gave a rating and it still shows up ?

[dcaro]

@brwilkinson this additional line was an experiment that we did to understand better how to prompt users for feedback in a command line tool.
We will remove this in the upcoming release of Az.Tools.Predictor.

[brwilkinson]

Thank you @dcaro 🙏🏼

[brwilkinson]

great news

Thanks all.