Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider upgrading common-types to v6 #734

Closed
mikeharder opened this issue Aug 26, 2024 · 1 comment
Closed

Consider upgrading common-types to v6 #734

mikeharder opened this issue Aug 26, 2024 · 1 comment
Assignees

Comments

@mikeharder
Copy link
Member

mikeharder commented Aug 26, 2024

v6 common types were added in this PR:

Azure/azure-rest-api-specs#29155

But azure-openapi-validator was not updated to match:

export const LATEST_VERSION_BY_COMMON_TYPES_FILENAME = new Map([
["types.json", "v5"],
["managedidentity.json", "v5"],
["privatelinks.json", "v5"],
["customermanagedkeys.json", "v5"],
["managedidentitywithdelegation.json", "v5"],
["networksecurityperimeter.json", "v5"],
["mobo.json", "v5"],
])

Should it be?

@tejaswiMinnu
Copy link
Contributor

PR - #735

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@mikeharder @tejaswiMinnu and others