Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive for parent segments in path? #720

Open
TimLovellSmith opened this issue Jul 3, 2024 · 0 comments
Open

False positive for parent segments in path? #720

TimLovellSmith opened this issue Jul 3, 2024 · 0 comments

Comments

@TimLovellSmith
Copy link
Member

Describe the bug

We get LintDiff warnings like this.

⚠️ MissingSegmentsInNestedResourceListOperation | A nested resource type's List operation must include all the parent segments in its api path.Location: Microsoft.Network/preview/2024-01-01-preview/ipAddressManager.json#L8 | RPC-Get-V1-11

But its unclear why.

The path its complaining about seems to be
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkManagers/{networkManagerName}/verifierWorkspaces/{workspaceName}/reachabilityAnalysisIntents": {

it looks like the parent path declaration is compatible:
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkManagers/{networkManagerName}/verifierWorkspaces/{workspaceName}": {

source file:
https://github.com/Azure/azure-rest-api-specs-pr/blob/bdafd95bd0cd77f68be044bd5e8436518c9f5920/specification/network/resource-manager/Microsoft.Network/preview/2024-01-01-preview/networkVerifier.json#

Is the analyzer confused by the extra query parameters?

To Reproduce
Steps to reproduce the behavior:
See
https://github.com/Azure/azure-rest-api-specs-pr/pull/17956/checks?check_run_id=26909351197

Expected behavior
If its a real false positive, no warning, right.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Additional context

@TimLovellSmith TimLovellSmith changed the title False positive? False positive for parent segments in path? Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant