We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rule AvoidAdditionalProperties raised an error for the following swagger:
AvoidAdditionalProperties
"vmTags": { "type": "object", "additionalProperties": { "type": "string" }, "description": "Hashtable that lists key/value pair tags to apply to the VMs" },
Currently, additionalProperties is only automatically allowed under properties named exactly tags:
additionalProperties
tags
azure-openapi-validator/packages/rulesets/src/spectral/az-arm.ts
Lines 297 to 306 in b95d5eb
The proposal is to broaden the range of allowed properties, to anything matching regex [Tt]ags (or something similar that would allow vmTags).
[Tt]ags
vmTags
We may also need to align with RPC-Policy-V1-05 and RPC-Put-V1-23 which are mentioned here:
RPC-Policy-V1-05
RPC-Put-V1-23
https://github.com/Azure/azure-openapi-validator/blob/b95d5eb121c47ab3e110c97da23e583ebfd637ee/docs/avoid-additional-properties.md#related-arm-guideline-code
The status quo is to require suppressions for properties with names similar to (but not exactly) tags.
Spec PR: https://github.com/Azure/azure-rest-api-specs/pull/29101/checks?check_run_id=25631949240
CC: @markcowl, @almat-msft
The text was updated successfully, but these errors were encountered:
We believe the root cause is more related to #652 than the name of the property.
Sorry, something went wrong.
mikeharder
No branches or pull requests
Rule
AvoidAdditionalProperties
raised an error for the following swagger:Currently,
additionalProperties
is only automatically allowed under properties named exactlytags
:azure-openapi-validator/packages/rulesets/src/spectral/az-arm.ts
Lines 297 to 306 in b95d5eb
The proposal is to broaden the range of allowed properties, to anything matching regex
[Tt]ags
(or something similar that would allowvmTags
).We may also need to align with
RPC-Policy-V1-05
andRPC-Put-V1-23
which are mentioned here:https://github.com/Azure/azure-openapi-validator/blob/b95d5eb121c47ab3e110c97da23e583ebfd637ee/docs/avoid-additional-properties.md#related-arm-guideline-code
The status quo is to require suppressions for properties with names similar to (but not exactly)
tags
.Spec PR: https://github.com/Azure/azure-rest-api-specs/pull/29101/checks?check_run_id=25631949240
CC: @markcowl, @almat-msft
The text was updated successfully, but these errors were encountered: