-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(all): update dependencies, move to dependency management in main pom #1476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtay-microsoft
requested review from
azabbasi,
drwill-ms,
abhipsaMisra and
brycewang-microsoft
as code owners
March 2, 2022 19:04
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
abhipsaMisra
reviewed
Mar 2, 2022
abhipsaMisra
approved these changes
Mar 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
…main pom The dependency management section in the base pom.xml defines which versions of each library will be used throughout the entire project. This does not mean that each library will take a dependency on each library defined in this dependencyManagement section though. For instance, our device client pom still needs to declare a dependency on our mqtt library. It just doesn't need to specify the version anymore since it is defined in our dependencyManagement in our base pom
timtay-microsoft
force-pushed
the
timtay/upgradeDeps
branch
from
March 2, 2022 22:58
b92cab4
to
edda58f
Compare
/azp run horton-java-gate, SDL, Java Prod Basic |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
/azp run horton-java-gate, Java Prod Basic, SDL |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependency management section in the base pom.xml defines which versions of each library will be used throughout the entire project. This does not mean that each library will take a dependency on each library defined in this dependencyManagement section though. For instance, our device client pom still needs to declare a dependency on our mqtt library. It just doesn't need to specify the version anymore since it is defined in our dependencyManagement in our base pom