Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 10 support #66

Closed
mhoeger opened this issue May 2, 2018 · 6 comments
Closed

Node 10 support #66

mhoeger opened this issue May 2, 2018 · 6 comments
Assignees
Labels
Milestone

Comments

@mhoeger
Copy link
Contributor

mhoeger commented May 2, 2018

Although Node 8 is under long-term support, Node 9 is current. Any install via brew or chocolatey will default to Node 9, which creates a bad experience for local developers that install node for the first time on a machine and must downgrade to 8.

UPDATE: node 10 just released

@mhoeger mhoeger self-assigned this May 2, 2018
@mhoeger mhoeger changed the title Node 9 support? Node 10 support May 3, 2018
@mhoeger
Copy link
Contributor Author

mhoeger commented May 11, 2018

We want to update to (at least) [email protected] and [email protected]

Blocked by issue in grpc-node
There's an error in grpc's index.d.ts file that keeps us from being able to use [email protected] in the same project: grpc/grpc-node#176

@ahmelsayed
Copy link

why is this breaking? Does it mean we will drop node 8?

@mhoeger
Copy link
Contributor Author

mhoeger commented May 15, 2018

I don't think we've decided whether or not we're keeping node 8 as a backup (likely yes? @paulbatum), but we definitely will be changing the default version to 10

@ahmelsayed
Copy link

thanks @mhoeger I was asking in the context of the email thread about handling WEBSITE_NODE_DEFAULT_VERSION, I'll respond on that thread

@paulbatum
Copy link
Member

Since V2 is still in beta, my preference is to only support node 10 i.e. V2 apps would be set to node 10, we would emit a warning if a different version was detected, our test coverage would be on node 10, etc. We can do all this without deliberately blocking node 8. At least this way we are able to postpone engineering challenges implicit in supporting multiple node versions (such as doing test runs against multiple versions).

@mhoeger mhoeger modified the milestones: Sprint 23, Sprint 24 May 17, 2018
@mhoeger mhoeger modified the milestones: Sprint 24, Sprint 25 May 30, 2018
@mhoeger mhoeger closed this as completed Jun 12, 2018
@mhoeger mhoeger reopened this Jun 13, 2018
@mhoeger
Copy link
Contributor Author

mhoeger commented Jun 13, 2018

re-opening to track pulling to functions-host repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants