Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove undici dependency #305

Open
ejizba opened this issue Oct 9, 2024 · 0 comments
Open

Remove undici dependency #305

ejizba opened this issue Oct 9, 2024 · 0 comments

Comments

@ejizba
Copy link
Contributor

ejizba commented Oct 9, 2024

Background: Removing this was the plan all along when we created the new programming model. Part of the reason we chose undici for our http types was because it was being integrated into Node.js core at the time (with v18), but unfortunately it was still marked experimental in Node.js core even though the standalone package was marked stable. The support in Node.js core was just marked stable in Node.js v22 (see here) so we can now use the core module directly instead of the standalone package. Removing this by far has the biggest and best impact on cold start, as the undici standalone package has an annoyingly large number of files that is slowing things down.

Breaking change: Customers should see very little functional impact. The risk here is more around TypeScript builds getting broken due to slightly different request/response types coming from a slightly different place. The biggest breaking change is that this relies on Node.js v22 and our current minimum for v4 of the package is v18.

Branch to remove: ej/removeUndici

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant